From: Andrew Morton <akpm@linux-foundation.org>
To: Hugh Dickins <hughd@google.com>
Cc: Chris Metcalf <cmetcalf@tilera.com>,
Hillf Danton <dhillf@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michal Hocko <mhocko@suse.cz>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH v2] hugetlb: fix race condition in hugetlb_fault()
Date: Fri, 6 Apr 2012 16:26:18 -0700 [thread overview]
Message-ID: <20120406162618.3307a9bd.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LSU.2.00.1204061601370.3637@eggly.anvils>
On Fri, 6 Apr 2012 16:10:13 -0700 (PDT)
Hugh Dickins <hughd@google.com> wrote:
> On Fri, 6 Apr 2012, Andrew Morton wrote:
> > On Sun, 1 Apr 2012 12:51:49 -0400
> > Chris Metcalf <cmetcalf@tilera.com> wrote:
> >
> > > >> Cc: stable@kernel.org
> > > > Let Andrew do the stable work, ok?
> > >
> > > Fair point. I'm used to adding the Cc myself for things I push through the
> > > arch/tile tree. This of course does make more sense to go through Andrew,
> > > so I'll remove it.
> >
> > No, please do add the stable tag if you think it is needed. And ensure
> > that the changelog explains why a backport is needed, by describing
> > the user-visible effects of the bug.
> >
> > Tree-owners regularly forget to wonder if a patch should be backported
> > and we end up failing to backport patches which should have been
> > backported. If we have more people flagging backport patches, fewer
> > patches will fall through the cracks.
>
> The resulting patch is okay; but let's reassure Chris that his
> original patch was better, before he conceded to make the get_page
> and put_page unconditional, and added unnecessary detail of the race.
>
Yes, the v1 patch was better. No reason was given for changing it?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Hugh Dickins <hughd@google.com>
Cc: Chris Metcalf <cmetcalf@tilera.com>,
Hillf Danton <dhillf@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michal Hocko <mhocko@suse.cz>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH v2] hugetlb: fix race condition in hugetlb_fault()
Date: Fri, 6 Apr 2012 16:26:18 -0700 [thread overview]
Message-ID: <20120406162618.3307a9bd.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LSU.2.00.1204061601370.3637@eggly.anvils>
On Fri, 6 Apr 2012 16:10:13 -0700 (PDT)
Hugh Dickins <hughd@google.com> wrote:
> On Fri, 6 Apr 2012, Andrew Morton wrote:
> > On Sun, 1 Apr 2012 12:51:49 -0400
> > Chris Metcalf <cmetcalf@tilera.com> wrote:
> >
> > > >> Cc: stable@kernel.org
> > > > Let Andrew do the stable work, ok?
> > >
> > > Fair point. I'm used to adding the Cc myself for things I push through the
> > > arch/tile tree. This of course does make more sense to go through Andrew,
> > > so I'll remove it.
> >
> > No, please do add the stable tag if you think it is needed. And ensure
> > that the changelog explains why a backport is needed, by describing
> > the user-visible effects of the bug.
> >
> > Tree-owners regularly forget to wonder if a patch should be backported
> > and we end up failing to backport patches which should have been
> > backported. If we have more people flagging backport patches, fewer
> > patches will fall through the cracks.
>
> The resulting patch is okay; but let's reassure Chris that his
> original patch was better, before he conceded to make the get_page
> and put_page unconditional, and added unnecessary detail of the race.
>
Yes, the v1 patch was better. No reason was given for changing it?
next prev parent reply other threads:[~2012-04-06 23:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 20:07 [PATCH] hugetlb: fix race condition in hugetlb_fault() Chris Metcalf
2012-03-30 20:07 ` Chris Metcalf
2012-03-31 12:27 ` Hillf Danton
2012-03-31 12:27 ` Hillf Danton
2012-03-30 19:37 ` [PATCH v2] arch/tile: support multiple huge page sizes dynamically Chris Metcalf
2012-03-30 19:37 ` Chris Metcalf
2012-03-31 14:03 ` Hillf Danton
2012-03-31 14:03 ` Hillf Danton
2012-03-30 19:37 ` [PATCH v3] " Chris Metcalf
2012-03-30 19:37 ` Chris Metcalf
2012-04-01 12:33 ` Hillf Danton
2012-04-01 12:33 ` Hillf Danton
2012-04-01 16:46 ` Chris Metcalf
2012-04-01 16:46 ` Chris Metcalf
2012-04-02 2:21 ` Hillf Danton
2012-04-02 2:21 ` Hillf Danton
2012-03-30 20:07 ` [PATCH v2] hugetlb: fix race condition in hugetlb_fault() Chris Metcalf
2012-03-30 20:07 ` Chris Metcalf
2012-04-01 12:10 ` Hillf Danton
2012-04-01 12:10 ` Hillf Danton
2012-04-01 16:51 ` Chris Metcalf
2012-04-01 16:51 ` Chris Metcalf
2012-03-30 20:07 ` [PATCH v3] " Chris Metcalf
2012-03-30 20:07 ` Chris Metcalf
2012-04-06 22:23 ` [PATCH v2] " Andrew Morton
2012-04-06 22:23 ` Andrew Morton
2012-04-06 23:10 ` Hugh Dickins
2012-04-06 23:10 ` Hugh Dickins
2012-04-06 23:26 ` Andrew Morton [this message]
2012-04-06 23:26 ` Andrew Morton
2012-04-06 23:35 ` Hugh Dickins
2012-04-06 23:35 ` Hugh Dickins
2012-04-07 0:25 ` Chris Metcalf
2012-04-07 0:25 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120406162618.3307a9bd.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cmetcalf@tilera.com \
--cc=dhillf@gmail.com \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.