From: Greg KH <gregkh@linuxfoundation.org>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, sudhakar <sudhakar@fb.com>,
linux-serial@vger.kernel.org, alan@linux.intel.com,
nhan.h.mai@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] 8250_pci: Replace commits 448ac154 and e86ff4a
Date: Mon, 9 Apr 2012 10:48:23 -0700 [thread overview]
Message-ID: <20120409174823.GA31394@kroah.com> (raw)
In-Reply-To: <CABE8wwsHZLiihEReRQwkk+SufkmBw2W4n-WibQgS-rEOnKNGMA@mail.gmail.com>
On Mon, Apr 09, 2012 at 09:53:47AM -0700, Williams, Dan J wrote:
> On Mon, Apr 9, 2012 at 9:47 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Tue, Apr 03, 2012 at 09:58:32PM +0100, Alan Cox wrote:
> >> On Tue, 3 Apr 2012 12:43:20 -0700
> >> sudhakar <sudhakar@fb.com> wrote:
> >>
> >> >
> >> > From: Sudhakar Mamillapalli <sudhakar@fb.com>
> >> >
> >> >
> >> > The following commits don't completely fix the KT serial missing
> >> > interrupt problems. So they have been replaced instead by
> >> > enabling serial backup timer. The iir-once + msi tried approach tried
> >> > to enforce one read of the iir per THRE event, but its defeated by any
> >> > other event occurring at the wrong time, particularly MSR events.
> >> >
> >> > 448ac15 serial/8250_pci: setup-quirk workaround for the kt serial controller
> >> > e86ff4a serial/8250_pci: init-quirk msi support for kt serial controller
> >>
> >> These are already in tree. If you are reversing them and adding a
> >> different fix then please post the series as
> >>
> >> - two revert patches exactly reverting the two commits
> >> - a follow on patch or two adding the replacement
> >>
> >> That makes it much easier to review and much more obvious. It also helps
> >> make testing simpler.
> >
> > I agree, Sudhakar, can you please redo these 2 patches?
> >
>
> Hi Greg,
>
> This was in the series:
>
> [PATCH 0/6] rework quirks for the "kt" serial port [1]
>
> ...but I have just noticed it collides with current git, and I also
> need to address Stephen's comments for Tegra. Expect a v2 shortly.
Ok, thanks. Note, I just applied the first 3 to go to Linus soon, those
didn't need to be reworked, right?
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, sudhakar <sudhakar@fb.com>,
linux-serial@vger.kernel.org, alan@linux.intel.com,
nhan.h.mai@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] 8250_pci: Replace commits 448ac154 and e86ff4a
Date: Mon, 9 Apr 2012 10:48:23 -0700 [thread overview]
Message-ID: <20120409174823.GA31394@kroah.com> (raw)
In-Reply-To: <CABE8wwsHZLiihEReRQwkk+SufkmBw2W4n-WibQgS-rEOnKNGMA@mail.gmail.com>
On Mon, Apr 09, 2012 at 09:53:47AM -0700, Williams, Dan J wrote:
> On Mon, Apr 9, 2012 at 9:47 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Tue, Apr 03, 2012 at 09:58:32PM +0100, Alan Cox wrote:
> >> On Tue, 3 Apr 2012 12:43:20 -0700
> >> sudhakar <sudhakar@fb.com> wrote:
> >>
> >> >
> >> > From: Sudhakar Mamillapalli <sudhakar@fb.com>
> >> >
> >> >
> >> > The following commits don't completely fix the KT serial missing
> >> > interrupt problems. So they have been replaced instead by
> >> > enabling serial backup timer. The iir-once + msi tried approach tried
> >> > to enforce one read of the iir per THRE event, but its defeated by any
> >> > other event occurring at the wrong time, particularly MSR events.
> >> >
> >> > 448ac15 serial/8250_pci: setup-quirk workaround for the kt serial controller
> >> > e86ff4a serial/8250_pci: init-quirk msi support for kt serial controller
> >>
> >> These are already in tree. If you are reversing them and adding a
> >> different fix then please post the series as
> >>
> >> - two revert patches exactly reverting the two commits
> >> - a follow on patch or two adding the replacement
> >>
> >> That makes it much easier to review and much more obvious. It also helps
> >> make testing simpler.
> >
> > I agree, Sudhakar, can you please redo these 2 patches?
> >
>
> Hi Greg,
>
> This was in the series:
>
> [PATCH 0/6] rework quirks for the "kt" serial port [1]
>
> ...but I have just noticed it collides with current git, and I also
> need to address Stephen's comments for Tegra. Expect a v2 shortly.
Ok, thanks. Note, I just applied the first 3 to go to Linus soon, those
didn't need to be reworked, right?
greg k-h
next prev parent reply other threads:[~2012-04-09 17:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 19:43 [PATCH 1/2] 8250_pci: Replace commits 448ac154 and e86ff4a sudhakar
2012-04-03 19:43 ` sudhakar
2012-04-03 20:09 ` Williams, Dan J
2012-04-03 20:09 ` Williams, Dan J
2012-04-03 20:58 ` Alan Cox
2012-04-03 20:58 ` Alan Cox
2012-04-09 16:47 ` Greg KH
2012-04-09 16:53 ` Williams, Dan J
2012-04-09 16:53 ` Williams, Dan J
2012-04-09 17:48 ` Greg KH [this message]
2012-04-09 17:48 ` Greg KH
2012-04-09 17:59 ` Williams, Dan J
2012-04-09 17:59 ` Williams, Dan J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120409174823.GA31394@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nhan.h.mai@intel.com \
--cc=sudhakar@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.