[PATCH] TPACPI: Make W510 microphone LED working

[PATCH] TPACPI: Make W510 microphone LED working

[Marek Vasut]

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
 drivers/platform/x86/thinkpad_acpi.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index d68c000..9cd366a 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -5055,8 +5055,10 @@ static const char * const tpacpi_led_names[TPACPI_LED_NUMLEDS] = {
 	"tpacpi::unknown_led2",
 	"tpacpi::unknown_led3",
 	"tpacpi::thinkvantage",
+	"tpacpi::unknown_led4",
+	"tpacpi::microphone",
 };
-#define TPACPI_SAFE_LEDS	0x1081U
+#define TPACPI_SAFE_LEDS	0x5081U
 
 static inline bool tpacpi_is_led_restricted(const unsigned int led)
 {
@@ -5274,6 +5276,8 @@ static const struct tpacpi_quirk led_useful_qtable[] __initconst = {
 
 	/* (1) - may have excess leds enabled on MSB */
 
+	TPACPI_Q_LNV('6', 'N', 0x43bf), /* W510 */
+
 	/* Defaults (order matters, keep last, don't reorder!) */
 	{ /* Lenovo */
 	  .vendor = PCI_VENDOR_ID_LENOVO,
-- 
1.7.9.1

Re: [PATCH] TPACPI: Make W510 microphone LED working

[Henrique de Moraes Holschuh]

On Sun, 08 Apr 2012, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>

NAK (but noted that the W510 supports the MIC led).

Please look at the recent thread about the same issue on the T410/T420 on
the list archives.  I am still waiting for some direction from that thread.

> -#define TPACPI_SAFE_LEDS	0x1081U
> +#define TPACPI_SAFE_LEDS	0x5081U

This, I really don't want.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [PATCH] TPACPI: Make W510 microphone LED working

[Marek Vasut]

Dear Henrique de Moraes Holschuh,

> On Sun, 08 Apr 2012, Marek Vasut wrote:
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> 
> NAK (but noted that the W510 supports the MIC led).

Well, at least some value was in this patch.

> Please look at the recent thread about the same issue on the T410/T420 on
> the list archives.  I am still waiting for some direction from that thread.
> 
> > -#define TPACPI_SAFE_LEDS	0x1081U
> > +#define TPACPI_SAFE_LEDS	0x5081U
> 
> This, I really don't want.

Ok, honestly, I'm pretty new to acpi hacking, this is my first try. I'll check 
the thread and hopefully get back to this.

Best regards,
Marek Vasut