From: Tony Lindgren <tony@atomide.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP: sram: fix BUG in dpll code for !PM case
Date: Mon, 9 Apr 2012 15:49:47 -0700 [thread overview]
Message-ID: <20120409224946.GC6487@atomide.com> (raw)
In-Reply-To: <1333749201-23255-1-git-send-email-notasas@gmail.com>
* Grazvydas Ignotas <notasas@gmail.com> [120406 14:56]:
> _omap3_sram_configure_core_dpll is called when SDRC is reprogrammed,
> which is done regardless of CONFIG_PM setting, so we always need it's
> setup code too. Without this, we hit a BUG() on OMAP3 when kernel is
> built without CONFIG_PM:
>
> Reprogramming SDRC clock to 332000000 Hz
> ------------[ cut here ]------------
> kernel BUG at arch/arm/plat-omap/sram.c:342!
> Internal error: Oops - BUG: 0 [#1] ARM
> ...
> [<c001c694>] (omap3_configure_core_dpll+0x68/0x6c) from [<c001b2dc>] (omap3_core_dpll_m2_set_rate+0x1)
> [<c001b2dc>] (omap3_core_dpll_m2_set_rate+0x138/0x1b0) from [<c001a478>] (omap2_clk_set_rate+0x14/0x2)
> [<c001a478>] (omap2_clk_set_rate+0x14/0x20) from [<c001c9dc>] (clk_set_rate+0x54/0x74)
> [<c001c9dc>] (clk_set_rate+0x54/0x74) from [<c022b9c8>] (omap_sdrc_init+0x70/0x90)
> [<c022b9c8>] (omap_sdrc_init+0x70/0x90) from [<c022f178>] (omap3pandora_init+0x11c/0x164)
> [<c022f178>] (omap3pandora_init+0x11c/0x164) from [<c022849c>] (customize_machine+0x20/0x28)
> [<c022849c>] (customize_machine+0x20/0x28) from [<c0225810>] (do_one_initcall+0xa0/0x16c)
> [<c0225810>] (do_one_initcall+0xa0/0x16c) from [<c02259e0>] (kernel_init+0x104/0x1ac)
> [<c02259e0>] (kernel_init+0x104/0x1ac) from [<c0009cec>] (kernel_thread_exit+0x0/0x8)
Looks like this was caused by the added ifdef CONFIG_PM from
commit 3231fc88 (OMAP3: PM: restore SRAM functions after off-mode).
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: sram: fix BUG in dpll code for !PM case
Date: Mon, 9 Apr 2012 15:49:47 -0700 [thread overview]
Message-ID: <20120409224946.GC6487@atomide.com> (raw)
In-Reply-To: <1333749201-23255-1-git-send-email-notasas@gmail.com>
* Grazvydas Ignotas <notasas@gmail.com> [120406 14:56]:
> _omap3_sram_configure_core_dpll is called when SDRC is reprogrammed,
> which is done regardless of CONFIG_PM setting, so we always need it's
> setup code too. Without this, we hit a BUG() on OMAP3 when kernel is
> built without CONFIG_PM:
>
> Reprogramming SDRC clock to 332000000 Hz
> ------------[ cut here ]------------
> kernel BUG at arch/arm/plat-omap/sram.c:342!
> Internal error: Oops - BUG: 0 [#1] ARM
> ...
> [<c001c694>] (omap3_configure_core_dpll+0x68/0x6c) from [<c001b2dc>] (omap3_core_dpll_m2_set_rate+0x1)
> [<c001b2dc>] (omap3_core_dpll_m2_set_rate+0x138/0x1b0) from [<c001a478>] (omap2_clk_set_rate+0x14/0x2)
> [<c001a478>] (omap2_clk_set_rate+0x14/0x20) from [<c001c9dc>] (clk_set_rate+0x54/0x74)
> [<c001c9dc>] (clk_set_rate+0x54/0x74) from [<c022b9c8>] (omap_sdrc_init+0x70/0x90)
> [<c022b9c8>] (omap_sdrc_init+0x70/0x90) from [<c022f178>] (omap3pandora_init+0x11c/0x164)
> [<c022f178>] (omap3pandora_init+0x11c/0x164) from [<c022849c>] (customize_machine+0x20/0x28)
> [<c022849c>] (customize_machine+0x20/0x28) from [<c0225810>] (do_one_initcall+0xa0/0x16c)
> [<c0225810>] (do_one_initcall+0xa0/0x16c) from [<c02259e0>] (kernel_init+0x104/0x1ac)
> [<c02259e0>] (kernel_init+0x104/0x1ac) from [<c0009cec>] (kernel_thread_exit+0x0/0x8)
Looks like this was caused by the added ifdef CONFIG_PM from
commit 3231fc88 (OMAP3: PM: restore SRAM functions after off-mode).
Tony
next prev parent reply other threads:[~2012-04-09 22:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 21:53 [PATCH] ARM: OMAP: sram: fix BUG in dpll code for !PM case Grazvydas Ignotas
2012-04-06 21:53 ` Grazvydas Ignotas
2012-04-09 22:49 ` Tony Lindgren [this message]
2012-04-09 22:49 ` Tony Lindgren
2012-04-17 17:22 ` Tony Lindgren
2012-04-17 17:22 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120409224946.GC6487@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.