From: Arnd Bergmann <arnd@arndb.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org,
linux-arch@vger.kernel.org, iommu@lists.linux-foundation.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Joerg Roedel <joro@8bytes.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Chunsang Jeong <chunsang.jeong@linaro.org>,
Krishna Reddy <vdumpa@nvidia.com>,
KyongHo Cho <pullip.cho@samsung.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Hiroshi Doyu <hdoyu@nvidia.com>,
Subash Patel <subashrp@gmail.com>
Subject: Re: [PATCHv8 05/10] ARM: dma-mapping: use asm-generic/dma-mapping-common.h
Date: Tue, 10 Apr 2012 11:47:20 +0000 [thread overview]
Message-ID: <201204101147.20733.arnd@arndb.de> (raw)
In-Reply-To: <1334055852-19500-6-git-send-email-m.szyprowski@samsung.com>
On Tuesday 10 April 2012, Marek Szyprowski wrote:
> This patch modifies dma-mapping implementation on ARM architecture to
> use common dma_map_ops structure and asm-generic/dma-mapping-common.h
> helpers.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/Kconfig | 1 +
> arch/arm/include/asm/device.h | 1 +
> arch/arm/include/asm/dma-mapping.h | 196 +++++-------------------------------
> arch/arm/mm/dma-mapping.c | 148 ++++++++++++++++-----------
> 4 files changed, 115 insertions(+), 231 deletions(-)
Looks good in principle. One question: Now that many of the functions are only
used in the dma_map_ops, can you make them 'static' instead?
Arnd
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org,
linux-arch@vger.kernel.org, iommu@lists.linux-foundation.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Joerg Roedel <joro@8bytes.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Chunsang Jeong <chunsang.jeong@linaro.org>,
Krishna Reddy <vdumpa@nvidia.com>,
KyongHo Cho <pullip.cho@samsung.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Hiroshi Doyu <hdoyu@nvidia.com>,
Subash Patel <subashrp@gmail.com>
Subject: Re: [PATCHv8 05/10] ARM: dma-mapping: use asm-generic/dma-mapping-common.h
Date: Tue, 10 Apr 2012 11:47:20 +0000 [thread overview]
Message-ID: <201204101147.20733.arnd@arndb.de> (raw)
Message-ID: <20120410114720.GVH2eAVRVtAMRRP1RUwVg4hEvPU408weeqC0qytuw9A@z> (raw)
In-Reply-To: <1334055852-19500-6-git-send-email-m.szyprowski@samsung.com>
On Tuesday 10 April 2012, Marek Szyprowski wrote:
> This patch modifies dma-mapping implementation on ARM architecture to
> use common dma_map_ops structure and asm-generic/dma-mapping-common.h
> helpers.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/Kconfig | 1 +
> arch/arm/include/asm/device.h | 1 +
> arch/arm/include/asm/dma-mapping.h | 196 +++++-------------------------------
> arch/arm/mm/dma-mapping.c | 148 ++++++++++++++++-----------
> 4 files changed, 115 insertions(+), 231 deletions(-)
Looks good in principle. One question: Now that many of the functions are only
used in the dma_map_ops, can you make them 'static' instead?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv8 05/10] ARM: dma-mapping: use asm-generic/dma-mapping-common.h
Date: Tue, 10 Apr 2012 11:47:20 +0000 [thread overview]
Message-ID: <201204101147.20733.arnd@arndb.de> (raw)
In-Reply-To: <1334055852-19500-6-git-send-email-m.szyprowski@samsung.com>
On Tuesday 10 April 2012, Marek Szyprowski wrote:
> This patch modifies dma-mapping implementation on ARM architecture to
> use common dma_map_ops structure and asm-generic/dma-mapping-common.h
> helpers.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/Kconfig | 1 +
> arch/arm/include/asm/device.h | 1 +
> arch/arm/include/asm/dma-mapping.h | 196 +++++-------------------------------
> arch/arm/mm/dma-mapping.c | 148 ++++++++++++++++-----------
> 4 files changed, 115 insertions(+), 231 deletions(-)
Looks good in principle. One question: Now that many of the functions are only
used in the dma_map_ops, can you make them 'static' instead?
Arnd
next prev parent reply other threads:[~2012-04-10 11:47 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 11:04 [PATCHv8 00/10] ARM: DMA-mapping framework redesign Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:04 ` [PATCHv8 01/10] common: add dma_mmap_from_coherent() function Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:04 ` [PATCHv8 02/10] ARM: dma-mapping: use pr_* instread of printk Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:41 ` Arnd Bergmann
2012-04-10 11:41 ` Arnd Bergmann
2012-04-10 11:41 ` Arnd Bergmann
2012-04-10 11:04 ` [PATCHv8 03/10] ARM: dma-mapping: introduce ARM_DMA_ERROR constant Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:31 ` Arnd Bergmann
2012-04-10 11:31 ` Arnd Bergmann
2012-04-10 11:31 ` Arnd Bergmann
2012-04-10 12:53 ` Marek Szyprowski
2012-04-10 12:53 ` Marek Szyprowski
2012-04-10 12:53 ` Marek Szyprowski
2012-04-10 11:04 ` [PATCHv8 04/10] ARM: dma-mapping: remove offset parameter to prepare for generic dma_ops Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:43 ` Arnd Bergmann
2012-04-10 11:43 ` Arnd Bergmann
2012-04-10 11:43 ` Arnd Bergmann
2012-04-10 11:43 ` Arnd Bergmann
2012-04-11 12:05 ` Marek Szyprowski
2012-04-11 12:05 ` Marek Szyprowski
2012-04-11 12:05 ` Marek Szyprowski
2012-04-11 12:18 ` Arnd Bergmann
2012-04-11 12:18 ` Arnd Bergmann
2012-04-11 12:18 ` Arnd Bergmann
2012-04-11 13:05 ` Marek Szyprowski
2012-04-11 13:05 ` Marek Szyprowski
2012-04-11 13:05 ` Marek Szyprowski
2012-04-10 11:04 ` [PATCHv8 05/10] ARM: dma-mapping: use asm-generic/dma-mapping-common.h Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:47 ` Arnd Bergmann [this message]
2012-04-10 11:47 ` Arnd Bergmann
2012-04-10 11:47 ` Arnd Bergmann
2012-04-11 12:07 ` Marek Szyprowski
2012-04-11 12:07 ` Marek Szyprowski
2012-04-11 12:07 ` Marek Szyprowski
2012-04-10 11:04 ` [PATCHv8 06/10] ARM: dma-mapping: implement dma sg methods on top of any generic dma ops Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:04 ` [PATCHv8 07/10] ARM: dma-mapping: move all dma bounce code to separate dma ops structure Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
[not found] ` <1334055852-19500-8-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-04-10 12:24 ` Arnd Bergmann
2012-04-10 12:24 ` Arnd Bergmann
2012-04-10 12:24 ` Arnd Bergmann
2012-04-10 12:24 ` Arnd Bergmann
[not found] ` <201204101224.24959.arnd-r2nGTMty4D4@public.gmane.org>
2012-04-10 12:51 ` Marek Szyprowski
2012-04-10 12:51 ` Marek Szyprowski
2012-04-10 12:51 ` Marek Szyprowski
2012-04-10 12:51 ` Marek Szyprowski
2012-04-10 13:17 ` Arnd Bergmann
2012-04-10 13:17 ` Arnd Bergmann
2012-04-10 13:17 ` Arnd Bergmann
2012-04-10 11:04 ` [PATCHv8 09/10] ARM: dma-mapping: use alloc, mmap, free from dma_ops Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
[not found] ` <1334055852-19500-10-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-04-10 12:21 ` Arnd Bergmann
2012-04-10 12:21 ` Arnd Bergmann
2012-04-10 12:21 ` Arnd Bergmann
2012-04-10 12:21 ` Arnd Bergmann
2012-04-10 11:04 ` [PATCHv8 10/10] ARM: dma-mapping: add support for IOMMU mapper Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:58 ` Arnd Bergmann
2012-04-10 11:58 ` Arnd Bergmann
2012-04-10 11:58 ` Arnd Bergmann
2012-04-10 11:58 ` Arnd Bergmann
[not found] ` <201204101158.29590.arnd-r2nGTMty4D4@public.gmane.org>
2012-04-10 12:57 ` Marek Szyprowski
2012-04-10 12:57 ` Marek Szyprowski
2012-04-10 12:57 ` Marek Szyprowski
2012-04-10 12:57 ` Marek Szyprowski
2012-04-12 9:49 ` Marek Szyprowski
2012-04-12 9:49 ` Marek Szyprowski
2012-04-12 9:49 ` Marek Szyprowski
[not found] ` <1334055852-19500-1-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-04-10 11:04 ` [PATCHv8 08/10] ARM: dma-mapping: remove redundant code and cleanup Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 11:04 ` Marek Szyprowski
2012-04-10 12:22 ` Arnd Bergmann
2012-04-10 12:22 ` Arnd Bergmann
2012-04-10 12:22 ` Arnd Bergmann
2012-04-18 7:14 ` [PATCHv8 00/10] ARM: DMA-mapping framework redesign Subash Patel
2012-04-18 7:14 ` Subash Patel
2012-04-18 7:14 ` Subash Patel
2012-04-18 7:14 ` Subash Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204101147.20733.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=andrzej.p@samsung.com \
--cc=benh@kernel.crashing.org \
--cc=chunsang.jeong@linaro.org \
--cc=hdoyu@nvidia.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=konrad.wilk@oracle.com \
--cc=kyungmin.park@samsung.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=pullip.cho@samsung.com \
--cc=subashrp@gmail.com \
--cc=vdumpa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.