From: "Michael S. Tsirkin" <mst@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: axboe@kernel.dk, kvm@vger.kernel.org, linux-scsi@vger.kernel.org,
asamymuthupa@micron.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
James.Bottomley@HansenPartnership.com,
Ren Mingxin <renmx@cn.fujitsu.com>, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] virtio_blk: Add help function to format mass of disks
Date: Tue, 10 Apr 2012 18:53:08 +0300 [thread overview]
Message-ID: <20120410155308.GB20551@redhat.com> (raw)
In-Reply-To: <20120410154943.GB11614@dhcp-172-17-108-109.mtv.corp.google.com>
On Tue, Apr 10, 2012 at 08:49:43AM -0700, Tejun Heo wrote:
> Hello, guys.
>
> On Tue, Apr 10, 2012 at 04:34:06PM +0300, Michael S. Tsirkin wrote:
> > > Why not use 'base' below? neither unit nor base change.
> >
> > Yes it's a bit strange, it was the same in Tejun's patch.
> > Tejun, any idea?
>
> It was years ago, so I don't recall much. I think I wanted to use a
> variable name which signifies its role - I worked out the rather
> convoluted base number logic on paper first and I probably wanted to
> keep the distinctions. I don't think it really matters at this point
> tho. Just make sure those functions are marked deprecated so that no
> one else copies them.
>
> Thanks.
I guess I'll keep it same so it's easier to deduplicate
if someon wants to.
> --
> tejun
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Avi Kivity <avi@redhat.com>, Ren Mingxin <renmx@cn.fujitsu.com>,
rusty@rustcorp.com.au, axboe@kernel.dk,
James.Bottomley@HansenPartnership.com, asamymuthupa@micron.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_blk: Add help function to format mass of disks
Date: Tue, 10 Apr 2012 18:53:08 +0300 [thread overview]
Message-ID: <20120410155308.GB20551@redhat.com> (raw)
In-Reply-To: <20120410154943.GB11614@dhcp-172-17-108-109.mtv.corp.google.com>
On Tue, Apr 10, 2012 at 08:49:43AM -0700, Tejun Heo wrote:
> Hello, guys.
>
> On Tue, Apr 10, 2012 at 04:34:06PM +0300, Michael S. Tsirkin wrote:
> > > Why not use 'base' below? neither unit nor base change.
> >
> > Yes it's a bit strange, it was the same in Tejun's patch.
> > Tejun, any idea?
>
> It was years ago, so I don't recall much. I think I wanted to use a
> variable name which signifies its role - I worked out the rather
> convoluted base number logic on paper first and I probably wanted to
> keep the distinctions. I don't think it really matters at this point
> tho. Just make sure those functions are marked deprecated so that no
> one else copies them.
>
> Thanks.
I guess I'll keep it same so it's easier to deduplicate
if someon wants to.
> --
> tejun
next prev parent reply other threads:[~2012-04-10 15:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 7:28 [PATCH] virtio_blk: Add help function to format mass of disks Ren Mingxin
2012-04-10 7:28 ` Ren Mingxin
2012-04-10 13:08 ` Asias He
2012-04-10 13:08 ` Asias He
2012-04-10 13:16 ` Avi Kivity
2012-04-10 13:16 ` Avi Kivity
2012-04-10 13:34 ` Michael S. Tsirkin
2012-04-10 13:34 ` Michael S. Tsirkin
2012-04-10 15:49 ` Tejun Heo
2012-04-10 15:49 ` Tejun Heo
2012-04-10 15:53 ` Michael S. Tsirkin [this message]
2012-04-10 15:53 ` Michael S. Tsirkin
2012-04-11 1:21 ` Asias He
2012-04-11 1:21 ` Asias He
2012-04-11 1:31 ` Ren Mingxin
2012-04-11 1:31 ` Ren Mingxin
2012-04-11 1:28 ` Ren Mingxin
2012-04-11 1:28 ` Ren Mingxin
2012-04-11 8:43 ` Michael S. Tsirkin
2012-04-11 8:43 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410155308.GB20551@redhat.com \
--to=mst@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=asamymuthupa@micron.com \
--cc=avi@redhat.com \
--cc=axboe@kernel.dk \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=renmx@cn.fujitsu.com \
--cc=tj@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.