All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][resend] hexagon: Remove unneeded include of version.h
@ 2012-04-10 21:37 Jesper Juhl
  2012-04-10 21:53 ` Richard Kuo
  0 siblings, 1 reply; 3+ messages in thread
From: Jesper Juhl @ 2012-04-10 21:37 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-hexagon, Richard Kuo, Arnd Bergmann, Thomas Gleixner,
	Linas Vepstas, trivial

"make versioncheck" points out that arch/hexagon/include/asm/spinlock_types.h
does not need to include version.h .
A quick look at the file seems to confirm its findings, so here's a patch that
removes the include.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Linas Vepstas <linasvepstas@gmail.com>
---
 arch/hexagon/include/asm/spinlock_types.h |    2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/hexagon/include/asm/spinlock_types.h b/arch/hexagon/include/asm/spinlock_types.h
index 5e937af..99b5a75 100644
--- a/arch/hexagon/include/asm/spinlock_types.h
+++ b/arch/hexagon/include/asm/spinlock_types.h
@@ -21,8 +21,6 @@
 #ifndef _ASM_SPINLOCK_TYPES_H
 #define _ASM_SPINLOCK_TYPES_H
 
-#include <linux/version.h>
-
 #ifndef __LINUX_SPINLOCK_TYPES_H
 # error "please don't include this file directly"
 #endif
-- 
1.7.10


-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH][resend] hexagon: Remove unneeded include of version.h
  2012-04-10 21:37 [PATCH][resend] hexagon: Remove unneeded include of version.h Jesper Juhl
@ 2012-04-10 21:53 ` Richard Kuo
  2012-04-10 22:02   ` Jesper Juhl
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Kuo @ 2012-04-10 21:53 UTC (permalink / raw)
  To: Jesper Juhl
  Cc: linux-kernel, linux-hexagon, Arnd Bergmann, Thomas Gleixner,
	Linas Vepstas, trivial

On Tue, Apr 10, 2012 at 11:37:23PM +0200, Jesper Juhl wrote:
> "make versioncheck" points out that arch/hexagon/include/asm/spinlock_types.h
> does not need to include version.h .
> A quick look at the file seems to confirm its findings, so here's a patch that
> removes the include.
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> Acked-by: Linas Vepstas <linasvepstas@gmail.com>
> ---
>  arch/hexagon/include/asm/spinlock_types.h |    2 --
>  1 file changed, 2 deletions(-)
> 

I've applied this patch to my tree (it's already spent some time in
linux-next as well) and it will go out with my next pull request.


Thanks,
Richard Kuo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][resend] hexagon: Remove unneeded include of version.h
  2012-04-10 21:53 ` Richard Kuo
@ 2012-04-10 22:02   ` Jesper Juhl
  0 siblings, 0 replies; 3+ messages in thread
From: Jesper Juhl @ 2012-04-10 22:02 UTC (permalink / raw)
  To: Richard Kuo
  Cc: linux-kernel, linux-hexagon, Arnd Bergmann, Thomas Gleixner,
	Linas Vepstas, trivial

On Tue, 10 Apr 2012, Richard Kuo wrote:

> On Tue, Apr 10, 2012 at 11:37:23PM +0200, Jesper Juhl wrote:
> > "make versioncheck" points out that arch/hexagon/include/asm/spinlock_types.h
> > does not need to include version.h .
> > A quick look at the file seems to confirm its findings, so here's a patch that
> > removes the include.
> > 
> > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> > Acked-by: Linas Vepstas <linasvepstas@gmail.com>
> > ---
> >  arch/hexagon/include/asm/spinlock_types.h |    2 --
> >  1 file changed, 2 deletions(-)
> > 
> 
> I've applied this patch to my tree (it's already spent some time in
> linux-next as well) and it will go out with my next pull request.
> 
I see.

Thanks.

-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-10 22:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-10 21:37 [PATCH][resend] hexagon: Remove unneeded include of version.h Jesper Juhl
2012-04-10 21:53 ` Richard Kuo
2012-04-10 22:02   ` Jesper Juhl

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.