From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: daniel.vetter@ffwll.ch,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: simplify ppgtt setup
Date: Wed, 11 Apr 2012 11:55:46 +0200 [thread overview]
Message-ID: <20120411095546.GC4296@phenom.ffwll.local> (raw)
In-Reply-To: <1334072020_347922@CP5-2952>
On Tue, Apr 10, 2012 at 04:33:38PM +0100, Chris Wilson wrote:
> On Tue, 10 Apr 2012 17:29:17 +0200, daniel.vetter@ffwll.ch wrote:
> > From: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > We don't need the pt_addr for the !dmar case, so drop the else and
> > move the if (dmar) condition out of the loop.
> >
> > v2: Fixup whitespace damage noticed by Chris Wilson.
> >
> > v3: Collapse the two identical if blocks. Chris Wilson makes me look
> > like a moron right now ...
> >
> > Noticed-by: Konstantin Belousov <kostikbel@gmail.com>
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Reviewed-by: Chris Wilson <chris@chris-wislon.co.uk>
Queued for -next, thanks for the review.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-04-11 9:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 14:25 [PATCH] drm/i915: simplify ppgtt setup Daniel Vetter
2012-04-10 14:35 ` Chris Wilson
2012-04-10 15:04 ` Daniel Vetter
2012-04-10 15:10 ` Chris Wilson
2012-04-10 15:29 ` daniel.vetter
2012-04-10 15:33 ` Chris Wilson
2012-04-11 9:55 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411095546.GC4296@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.