* [PATCH for-3.5] cgroup: remove cgroup_subsys->populate()
@ 2012-04-10 17:16 Tejun Heo
[not found] ` <20120410171636.GB21311-RcKxWJ4Cfj1J2suj2OqeGauc2jM2gXBXkQQo+JxHRPFibQn6LdNjmg@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2012-04-10 17:16 UTC (permalink / raw)
To: Li Zefan, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
cgroups-u79uwXL29TY76Z2rM5mHXA
With memcg converted, cgroup_subsys->populate() doesn't have any user
left. Remove it.
Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
Li, can you please ack this? Thanks.
include/linux/cgroup.h | 1 -
kernel/cgroup.c | 3 ---
2 files changed, 4 deletions(-)
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index 565c803..d3f5fba 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -472,7 +472,6 @@ struct cgroup_subsys {
void (*fork)(struct task_struct *task);
void (*exit)(struct cgroup *cgrp, struct cgroup *old_cgrp,
struct task_struct *task);
- int (*populate)(struct cgroup_subsys *ss, struct cgroup *cgrp);
void (*post_clone)(struct cgroup *cgrp);
void (*bind)(struct cgroup *root);
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 2905977..b2f203f 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -3842,9 +3842,6 @@ static int cgroup_populate_dir(struct cgroup *cgrp)
for_each_subsys(cgrp->root, ss) {
struct cftype_set *set;
- if (ss->populate && (err = ss->populate(ss, cgrp)) < 0)
- return err;
-
list_for_each_entry(set, &ss->cftsets, node)
cgroup_addrm_files(cgrp, ss, set->cfts, true);
}
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <20120410171636.GB21311-RcKxWJ4Cfj1J2suj2OqeGauc2jM2gXBXkQQo+JxHRPFibQn6LdNjmg@public.gmane.org>]
* Re: [PATCH for-3.5] cgroup: remove cgroup_subsys->populate() [not found] ` <20120410171636.GB21311-RcKxWJ4Cfj1J2suj2OqeGauc2jM2gXBXkQQo+JxHRPFibQn6LdNjmg@public.gmane.org> @ 2012-04-11 0:40 ` Li Zefan [not found] ` <4F84D2FB.4050001-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Li Zefan @ 2012-04-11 0:40 UTC (permalink / raw) To: Tejun Heo Cc: cgroups-u79uwXL29TY76Z2rM5mHXA, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA Tejun Heo wrote: > With memcg converted, cgroup_subsys->populate() doesn't have any user > left. Remove it. > > Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > --- > Li, can you please ack this? Thanks. You forgot to update Documentation/cgroups/cgroups.txt. ;) And with that: Acked-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> > > include/linux/cgroup.h | 1 - > kernel/cgroup.c | 3 --- > 2 files changed, 4 deletions(-) > > diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h > index 565c803..d3f5fba 100644 > --- a/include/linux/cgroup.h > +++ b/include/linux/cgroup.h > @@ -472,7 +472,6 @@ struct cgroup_subsys { > void (*fork)(struct task_struct *task); > void (*exit)(struct cgroup *cgrp, struct cgroup *old_cgrp, > struct task_struct *task); > - int (*populate)(struct cgroup_subsys *ss, struct cgroup *cgrp); > void (*post_clone)(struct cgroup *cgrp); > void (*bind)(struct cgroup *root); > > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > index 2905977..b2f203f 100644 > --- a/kernel/cgroup.c > +++ b/kernel/cgroup.c > @@ -3842,9 +3842,6 @@ static int cgroup_populate_dir(struct cgroup *cgrp) > for_each_subsys(cgrp->root, ss) { > struct cftype_set *set; > > - if (ss->populate && (err = ss->populate(ss, cgrp)) < 0) > - return err; > - > list_for_each_entry(set, &ss->cftsets, node) > cgroup_addrm_files(cgrp, ss, set->cfts, true); > } ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <4F84D2FB.4050001-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH for-3.5] cgroup: remove cgroup_subsys->populate() [not found] ` <4F84D2FB.4050001-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> @ 2012-04-11 16:16 ` Tejun Heo 2012-04-11 16:16 ` Tejun Heo 1 sibling, 0 replies; 5+ messages in thread From: Tejun Heo @ 2012-04-11 16:16 UTC (permalink / raw) To: Li Zefan Cc: cgroups-u79uwXL29TY76Z2rM5mHXA, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA On Wed, Apr 11, 2012 at 08:40:27AM +0800, Li Zefan wrote: > Tejun Heo wrote: > > > With memcg converted, cgroup_subsys->populate() doesn't have any user > > left. Remove it. > > > > Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > > --- > > Li, can you please ack this? Thanks. > > > You forgot to update Documentation/cgroups/cgroups.txt. ;) Yeah, the doc is getting out of sync (->cftypes update is missing too). I'll get to it later. > And with that: > > Acked-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Thanks. -- tejun ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH for-3.5] cgroup: remove cgroup_subsys->populate() [not found] ` <4F84D2FB.4050001-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> 2012-04-11 16:16 ` Tejun Heo @ 2012-04-11 16:16 ` Tejun Heo 1 sibling, 0 replies; 5+ messages in thread From: Tejun Heo @ 2012-04-11 16:16 UTC (permalink / raw) To: Li Zefan Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, cgroups-u79uwXL29TY76Z2rM5mHXA On Wed, Apr 11, 2012 at 08:40:27AM +0800, Li Zefan wrote: > Tejun Heo wrote: > > > With memcg converted, cgroup_subsys->populate() doesn't have any user > > left. Remove it. > > > > Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > > --- > > Li, can you please ack this? Thanks. > > > You forgot to update Documentation/cgroups/cgroups.txt. ;) Yeah, the doc is getting out of sync (->cftypes update is missing too). I'll get to it later. > And with that: > > Acked-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Thanks. -- tejun ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH for-3.5] cgroup: remove cgroup_subsys->populate() @ 2012-04-10 17:16 Tejun Heo 0 siblings, 0 replies; 5+ messages in thread From: Tejun Heo @ 2012-04-10 17:16 UTC (permalink / raw) To: Li Zefan, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, cgroups-u79uwXL29TY76Z2rM5mHXA With memcg converted, cgroup_subsys->populate() doesn't have any user left. Remove it. Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> --- Li, can you please ack this? Thanks. include/linux/cgroup.h | 1 - kernel/cgroup.c | 3 --- 2 files changed, 4 deletions(-) diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index 565c803..d3f5fba 100644 --- a/include/linux/cgroup.h +++ b/include/linux/cgroup.h @@ -472,7 +472,6 @@ struct cgroup_subsys { void (*fork)(struct task_struct *task); void (*exit)(struct cgroup *cgrp, struct cgroup *old_cgrp, struct task_struct *task); - int (*populate)(struct cgroup_subsys *ss, struct cgroup *cgrp); void (*post_clone)(struct cgroup *cgrp); void (*bind)(struct cgroup *root); diff --git a/kernel/cgroup.c b/kernel/cgroup.c index 2905977..b2f203f 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c @@ -3842,9 +3842,6 @@ static int cgroup_populate_dir(struct cgroup *cgrp) for_each_subsys(cgrp->root, ss) { struct cftype_set *set; - if (ss->populate && (err = ss->populate(ss, cgrp)) < 0) - return err; - list_for_each_entry(set, &ss->cftsets, node) cgroup_addrm_files(cgrp, ss, set->cfts, true); } ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-04-11 16:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-10 17:16 [PATCH for-3.5] cgroup: remove cgroup_subsys->populate() Tejun Heo
[not found] ` <20120410171636.GB21311-RcKxWJ4Cfj1J2suj2OqeGauc2jM2gXBXkQQo+JxHRPFibQn6LdNjmg@public.gmane.org>
2012-04-11 0:40 ` Li Zefan
[not found] ` <4F84D2FB.4050001-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2012-04-11 16:16 ` Tejun Heo
2012-04-11 16:16 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2012-04-10 17:16 Tejun Heo
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.