All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Picco <bpicco@meloft.net>
To: Rik van Riel <riel@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH -mm] remove swap token code
Date: Thu, 12 Apr 2012 11:06:12 -0400	[thread overview]
Message-ID: <20120412150612.GA12549@gw1> (raw)
In-Reply-To: <20120409113201.6dff571a@annuminas.surriel.com>

Rik van Riel wrote:	[Mon Apr 09 2012, 11:32:01AM EDT]
> The swap token code no longer fits in with the current VM model.
> It does not play well with cgroups or the better NUMA placement
> code in development, since we have only one swap token globally.
> 
> It also has the potential to mess with scalability of the system,
> by increasing the number of non-reclaimable pages on the active
> and inactive anon LRU lists.
> 
> Last but not least, the swap token code has been broken for a
> year without complaints.  This suggests we no longer have much
> use for it.
> 
> The days of sub-1G memory systems with heavy use of swap are
> over. If we ever need thrashing reducing code in the future,
> we will have to implement something that does scale.
> 
> Signed-off-by: Rik van Riel <riel@redhat.com>

Acked-by: Bob Picco <bpicco@meloft.net>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Bob Picco <bpicco@meloft.net>
To: Rik van Riel <riel@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH -mm] remove swap token code
Date: Thu, 12 Apr 2012 11:06:12 -0400	[thread overview]
Message-ID: <20120412150612.GA12549@gw1> (raw)
In-Reply-To: <20120409113201.6dff571a@annuminas.surriel.com>

Rik van Riel wrote:	[Mon Apr 09 2012, 11:32:01AM EDT]
> The swap token code no longer fits in with the current VM model.
> It does not play well with cgroups or the better NUMA placement
> code in development, since we have only one swap token globally.
> 
> It also has the potential to mess with scalability of the system,
> by increasing the number of non-reclaimable pages on the active
> and inactive anon LRU lists.
> 
> Last but not least, the swap token code has been broken for a
> year without complaints.  This suggests we no longer have much
> use for it.
> 
> The days of sub-1G memory systems with heavy use of swap are
> over. If we ever need thrashing reducing code in the future,
> we will have to implement something that does scale.
> 
> Signed-off-by: Rik van Riel <riel@redhat.com>

Acked-by: Bob Picco <bpicco@meloft.net>


  parent reply	other threads:[~2012-04-12 15:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-09 15:32 [PATCH -mm] remove swap token code Rik van Riel
2012-04-09 15:32 ` Rik van Riel
2012-04-11  1:48 ` Johannes Weiner
2012-04-11  1:48   ` Johannes Weiner
2012-04-11 18:10   ` KOSAKI Motohiro
2012-04-11 18:10     ` KOSAKI Motohiro
2012-04-12 15:06 ` Bob Picco [this message]
2012-04-12 15:06   ` Bob Picco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120412150612.GA12549@gw1 \
    --to=bpicco@meloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.