From: Oleg Nesterov <oleg@redhat.com>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Markus Trippelsdorf <markus@trippelsdorf.de>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 1/2] mm: set task exit code before complete_vfork_done()
Date: Fri, 13 Apr 2012 01:54:46 +0200 [thread overview]
Message-ID: <20120412235446.GA4815@redhat.com> (raw)
In-Reply-To: <20120412080948.26401.23572.stgit@zurg>
On 04/12, Konstantin Khlebnikov wrote:
>
> kthread_stop() uses task->vfork_done for synchronization. The exiting kthread
> shouldn't do complete_vfork_done() until it sets ->exit_code.
>
> fix for mm-correctly-synchronize-rss-counters-at-exit-exec.patch
Yes, this should fix the problem with kthread_stop()...
Damn, Konstantin I have to admit, I'll try to find another technical
reason against mm-correctly-synchronize-rss-counters-at-exit-exec.patch
even with this fix ;)
Most probably I am wrong, but it looks overcomplicated. Somehow I
dislike irrationally the fact you moved mm_release() from exit_mm().
But, once again, it is not that I see the better solution.
2/2 looks fine at first glance... and afaics it is "off-topic".
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Markus Trippelsdorf <markus@trippelsdorf.de>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 1/2] mm: set task exit code before complete_vfork_done()
Date: Fri, 13 Apr 2012 01:54:46 +0200 [thread overview]
Message-ID: <20120412235446.GA4815@redhat.com> (raw)
In-Reply-To: <20120412080948.26401.23572.stgit@zurg>
On 04/12, Konstantin Khlebnikov wrote:
>
> kthread_stop() uses task->vfork_done for synchronization. The exiting kthread
> shouldn't do complete_vfork_done() until it sets ->exit_code.
>
> fix for mm-correctly-synchronize-rss-counters-at-exit-exec.patch
Yes, this should fix the problem with kthread_stop()...
Damn, Konstantin I have to admit, I'll try to find another technical
reason against mm-correctly-synchronize-rss-counters-at-exit-exec.patch
even with this fix ;)
Most probably I am wrong, but it looks overcomplicated. Somehow I
dislike irrationally the fact you moved mm_release() from exit_mm().
But, once again, it is not that I see the better solution.
2/2 looks fine at first glance... and afaics it is "off-topic".
Oleg.
next prev parent reply other threads:[~2012-04-12 23:55 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 20:03 [PATCH] mm: sync rss-counters at the end of exit_mm() Konstantin Khlebnikov
2012-04-09 20:03 ` Konstantin Khlebnikov
2012-04-09 21:04 ` KOSAKI Motohiro
2012-04-09 21:04 ` KOSAKI Motohiro
2012-04-09 22:03 ` Hugh Dickins
2012-04-10 0:33 ` KAMEZAWA Hiroyuki
2012-04-10 0:33 ` KAMEZAWA Hiroyuki
2012-04-10 6:34 ` Konstantin Khlebnikov
2012-04-10 6:34 ` Konstantin Khlebnikov
2012-04-10 16:04 ` Markus Trippelsdorf
2012-04-10 16:04 ` Markus Trippelsdorf
2012-04-10 0:35 ` KAMEZAWA Hiroyuki
2012-04-10 0:35 ` KAMEZAWA Hiroyuki
2012-04-10 5:43 ` Konstantin Khlebnikov
2012-04-10 5:43 ` Konstantin Khlebnikov
2012-04-10 17:07 ` [PATCH v2] mm: correctly synchronize rss-counters at exit/exec Konstantin Khlebnikov
2012-04-10 17:07 ` Konstantin Khlebnikov
2012-04-10 18:43 ` Andrew Morton
2012-04-10 18:43 ` Andrew Morton
2012-04-10 19:52 ` Konstantin Khlebnikov
2012-04-10 19:52 ` Konstantin Khlebnikov
2012-04-10 19:10 ` Oleg Nesterov
2012-04-10 19:10 ` Oleg Nesterov
2012-04-10 20:09 ` Konstantin Khlebnikov
2012-04-10 20:09 ` Konstantin Khlebnikov
2012-04-12 8:09 ` [PATCH 1/2] mm: set task exit code before complete_vfork_done() Konstantin Khlebnikov
2012-04-12 8:09 ` Konstantin Khlebnikov
2012-04-12 23:35 ` Andrew Morton
2012-04-12 23:35 ` Andrew Morton
2012-04-12 23:54 ` Oleg Nesterov [this message]
2012-04-12 23:54 ` Oleg Nesterov
2012-04-20 17:59 ` Oleg Nesterov
2012-04-20 17:59 ` Oleg Nesterov
2012-04-20 19:23 ` Konstantin Khlebnikov
2012-04-20 19:23 ` Konstantin Khlebnikov
2012-04-20 20:41 ` Oleg Nesterov
2012-04-20 20:41 ` Oleg Nesterov
2012-04-25 20:01 ` Andrew Morton
2012-04-25 20:01 ` Andrew Morton
2012-04-12 8:09 ` [PATCH 2/2] mm: call complete_vfork_done() after clearing child_tid and flushing rss-counters Konstantin Khlebnikov
2012-04-12 8:09 ` Konstantin Khlebnikov
2012-04-12 23:39 ` Andrew Morton
2012-04-12 23:39 ` Andrew Morton
2012-04-13 6:43 ` Konstantin Khlebnikov
2012-04-13 6:43 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120412235446.GA4815@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=markus@trippelsdorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.