From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Stanislav Kinsbursky <skinsbursky@parallels.com>
Cc: Chris Metcalf <cmetcalf@tilera.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] c/r: ipc: uninitialized variable in compat_do_msg_fill()
Date: Fri, 13 Apr 2012 13:37:51 +0000 [thread overview]
Message-ID: <20120413133751.GA26645@elgon.mountain> (raw)
We never initialize "msgp". It's unfortunate that GCC doesn't warn
about this.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/ipc/compat.c b/ipc/compat.c
index 6da376b..0c2ebd0 100644
--- a/ipc/compat.c
+++ b/ipc/compat.c
@@ -363,7 +363,7 @@ static long compat_do_msg_steal(void __user *dest, struct msg_msg *msg, size_t b
long compat_do_msg_fill(void __user *dest, struct msg_msg *msg, size_t bufsz)
{
- struct compat_msgbuf __user *msgp;
+ struct compat_msgbuf __user *msgp = dest;
size_t msgsz;
if (put_user(msg->m_type, &msgp->mtype))
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Stanislav Kinsbursky <skinsbursky@parallels.com>
Cc: Chris Metcalf <cmetcalf@tilera.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] c/r: ipc: uninitialized variable in compat_do_msg_fill()
Date: Fri, 13 Apr 2012 16:37:51 +0300 [thread overview]
Message-ID: <20120413133751.GA26645@elgon.mountain> (raw)
We never initialize "msgp". It's unfortunate that GCC doesn't warn
about this.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/ipc/compat.c b/ipc/compat.c
index 6da376b..0c2ebd0 100644
--- a/ipc/compat.c
+++ b/ipc/compat.c
@@ -363,7 +363,7 @@ static long compat_do_msg_steal(void __user *dest, struct msg_msg *msg, size_t b
long compat_do_msg_fill(void __user *dest, struct msg_msg *msg, size_t bufsz)
{
- struct compat_msgbuf __user *msgp;
+ struct compat_msgbuf __user *msgp = dest;
size_t msgsz;
if (put_user(msg->m_type, &msgp->mtype))
next reply other threads:[~2012-04-13 13:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 13:37 Dan Carpenter [this message]
2012-04-13 13:37 ` [patch] c/r: ipc: uninitialized variable in compat_do_msg_fill() Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120413133751.GA26645@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=cmetcalf@tilera.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skinsbursky@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.