From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
ctalbott-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
rni-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH 7/8] blkcg: implement per-queue policy activation
Date: Fri, 13 Apr 2012 11:17:05 -0700 [thread overview]
Message-ID: <20120413181705.GD12233@google.com> (raw)
In-Reply-To: <20120413181257.GG26383-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Hello,
On Fri, Apr 13, 2012 at 02:12:57PM -0400, Vivek Goyal wrote:
> On Thu, Apr 12, 2012 at 04:29:39PM -0700, Tejun Heo wrote:
>
> [..]
> > diff --git a/block/elevator.c b/block/elevator.c
> > index be3ab6d..6a55d41 100644
> > --- a/block/elevator.c
> > +++ b/block/elevator.c
> > @@ -896,8 +896,6 @@ static int elevator_switch(struct request_queue *q, struct elevator_type *new_e)
> > ioc_clear_queue(q);
> > spin_unlock_irq(q->queue_lock);
> >
> > - blkg_destroy_all(q, false);
> > -
>
> So now groups don't reclaimed until either cgroup is deleted or queue
> exits. So if BLK_DEV_THROTTLE=n and cfq is switched out, blkg created
> by CFQ policy will not be reclaimed (despite the fact nobody is using
> them).
It's not difficult to change. We can just trigger reclaim if no
policy is enabled for the queue. Hmmm... yeah, that's gonna be like
five line change. I'll add it.
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: axboe@kernel.dk, ctalbott@google.com, rni@google.com,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
containers@lists.linux-foundation.org
Subject: Re: [PATCH 7/8] blkcg: implement per-queue policy activation
Date: Fri, 13 Apr 2012 11:17:05 -0700 [thread overview]
Message-ID: <20120413181705.GD12233@google.com> (raw)
In-Reply-To: <20120413181257.GG26383@redhat.com>
Hello,
On Fri, Apr 13, 2012 at 02:12:57PM -0400, Vivek Goyal wrote:
> On Thu, Apr 12, 2012 at 04:29:39PM -0700, Tejun Heo wrote:
>
> [..]
> > diff --git a/block/elevator.c b/block/elevator.c
> > index be3ab6d..6a55d41 100644
> > --- a/block/elevator.c
> > +++ b/block/elevator.c
> > @@ -896,8 +896,6 @@ static int elevator_switch(struct request_queue *q, struct elevator_type *new_e)
> > ioc_clear_queue(q);
> > spin_unlock_irq(q->queue_lock);
> >
> > - blkg_destroy_all(q, false);
> > -
>
> So now groups don't reclaimed until either cgroup is deleted or queue
> exits. So if BLK_DEV_THROTTLE=n and cfq is switched out, blkg created
> by CFQ policy will not be reclaimed (despite the fact nobody is using
> them).
It's not difficult to change. We can just trigger reclaim if no
policy is enabled for the queue. Hmmm... yeah, that's gonna be like
five line change. I'll add it.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-04-13 18:17 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 23:29 [PATCHSET] block: per-queue policy activation Tejun Heo
2012-04-12 23:29 ` Tejun Heo
[not found] ` <1334273380-30233-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-04-12 23:29 ` [PATCH 1/8] blkcg: kill blkio_list and replace blkio_list_lock with a mutex Tejun Heo
2012-04-12 23:29 ` Tejun Heo
[not found] ` <1334273380-30233-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-04-13 13:32 ` Vivek Goyal
2012-04-13 13:32 ` Vivek Goyal
[not found] ` <20120413133226.GB26383-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-13 16:55 ` Tejun Heo
2012-04-13 16:55 ` Tejun Heo
2012-04-13 16:55 ` Tejun Heo
2012-04-13 13:32 ` Vivek Goyal
2012-04-12 23:29 ` [PATCH 2/8] blkcg: use @pol instead of @plid in update_root_blkg_pd() and blkcg_print_blkgs() Tejun Heo
2012-04-12 23:29 ` Tejun Heo
2012-04-12 23:29 ` [PATCH 3/8] blkcg: remove static policy ID enums Tejun Heo
2012-04-12 23:29 ` Tejun Heo
2012-04-12 23:29 ` [PATCH 4/8] blkcg: make blkg_conf_prep() take @pol and return with queue lock held Tejun Heo
2012-04-12 23:29 ` Tejun Heo
2012-04-12 23:29 ` [PATCH 5/8] blkcg: make sure blkg_lookup() returns %NULL if @q is bypassing Tejun Heo
2012-04-12 23:29 ` Tejun Heo
[not found] ` <1334273380-30233-6-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-04-13 16:00 ` Vivek Goyal
2012-04-13 16:00 ` Vivek Goyal
[not found] ` <20120413160053.GE26383-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-13 17:03 ` Tejun Heo
2012-04-13 17:03 ` Tejun Heo
[not found] ` <20120413170334.GB12233-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-04-13 17:23 ` Vivek Goyal
2012-04-13 17:23 ` Vivek Goyal
2012-04-13 17:23 ` Vivek Goyal
[not found] ` <20120413172336.GF26383-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-13 17:28 ` Tejun Heo
2012-04-13 17:28 ` Tejun Heo
2012-04-13 17:28 ` Tejun Heo
2012-04-16 22:41 ` Paul E. McKenney
2012-04-16 22:41 ` Paul E. McKenney
2012-04-12 23:29 ` [PATCH 6/8] blkcg: add request_queue->root_blkg Tejun Heo
2012-04-12 23:29 ` Tejun Heo
2012-04-12 23:29 ` Tejun Heo
2012-04-12 23:29 ` [PATCH 7/8] blkcg: implement per-queue policy activation Tejun Heo
2012-04-12 23:29 ` Tejun Heo
[not found] ` <1334273380-30233-8-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-04-13 15:21 ` Vivek Goyal
2012-04-13 15:21 ` Vivek Goyal
[not found] ` <20120413152122.GC26383-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-13 15:23 ` Vivek Goyal
2012-04-13 15:23 ` Vivek Goyal
2012-04-13 15:23 ` Vivek Goyal
2012-04-13 15:21 ` Vivek Goyal
2012-04-13 18:12 ` Vivek Goyal
2012-04-13 18:12 ` Vivek Goyal
[not found] ` <20120413181257.GG26383-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-13 18:17 ` Tejun Heo
2012-04-13 18:17 ` Tejun Heo [this message]
2012-04-13 18:17 ` Tejun Heo
2012-04-13 18:12 ` Vivek Goyal
2012-04-12 23:29 ` [PATCH 8/8] blkcg: drop stuff unused after per-queue policy activation update Tejun Heo
2012-04-12 23:29 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120413181705.GD12233@google.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=ctalbott-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rni-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.