From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Thomas Rast <trast@student.ethz.ch>, Jeff King <peff@peff.net>
Subject: Re: [PATCH] tests: add tests for the bash prompt functions in the completion script
Date: Mon, 16 Apr 2012 12:20:14 +0200 [thread overview]
Message-ID: <20120416102014.GF2900@goldbirke> (raw)
In-Reply-To: <CAMP44s0vkH9iE4MoV7HgGwOXna40pAL=h6be13qdreexp5_14w@mail.gmail.com>
On Mon, Apr 16, 2012 at 01:04:41PM +0300, Felipe Contreras wrote:
> >> specially since there's the plan of splitting the prompt stuff to a
> >> separate file.
> >
> > Oh, I was not aware of such a plan. What would be the benefits of
> > such a move, why is it necessary? Where would you split it up? In
> > particular, what would happen with __gitdir(), which is used in many
> > completion functions and in __git_ps1() as well?
>
> I guess __gitdir() would be duplicated, I don't think that has been discussed.
>
> http://thread.gmane.org/gmane.comp.version-control.git/194188
>
> Basically splitting helps for systems that use bash-completion, and
> also helps for zsh users who don't want the bash completion, but still
> want __git_ps1(). I split the file myself for this reason.
Thanks for the pointer, those are valid reasons. I'll wait a day or
two for feedback, then resubmit as a different test script.
Gábor
next prev parent reply other threads:[~2012-04-16 10:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-15 20:31 [PATCH] tests: add tests for the bash prompt functions in the completion script SZEDER Gábor
2012-04-15 20:56 ` Felipe Contreras
2012-04-16 9:49 ` SZEDER Gábor
2012-04-16 10:04 ` Felipe Contreras
2012-04-16 10:20 ` SZEDER Gábor [this message]
2012-04-16 16:01 ` Jonathan Nieder
2012-04-16 22:09 ` [PATCH v2 1/2] tests: move code to run completion tests under bash into a helper library SZEDER Gábor
2012-04-16 22:09 ` [PATCH v2 2/2] tests: add tests for the bash prompt functions in the completion script SZEDER Gábor
2012-04-16 23:50 ` Jonathan Nieder
2012-04-17 0:33 ` SZEDER Gábor
2012-04-16 23:49 ` [PATCH v2 1/2] tests: move code to run completion tests under bash into a helper library Jonathan Nieder
2012-04-17 0:42 ` SZEDER Gábor
2012-04-17 7:20 ` Johannes Sixt
2012-04-17 7:37 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120416102014.GF2900@goldbirke \
--to=szeder@ira.uka.de \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.