All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: git@vger.kernel.org,
	Felipe Contreras <felipe.contreras@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	Thomas Rast <trast@student.ethz.ch>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v2 1/2] tests: move code to run completion tests under bash into a helper library
Date: Mon, 16 Apr 2012 18:49:24 -0500	[thread overview]
Message-ID: <20120416234923.GZ12613@burratino> (raw)
In-Reply-To: <1334614176-2963-1-git-send-email-szeder@ira.uka.de>

SZEDER Gábor wrote:

> --- a/t/t9902-completion.sh
> +++ b/t/t9902-completion.sh
> @@ -3,21 +3,9 @@
>  # Copyright (c) 2012 Felipe Contreras
>  #
>  
> -if test -n "$BASH" && test -z "$POSIXLY_CORRECT"; then
> -	# we are in full-on bash mode
> -	true
> -elif type bash >/dev/null 2>&1; then
> -	# execute in full-on bash mode
> -	unset POSIXLY_CORRECT
> -	exec bash "$0" "$@"
> -else
> -	echo '1..0 #SKIP skipping bash completion tests; bash not available'
> -	exit 0
> -fi
> -
>  test_description='test bash completion'
>  
> -. ./test-lib.sh
> +. ./lib-completion.sh

If I understand correctly, this sources lib-completion immediately
instead of following the usual pattern of

	. ./test-lib.sh
	. "$TEST_DIRECTORY/lib-completion.sh"

to get the self-execing over with ASAP.  "$0" always refers to the
original shell script and not the file being sourced so this should be
safe.  Looks good.

  parent reply	other threads:[~2012-04-16 23:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-15 20:31 [PATCH] tests: add tests for the bash prompt functions in the completion script SZEDER Gábor
2012-04-15 20:56 ` Felipe Contreras
2012-04-16  9:49   ` SZEDER Gábor
2012-04-16 10:04     ` Felipe Contreras
2012-04-16 10:20       ` SZEDER Gábor
2012-04-16 16:01     ` Jonathan Nieder
2012-04-16 22:09       ` [PATCH v2 1/2] tests: move code to run completion tests under bash into a helper library SZEDER Gábor
2012-04-16 22:09         ` [PATCH v2 2/2] tests: add tests for the bash prompt functions in the completion script SZEDER Gábor
2012-04-16 23:50           ` Jonathan Nieder
2012-04-17  0:33             ` SZEDER Gábor
2012-04-16 23:49         ` Jonathan Nieder [this message]
2012-04-17  0:42           ` [PATCH v2 1/2] tests: move code to run completion tests under bash into a helper library SZEDER Gábor
2012-04-17  7:20         ` Johannes Sixt
2012-04-17  7:37           ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120416234923.GZ12613@burratino \
    --to=jrnieder@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=szeder@ira.uka.de \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.