From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jan Schmidt <list.btrfs@jan-o-sch.net>
Cc: Chris Mason <chris.mason@oracle.com>,
Jeff Mahoney <jeffm@suse.com>,
linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] Btrfs: double unlock bug in error handling
Date: Wed, 18 Apr 2012 12:06:47 +0000 [thread overview]
Message-ID: <20120418120647.GA27101@mwanda> (raw)
In-Reply-To: <4F8EA5AA.2080202@jan-o-sch.net>
On Wed, Apr 18, 2012 at 01:29:46PM +0200, Jan Schmidt wrote:
> On 18.04.2012 08:59, Dan Carpenter wrote:
> I think the correct way to fix this is:
>
Yeah. I considered both ways, but I chose the one which makes the
tools happy. Which is the wrong choice, because taking a pointless
lock is wrong even on the slow path and we should improve the tools.
I'll resend.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jan Schmidt <list.btrfs@jan-o-sch.net>
Cc: Chris Mason <chris.mason@oracle.com>,
Jeff Mahoney <jeffm@suse.com>,
linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] Btrfs: double unlock bug in error handling
Date: Wed, 18 Apr 2012 15:06:47 +0300 [thread overview]
Message-ID: <20120418120647.GA27101@mwanda> (raw)
In-Reply-To: <4F8EA5AA.2080202@jan-o-sch.net>
On Wed, Apr 18, 2012 at 01:29:46PM +0200, Jan Schmidt wrote:
> On 18.04.2012 08:59, Dan Carpenter wrote:
> I think the correct way to fix this is:
>
Yeah. I considered both ways, but I chose the one which makes the
tools happy. Which is the wrong choice, because taking a pointless
lock is wrong even on the slow path and we should improve the tools.
I'll resend.
regards,
dan carpenter
next prev parent reply other threads:[~2012-04-18 12:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 6:59 [patch 1/2] Btrfs: double unlock bug in error handling Dan Carpenter
2012-04-18 6:59 ` Dan Carpenter
2012-04-18 10:14 ` David Sterba
2012-04-18 10:14 ` David Sterba
2012-04-18 11:29 ` Jan Schmidt
2012-04-18 11:29 ` Jan Schmidt
2012-04-18 11:58 ` David Sterba
2012-04-18 11:58 ` David Sterba
2012-04-18 12:06 ` Dan Carpenter [this message]
2012-04-18 12:06 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418120647.GA27101@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chris.mason@oracle.com \
--cc=jeffm@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.btrfs@jan-o-sch.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.