All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Rodrigo Silva (MestreLion)" <linux@rodrigosilva.com>,
	git@vger.kernel.org, Ben Walton <bwalton@artsci.utoronto.ca>
Subject: Re: [PATCH 2/2] var doc: advertise current DEFAULT_PAGER and DEFAULT_EDITOR settings
Date: Wed, 18 Apr 2012 15:02:15 -0500	[thread overview]
Message-ID: <20120418200215.GB30558@burratino> (raw)
In-Reply-To: <7v1uo8k64l.fsf@alter.siamese.dyndns.org>

Hi Junio,

Junio C Hamano wrote:

> something like:
>
> 	... then the default chosen at compile time, which is usually 'vi'.
> ifdef::git-default-editor[]
> 	The build you are using chose '{git-default-editor}' as the default.
> endif::git-default-editor[]
>
> may be less confusing.

I was not sure if this text would interrupt the flow of reading
before, but I couldn't think of a good alternative so I didn't say
anything.  Sorry about that.  Now I've looked at the built result and
think the new text is good. :)

Thanks,
Jonathan

  reply	other threads:[~2012-04-18 20:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120330002543.2138.91961.reportbug@localhost6.localdomain6>
2012-03-30  0:55 ` [PATCH] Documentation: replace 'vi' for 'editor' to reflect build-time option Jonathan Nieder
2012-03-30  2:16   ` Junio C Hamano
2012-03-30 10:33     ` Bug#666250: " Rodrigo Silva
     [not found]     ` <20120330103326.272B040A067@cobalt.pobox.com>
2012-03-30 16:46       ` Junio C Hamano
2012-03-31  8:40     ` [PATCH 0/2] " Jonathan Nieder
2012-03-31  8:42       ` [PATCH 1/2] var doc: default editor and pager are configurable at build time Jonathan Nieder
     [not found]         ` <4f76de0e.2ac7b60a.54ce.ffffd85eSMTPIN_ADDED@mx.google.com>
2012-03-31 10:51           ` Jonathan Nieder
2012-03-31  8:44       ` [PATCH 2/2] var doc: advertise current DEFAULT_PAGER and DEFAULT_EDITOR settings Jonathan Nieder
2012-03-31 17:55         ` Junio C Hamano
2012-04-18 20:02           ` Jonathan Nieder [this message]
2012-03-31 20:29     ` [PATCH] Documentation: replace 'vi' for 'editor' to reflect build-time option Phil Hord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120418200215.GB30558@burratino \
    --to=jrnieder@gmail.com \
    --cc=bwalton@artsci.utoronto.ca \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=linux@rodrigosilva.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.