* [PATCH] STAGING: octeon-ethernet: fix build errors by including interrupt.h
@ 2012-04-09 18:29 Imre Kaloz
2012-04-09 21:33 ` David Daney
2012-04-18 23:46 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Imre Kaloz @ 2012-04-09 18:29 UTC (permalink / raw)
To: linux-mips; +Cc: ralf, david.daney
This patch fixes the following build failures:
drivers/staging/octeon/ethernet.c: In function 'cvm_oct_cleanup_module':
drivers/staging/octeon/ethernet.c:799:2: error: implicit declaration of function 'free_irq'
drivers/staging/octeon/ethernet-rx.c: In function 'cvm_oct_no_more_work':
drivers/staging/octeon/ethernet-rx.c:119:3: error: implicit declaration of function 'enable_irq'
drivers/staging/octeon/ethernet-rx.c: In function 'cvm_oct_do_interrupt':
drivers/staging/octeon/ethernet-rx.c:136:2: error: implicit declaration of function 'disable_irq_nosync'
drivers/staging/octeon/ethernet-rx.c: In function 'cvm_oct_rx_initialize':
drivers/staging/octeon/ethernet-rx.c:532:2: error: implicit declaration of function 'request_irq'
drivers/staging/octeon/ethernet-tx.c: In function 'cvm_oct_tx_initialize':
drivers/staging/octeon/ethernet-tx.c:712:2: error: implicit declaration of function 'request_irq'
drivers/staging/octeon/ethernet-tx.c: In function 'cvm_oct_tx_shutdown':
drivers/staging/octeon/ethernet-tx.c:723:2: error: implicit declaration of function 'free_irq'
Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
---
drivers/staging/octeon/ethernet-rx.c | 1 +
drivers/staging/octeon/ethernet-tx.c | 1 +
drivers/staging/octeon/ethernet.c | 1 +
3 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c
index 400df8c..d91751f 100644
--- a/drivers/staging/octeon/ethernet-rx.c
+++ b/drivers/staging/octeon/ethernet-rx.c
@@ -36,6 +36,7 @@
#include <linux/prefetch.h>
#include <linux/ratelimit.h>
#include <linux/smp.h>
+#include <linux/interrupt.h>
#include <net/dst.h>
#ifdef CONFIG_XFRM
#include <linux/xfrm.h>
diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c
index 56d74dc..91a97b3 100644
--- a/drivers/staging/octeon/ethernet-tx.c
+++ b/drivers/staging/octeon/ethernet-tx.c
@@ -32,6 +32,7 @@
#include <linux/ip.h>
#include <linux/ratelimit.h>
#include <linux/string.h>
+#include <linux/interrupt.h>
#include <net/dst.h>
#ifdef CONFIG_XFRM
#include <linux/xfrm.h>
diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index 9112cd8..60cba81 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -31,6 +31,7 @@
#include <linux/etherdevice.h>
#include <linux/phy.h>
#include <linux/slab.h>
+#include <linux/interrupt.h>
#include <net/dst.h>
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] STAGING: octeon-ethernet: fix build errors by including interrupt.h
2012-04-09 18:29 [PATCH] STAGING: octeon-ethernet: fix build errors by including interrupt.h Imre Kaloz
@ 2012-04-09 21:33 ` David Daney
2012-04-18 23:46 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: David Daney @ 2012-04-09 21:33 UTC (permalink / raw)
To: Imre Kaloz; +Cc: linux-mips, ralf
On 04/09/2012 11:29 AM, Imre Kaloz wrote:
> This patch fixes the following build failures:
>
> drivers/staging/octeon/ethernet.c: In function 'cvm_oct_cleanup_module':
> drivers/staging/octeon/ethernet.c:799:2: error: implicit declaration of function 'free_irq'
> drivers/staging/octeon/ethernet-rx.c: In function 'cvm_oct_no_more_work':
> drivers/staging/octeon/ethernet-rx.c:119:3: error: implicit declaration of function 'enable_irq'
> drivers/staging/octeon/ethernet-rx.c: In function 'cvm_oct_do_interrupt':
> drivers/staging/octeon/ethernet-rx.c:136:2: error: implicit declaration of function 'disable_irq_nosync'
> drivers/staging/octeon/ethernet-rx.c: In function 'cvm_oct_rx_initialize':
> drivers/staging/octeon/ethernet-rx.c:532:2: error: implicit declaration of function 'request_irq'
> drivers/staging/octeon/ethernet-tx.c: In function 'cvm_oct_tx_initialize':
> drivers/staging/octeon/ethernet-tx.c:712:2: error: implicit declaration of function 'request_irq'
> drivers/staging/octeon/ethernet-tx.c: In function 'cvm_oct_tx_shutdown':
> drivers/staging/octeon/ethernet-tx.c:723:2: error: implicit declaration of function 'free_irq'
>
If you select some of the IPSec options, linux/interrupt.h will be
included indirectly via net/xfrm.h. Without CONFIG_XFRM, you indeed get
these errors, so...
Acked-by: David Daney <david.daney@cavium.com>
I am not sure when Ralf would merge it, but since it is in
drivers/staging, it may be best to route it to Greg K-H. with the
corresponding stable annotations.
> Signed-off-by: Imre Kaloz<kaloz@openwrt.org>
> ---
> drivers/staging/octeon/ethernet-rx.c | 1 +
> drivers/staging/octeon/ethernet-tx.c | 1 +
> drivers/staging/octeon/ethernet.c | 1 +
> 3 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c
> index 400df8c..d91751f 100644
> --- a/drivers/staging/octeon/ethernet-rx.c
> +++ b/drivers/staging/octeon/ethernet-rx.c
> @@ -36,6 +36,7 @@
> #include<linux/prefetch.h>
> #include<linux/ratelimit.h>
> #include<linux/smp.h>
> +#include<linux/interrupt.h>
> #include<net/dst.h>
> #ifdef CONFIG_XFRM
> #include<linux/xfrm.h>
> diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c
> index 56d74dc..91a97b3 100644
> --- a/drivers/staging/octeon/ethernet-tx.c
> +++ b/drivers/staging/octeon/ethernet-tx.c
> @@ -32,6 +32,7 @@
> #include<linux/ip.h>
> #include<linux/ratelimit.h>
> #include<linux/string.h>
> +#include<linux/interrupt.h>
> #include<net/dst.h>
> #ifdef CONFIG_XFRM
> #include<linux/xfrm.h>
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index 9112cd8..60cba81 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -31,6 +31,7 @@
> #include<linux/etherdevice.h>
> #include<linux/phy.h>
> #include<linux/slab.h>
> +#include<linux/interrupt.h>
>
> #include<net/dst.h>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] STAGING: octeon-ethernet: fix build errors by including interrupt.h
2012-04-09 18:29 [PATCH] STAGING: octeon-ethernet: fix build errors by including interrupt.h Imre Kaloz
2012-04-09 21:33 ` David Daney
@ 2012-04-18 23:46 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2012-04-18 23:46 UTC (permalink / raw)
To: Imre Kaloz; +Cc: linux-mips, ralf, david.daney
On Mon, Apr 09, 2012 at 08:29:15PM +0200, Imre Kaloz wrote:
> This patch fixes the following build failures:
>
> drivers/staging/octeon/ethernet.c: In function 'cvm_oct_cleanup_module':
> drivers/staging/octeon/ethernet.c:799:2: error: implicit declaration of function 'free_irq'
> drivers/staging/octeon/ethernet-rx.c: In function 'cvm_oct_no_more_work':
> drivers/staging/octeon/ethernet-rx.c:119:3: error: implicit declaration of function 'enable_irq'
> drivers/staging/octeon/ethernet-rx.c: In function 'cvm_oct_do_interrupt':
> drivers/staging/octeon/ethernet-rx.c:136:2: error: implicit declaration of function 'disable_irq_nosync'
> drivers/staging/octeon/ethernet-rx.c: In function 'cvm_oct_rx_initialize':
> drivers/staging/octeon/ethernet-rx.c:532:2: error: implicit declaration of function 'request_irq'
> drivers/staging/octeon/ethernet-tx.c: In function 'cvm_oct_tx_initialize':
> drivers/staging/octeon/ethernet-tx.c:712:2: error: implicit declaration of function 'request_irq'
> drivers/staging/octeon/ethernet-tx.c: In function 'cvm_oct_tx_shutdown':
> drivers/staging/octeon/ethernet-tx.c:723:2: error: implicit declaration of function 'free_irq'
>
> Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
> Acked-by: David Daney <david.daney@cavium.com>
This patch is messed up and does not apply.
And is this needed for 3.4-final?
Please resend it after you fix up your email client.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-18 23:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-09 18:29 [PATCH] STAGING: octeon-ethernet: fix build errors by including interrupt.h Imre Kaloz
2012-04-09 21:33 ` David Daney
2012-04-18 23:46 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.