Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

[Tony Lindgren <tony@atomide.com>]

* Russell King - ARM Linux <linux@arm.linux.org.uk> [120420 15:13]:
> On Fri, Apr 20, 2012 at 09:43:07AM -0700, Tony Lindgren wrote:
> > * Russell King - ARM Linux <linux@arm.linux.org.uk> [120420 08:41]:
> > > --- a/drivers/dma/omap-dma.c
> > > +++ b/drivers/dma/omap-dma.c
> > > @@ -83,11 +84,11 @@ static void omap_dma_start_sg(struct omap_chan *c, struct omap_desc *d,
> > >  	struct omap_sg *sg = d->sg + idx;
> > >  
> > >  	if (d->dir == DMA_DEV_TO_MEM)
> > > -		omap_set_dma_dest_params(c->dma_ch, 0, OMAP_DMA_AMODE_POST_INC,
> > > -				sg->addr, 0, 0);
> > > +		omap_set_dma_dest_params(c->dma_ch, d->periph_port,
> > > +			OMAP_DMA_AMODE_POST_INC, sg->addr, 0, 0);
> > >  	else
> > > -		omap_set_dma_src_params(c->dma_ch, 0, OMAP_DMA_AMODE_POST_INC,
> > > -				sg->addr, 0, 0);
> > > +		omap_set_dma_src_params(c->dma_ch, d->periph_port,
> > > +			OMAP_DMA_AMODE_POST_INC, sg->addr, 0, 0);
> > >  
> > >  	omap_set_dma_transfer_params(c->dma_ch, d->es, sg->en, sg->fn,
> > >  		d->sync_mode, c->dma_sig, d->sync_type);
> > 
> > These are now wrong way around, should use OMAP_DMA_PORT_EMIFF here..
> 
> Right, sorry about that.
> 
> Okay, I'll combine all these patches into the original adding the
> OMAP DMA support tonight.  So, the new OMAP DMA driver now looks
> like this:

Thanks that works. Tried it on 700, n800, n900, 2430sdp, zoom3 and blaze:

Tested-by: Tony Lindgren <tony@atomide.com>