From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/9] um: Should hold tasklist_lock while traversing processes
Date: Mon, 23 Apr 2012 07:09:25 +0000 [thread overview]
Message-ID: <20120423070925.GG30752@lizard> (raw)
In-Reply-To: <20120423070641.GA27702@lizard>
Traversing the tasks requires holding tasklist_lock, otherwise it
is unsafe.
p.s. However, I'm not sure that calling os_kill_ptraced_process()
in the atomic context is correct. It seem to work, but please
take a closer look.
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
---
arch/um/kernel/reboot.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/um/kernel/reboot.c b/arch/um/kernel/reboot.c
index 4d93dff..66d754c 100644
--- a/arch/um/kernel/reboot.c
+++ b/arch/um/kernel/reboot.c
@@ -4,6 +4,7 @@
*/
#include "linux/sched.h"
+#include "linux/spinlock.h"
#include "linux/slab.h"
#include "kern_util.h"
#include "os.h"
@@ -22,6 +23,7 @@ static void kill_off_processes(void)
struct task_struct *p;
int pid;
+ read_lock(&tasklist_lock);
for_each_process(p) {
if (p->mm = NULL)
continue;
@@ -29,6 +31,7 @@ static void kill_off_processes(void)
pid = p->mm->context.id.u.pid;
os_kill_ptraced_process(pid, 1);
}
+ read_unlock(&tasklist_lock);
}
}
--
1.7.9.2
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Mike Frysinger <vapier@gentoo.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Richard Weinberger <richard@nod.at>,
Paul Mundt <lethal@linux-sh.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
John Stultz <john.stultz@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net,
linaro-kernel@lists.linaro.org, patches@linaro.org,
linux-mm@kvack.org
Subject: [PATCH 7/9] um: Should hold tasklist_lock while traversing processes
Date: Mon, 23 Apr 2012 00:09:25 -0700 [thread overview]
Message-ID: <20120423070925.GG30752@lizard> (raw)
In-Reply-To: <20120423070641.GA27702@lizard>
Traversing the tasks requires holding tasklist_lock, otherwise it
is unsafe.
p.s. However, I'm not sure that calling os_kill_ptraced_process()
in the atomic context is correct. It seem to work, but please
take a closer look.
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
---
arch/um/kernel/reboot.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/um/kernel/reboot.c b/arch/um/kernel/reboot.c
index 4d93dff..66d754c 100644
--- a/arch/um/kernel/reboot.c
+++ b/arch/um/kernel/reboot.c
@@ -4,6 +4,7 @@
*/
#include "linux/sched.h"
+#include "linux/spinlock.h"
#include "linux/slab.h"
#include "kern_util.h"
#include "os.h"
@@ -22,6 +23,7 @@ static void kill_off_processes(void)
struct task_struct *p;
int pid;
+ read_lock(&tasklist_lock);
for_each_process(p) {
if (p->mm == NULL)
continue;
@@ -29,6 +31,7 @@ static void kill_off_processes(void)
pid = p->mm->context.id.u.pid;
os_kill_ptraced_process(pid, 1);
}
+ read_unlock(&tasklist_lock);
}
}
--
1.7.9.2
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>
Cc: linaro-kernel@lists.linaro.org,
Mike Frysinger <vapier@gentoo.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
user-mode-linux-devel@lists.sourceforge.net,
linux-sh@vger.kernel.org, Richard Weinberger <richard@nod.at>,
patches@linaro.org, linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org, linux-mm@kvack.org,
Paul Mundt <lethal@linux-sh.org>,
John Stultz <john.stultz@linaro.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Russell King <linux@arm.linux.org.uk>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/9] um: Should hold tasklist_lock while traversing processes
Date: Mon, 23 Apr 2012 00:09:25 -0700 [thread overview]
Message-ID: <20120423070925.GG30752@lizard> (raw)
In-Reply-To: <20120423070641.GA27702@lizard>
Traversing the tasks requires holding tasklist_lock, otherwise it
is unsafe.
p.s. However, I'm not sure that calling os_kill_ptraced_process()
in the atomic context is correct. It seem to work, but please
take a closer look.
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
---
arch/um/kernel/reboot.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/um/kernel/reboot.c b/arch/um/kernel/reboot.c
index 4d93dff..66d754c 100644
--- a/arch/um/kernel/reboot.c
+++ b/arch/um/kernel/reboot.c
@@ -4,6 +4,7 @@
*/
#include "linux/sched.h"
+#include "linux/spinlock.h"
#include "linux/slab.h"
#include "kern_util.h"
#include "os.h"
@@ -22,6 +23,7 @@ static void kill_off_processes(void)
struct task_struct *p;
int pid;
+ read_lock(&tasklist_lock);
for_each_process(p) {
if (p->mm == NULL)
continue;
@@ -29,6 +31,7 @@ static void kill_off_processes(void)
pid = p->mm->context.id.u.pid;
os_kill_ptraced_process(pid, 1);
}
+ read_unlock(&tasklist_lock);
}
}
--
1.7.9.2
WARNING: multiple messages have this Message-ID (diff)
From: anton.vorontsov@linaro.org (Anton Vorontsov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/9] um: Should hold tasklist_lock while traversing processes
Date: Mon, 23 Apr 2012 00:09:25 -0700 [thread overview]
Message-ID: <20120423070925.GG30752@lizard> (raw)
In-Reply-To: <20120423070641.GA27702@lizard>
Traversing the tasks requires holding tasklist_lock, otherwise it
is unsafe.
p.s. However, I'm not sure that calling os_kill_ptraced_process()
in the atomic context is correct. It seem to work, but please
take a closer look.
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
---
arch/um/kernel/reboot.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/um/kernel/reboot.c b/arch/um/kernel/reboot.c
index 4d93dff..66d754c 100644
--- a/arch/um/kernel/reboot.c
+++ b/arch/um/kernel/reboot.c
@@ -4,6 +4,7 @@
*/
#include "linux/sched.h"
+#include "linux/spinlock.h"
#include "linux/slab.h"
#include "kern_util.h"
#include "os.h"
@@ -22,6 +23,7 @@ static void kill_off_processes(void)
struct task_struct *p;
int pid;
+ read_lock(&tasklist_lock);
for_each_process(p) {
if (p->mm == NULL)
continue;
@@ -29,6 +31,7 @@ static void kill_off_processes(void)
pid = p->mm->context.id.u.pid;
os_kill_ptraced_process(pid, 1);
}
+ read_unlock(&tasklist_lock);
}
}
--
1.7.9.2
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Mike Frysinger <vapier@gentoo.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Richard Weinberger <richard@nod.at>,
Paul Mundt <lethal@linux-sh.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
John Stultz <john.stultz@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net,
linaro-kernel@lists.linaro.org, patches@linaro.org,
linux-mm@kvack.org
Subject: [PATCH 7/9] um: Should hold tasklist_lock while traversing processes
Date: Mon, 23 Apr 2012 00:09:25 -0700 [thread overview]
Message-ID: <20120423070925.GG30752@lizard> (raw)
In-Reply-To: <20120423070641.GA27702@lizard>
Traversing the tasks requires holding tasklist_lock, otherwise it
is unsafe.
p.s. However, I'm not sure that calling os_kill_ptraced_process()
in the atomic context is correct. It seem to work, but please
take a closer look.
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
---
arch/um/kernel/reboot.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/um/kernel/reboot.c b/arch/um/kernel/reboot.c
index 4d93dff..66d754c 100644
--- a/arch/um/kernel/reboot.c
+++ b/arch/um/kernel/reboot.c
@@ -4,6 +4,7 @@
*/
#include "linux/sched.h"
+#include "linux/spinlock.h"
#include "linux/slab.h"
#include "kern_util.h"
#include "os.h"
@@ -22,6 +23,7 @@ static void kill_off_processes(void)
struct task_struct *p;
int pid;
+ read_lock(&tasklist_lock);
for_each_process(p) {
if (p->mm == NULL)
continue;
@@ -29,6 +31,7 @@ static void kill_off_processes(void)
pid = p->mm->context.id.u.pid;
os_kill_ptraced_process(pid, 1);
}
+ read_unlock(&tasklist_lock);
}
}
--
1.7.9.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-04-23 7:09 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 7:06 [PATCH v3 0/9] Fixes for common mistakes w/ for_each_process and task->mm Anton Vorontsov
2012-04-23 7:06 ` Anton Vorontsov
2012-04-23 7:06 ` Anton Vorontsov
2012-04-23 7:06 ` Anton Vorontsov
2012-04-23 7:06 ` Anton Vorontsov
2012-04-23 7:07 ` [PATCH 1/9] cpu: Introduce clear_tasks_mm_cpumask() helper Anton Vorontsov
2012-04-23 7:07 ` Anton Vorontsov
2012-04-23 7:07 ` Anton Vorontsov
2012-04-23 7:07 ` Anton Vorontsov
2012-04-23 7:07 ` Anton Vorontsov
2012-04-26 23:59 ` Andrew Morton
2012-04-26 23:59 ` Andrew Morton
2012-04-26 23:59 ` Andrew Morton
2012-04-26 23:59 ` Andrew Morton
2012-04-26 23:59 ` Andrew Morton
2012-04-26 23:59 ` Andrew Morton
2012-05-01 10:45 ` Peter Zijlstra
2012-05-01 10:45 ` Peter Zijlstra
2012-05-01 10:45 ` Peter Zijlstra
2012-05-01 10:45 ` Peter Zijlstra
2012-05-01 10:45 ` Peter Zijlstra
2012-05-05 1:47 ` [PATCH] cpu: Document clear_tasks_mm_cpumask() Anton Vorontsov
2012-05-05 1:47 ` Anton Vorontsov
2012-05-05 1:47 ` Anton Vorontsov
2012-05-05 1:47 ` Anton Vorontsov
2012-05-05 1:47 ` Anton Vorontsov
2012-05-05 1:47 ` [PATCH 1/9] cpu: Introduce clear_tasks_mm_cpumask() helper Anton Vorontsov
2012-05-05 1:47 ` Anton Vorontsov
2012-05-05 1:47 ` Anton Vorontsov
2012-05-05 1:47 ` Anton Vorontsov
2012-05-05 1:47 ` Anton Vorontsov
2012-04-23 7:08 ` [PATCH 2/9] arm: Use clear_tasks_mm_cpumask() Anton Vorontsov
2012-04-23 7:08 ` Anton Vorontsov
2012-04-23 7:08 ` Anton Vorontsov
2012-04-23 7:08 ` Anton Vorontsov
2012-04-23 7:08 ` Anton Vorontsov
2012-04-23 7:08 ` [PATCH 3/9] powerpc: " Anton Vorontsov
2012-04-23 7:08 ` Anton Vorontsov
2012-04-23 7:08 ` Anton Vorontsov
2012-04-23 7:08 ` Anton Vorontsov
2012-04-23 7:08 ` Anton Vorontsov
2012-04-23 7:08 ` [PATCH 4/9] sh: " Anton Vorontsov
2012-04-23 7:08 ` Anton Vorontsov
2012-04-23 7:08 ` Anton Vorontsov
2012-04-23 7:08 ` Anton Vorontsov
2012-04-23 7:08 ` Anton Vorontsov
2012-04-23 7:09 ` [PATCH 5/9] blackfin: A couple of task->mm handling fixes Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-06-01 4:36 ` Mike Frysinger
2012-06-01 4:36 ` Mike Frysinger
2012-06-01 4:36 ` Mike Frysinger
2012-06-01 4:36 ` Mike Frysinger
2012-04-23 7:09 ` [PATCH 6/9] blackfin: Fix possible deadlock in decode_address() Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov [this message]
2012-04-23 7:09 ` [PATCH 7/9] um: Should hold tasklist_lock while traversing processes Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 14:57 ` Richard Weinberger
2012-04-23 14:57 ` Richard Weinberger
2012-04-23 14:57 ` Richard Weinberger
2012-04-23 14:57 ` Richard Weinberger
2012-04-23 14:57 ` Richard Weinberger
2012-04-23 15:40 ` Anton Vorontsov
2012-04-23 15:40 ` Anton Vorontsov
2012-04-23 15:40 ` Anton Vorontsov
2012-04-23 15:40 ` Anton Vorontsov
2012-04-23 15:40 ` Anton Vorontsov
2012-04-23 7:09 ` [PATCH 8/9] um: Fix possible race on task->mm Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 7:09 ` [PATCH 9/9] um: Properly check all process' threads for a live mm Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
2012-04-23 7:09 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423070925.GG30752@lizard \
--to=anton.vorontsov@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.