From: Jarod Wilson <jarod@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] fintek-cir: change || to &&
Date: Mon, 23 Apr 2012 14:17:25 +0000 [thread overview]
Message-ID: <20120423141725.GA31244@redhat.com> (raw)
In-Reply-To: <20120422080617.GA1252@elgon.mountain>
On Sun, Apr 22, 2012 at 11:06:17AM +0300, Dan Carpenter wrote:
> The current condition is always true, so everything uses
> LOGICAL_DEV_CIR_REV2 (8). It should be that Fintek products
> 0x0408(F71809) and 0x0804(F71855) use logical device
> LOGICAL_DEV_CIR_REV1 (5) and other chip ids use logical device 8.
>
> In other words, this fixes hardware detection for 0x0408 and 0x0804.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
WARNING: multiple messages have this Message-ID (diff)
From: Jarod Wilson <jarod@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] fintek-cir: change || to &&
Date: Mon, 23 Apr 2012 10:17:25 -0400 [thread overview]
Message-ID: <20120423141725.GA31244@redhat.com> (raw)
In-Reply-To: <20120422080617.GA1252@elgon.mountain>
On Sun, Apr 22, 2012 at 11:06:17AM +0300, Dan Carpenter wrote:
> The current condition is always true, so everything uses
> LOGICAL_DEV_CIR_REV2 (8). It should be that Fintek products
> 0x0408(F71809) and 0x0804(F71855) use logical device
> LOGICAL_DEV_CIR_REV1 (5) and other chip ids use logical device 8.
>
> In other words, this fixes hardware detection for 0x0408 and 0x0804.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2012-04-23 14:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 17:25 [media] fintek-cir: add support for newer chip version Dan Carpenter
2012-04-19 20:41 ` Jarod Wilson
2012-04-19 20:46 ` Mauro Carvalho Chehab
2012-04-22 8:06 ` [patch] [media] fintek-cir: change || to && Dan Carpenter
2012-04-22 8:06 ` Dan Carpenter
2012-04-23 14:17 ` Jarod Wilson [this message]
2012-04-23 14:17 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423141725.GA31244@redhat.com \
--to=jarod@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.