All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Lamparter <chunkeey@googlemail.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 2/4] ath9k: set PHYRADAR in RX filter when on DFS channel
Date: Mon, 23 Apr 2012 19:29:47 +0200	[thread overview]
Message-ID: <201204231929.47949.chunkeey@googlemail.com> (raw)
In-Reply-To: <4F951D01.60509@neratec.com>

On Monday, April 23, 2012 11:12:33 AM Zefir Kurtisi wrote:
> On 22.04.2012 22:00, Felix Fietkau wrote:
> > On 2012-04-22 9:50 PM, Zefir Kurtisi wrote:
> >> From: Zefir Kurtisi<zefir.kurtisi@neratec.com>
> >>
> >>
> >> Signed-off-by: Zefir Kurtisi<zefir.kurtisi@neratec.com>
> >> ---
> >>   drivers/net/wireless/ath/ath9k/recv.c |    6 ++++++
> >>   1 files changed, 6 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
> >> index f4ae3ba..ef45c0c 100644
> >> --- a/drivers/net/wireless/ath/ath9k/recv.c
> >> +++ b/drivers/net/wireless/ath/ath9k/recv.c
> >> @@ -17,6 +17,7 @@
> >>   #include<linux/dma-mapping.h>
> >>   #include "ath9k.h"
> >>   #include "ar9003_mac.h"
> >> +#include "dfs.h"
> >>
> >>   #define SKB_CB_ATHBUF(__skb)	(*((struct ath_buf **)__skb->cb))
> >>
> >> @@ -467,6 +468,11 @@ u32 ath_calcrxfilter(struct ath_softc *sc)
> >>   		rfilt |= ATH9K_RX_FILTER_MCAST_BCAST_ALL;
> >>   	}
> >>
> >> +	if (sc->sc_ah->curchan->chan->flags&  IEEE80211_CHAN_RADAR)
> >> +		rfilt |= ATH9K_RX_FILTER_PHYRADAR;
> >> +	else
> >> +		rfilt&= ~ATH9K_RX_FILTER_PHYRADAR;
> > This should only be done in AP mode, maybe mac80211 should have a
> > separate flag to tell the driver to enable this. Same comment also
> > applies to patch 4/4.
> >
> > - Felix
> >
> Are you aware of any issues enabling DFS in client modes? My thinking 
> was that it won't hurt to detect radars in any mode and let the DFS 
> management component decide what to do with that events.
> 
Hm, what about:

"2. Slave devices with a maximum EIRP of less than 23 dBm do not have
to implement radar detection."
<http://linuxwireless.org/en/developers/DFS/ETSI> - Table D.2

So, 5GHz ath9k devices with 23 dBm (or more) have to have
radar detection anyway?

Regards,
	Christian 

WARNING: multiple messages have this Message-ID (diff)
From: Christian Lamparter <chunkeey@googlemail.com>
To: Zefir Kurtisi <zefir.kurtisi@neratec.com>
Cc: Felix Fietkau <nbd@openwrt.org>,
	Zefir Kurtisi <zefir.kurtisi@gmail.com>,
	linville@tuxdriver.com, ath9k-devel@lists.ath9k.org,
	linux-wireless@vger.kernel.org, rodrigue@qca.qualcomm.com,
	achadd@qca.qualcomm.com
Subject: Re: [PATCH 2/4] ath9k: set PHYRADAR in RX filter when on DFS channel
Date: Mon, 23 Apr 2012 19:29:47 +0200	[thread overview]
Message-ID: <201204231929.47949.chunkeey@googlemail.com> (raw)
In-Reply-To: <4F951D01.60509@neratec.com>

On Monday, April 23, 2012 11:12:33 AM Zefir Kurtisi wrote:
> On 22.04.2012 22:00, Felix Fietkau wrote:
> > On 2012-04-22 9:50 PM, Zefir Kurtisi wrote:
> >> From: Zefir Kurtisi<zefir.kurtisi@neratec.com>
> >>
> >>
> >> Signed-off-by: Zefir Kurtisi<zefir.kurtisi@neratec.com>
> >> ---
> >>   drivers/net/wireless/ath/ath9k/recv.c |    6 ++++++
> >>   1 files changed, 6 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
> >> index f4ae3ba..ef45c0c 100644
> >> --- a/drivers/net/wireless/ath/ath9k/recv.c
> >> +++ b/drivers/net/wireless/ath/ath9k/recv.c
> >> @@ -17,6 +17,7 @@
> >>   #include<linux/dma-mapping.h>
> >>   #include "ath9k.h"
> >>   #include "ar9003_mac.h"
> >> +#include "dfs.h"
> >>
> >>   #define SKB_CB_ATHBUF(__skb)	(*((struct ath_buf **)__skb->cb))
> >>
> >> @@ -467,6 +468,11 @@ u32 ath_calcrxfilter(struct ath_softc *sc)
> >>   		rfilt |= ATH9K_RX_FILTER_MCAST_BCAST_ALL;
> >>   	}
> >>
> >> +	if (sc->sc_ah->curchan->chan->flags&  IEEE80211_CHAN_RADAR)
> >> +		rfilt |= ATH9K_RX_FILTER_PHYRADAR;
> >> +	else
> >> +		rfilt&= ~ATH9K_RX_FILTER_PHYRADAR;
> > This should only be done in AP mode, maybe mac80211 should have a
> > separate flag to tell the driver to enable this. Same comment also
> > applies to patch 4/4.
> >
> > - Felix
> >
> Are you aware of any issues enabling DFS in client modes? My thinking 
> was that it won't hurt to detect radars in any mode and let the DFS 
> management component decide what to do with that events.
> 
Hm, what about:

"2. Slave devices with a maximum EIRP of less than 23 dBm do not have
to implement radar detection."
<http://linuxwireless.org/en/developers/DFS/ETSI> - Table D.2

So, 5GHz ath9k devices with 23 dBm (or more) have to have
radar detection anyway?

Regards,
	Christian 

  parent reply	other threads:[~2012-04-23 17:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-22 19:50 [ath9k-devel] [PATCH 0/4] ath9k: integrate DFS detection Zefir Kurtisi
2012-04-22 19:50 ` Zefir Kurtisi
2012-04-22 19:50 ` [ath9k-devel] [PATCH 1/4] ath9k: set detector DFS domain in reg notifyer Zefir Kurtisi
2012-04-22 19:50   ` Zefir Kurtisi
2012-04-22 19:50 ` [ath9k-devel] [PATCH 2/4] ath9k: set PHYRADAR in RX filter when on DFS channel Zefir Kurtisi
2012-04-22 19:50   ` Zefir Kurtisi
2012-04-22 20:00   ` [ath9k-devel] " Felix Fietkau
2012-04-22 20:00     ` Felix Fietkau
2012-04-23  9:12     ` [ath9k-devel] " Zefir Kurtisi
2012-04-23  9:12       ` Zefir Kurtisi
2012-04-23 17:23       ` [ath9k-devel] " Felix Fietkau
2012-04-23 17:23         ` Felix Fietkau
2012-04-23 17:27         ` [ath9k-devel] " Chadd, Adrian
2012-04-23 17:27           ` Chadd, Adrian
2012-04-23 18:28         ` [ath9k-devel] " Luis R. Rodriguez
2012-04-23 18:28           ` Luis R. Rodriguez
2012-04-23 17:29       ` Christian Lamparter [this message]
2012-04-23 17:29         ` Christian Lamparter
2012-04-22 19:50 ` [ath9k-devel] [PATCH 3/4] ath9k: forward pulse events to DFS pulse detector Zefir Kurtisi
2012-04-22 19:50   ` Zefir Kurtisi
2012-05-25 15:16   ` [ath9k-devel] " Benoit Papillault
2012-04-22 19:50 ` [ath9k-devel] [PATCH 4/4] ath9k: set radar config if switching to DFS channel Zefir Kurtisi
2012-04-22 19:50   ` Zefir Kurtisi
2012-04-27 20:50   ` [ath9k-devel] " Adrian Chadd
2012-04-27 20:50     ` Adrian Chadd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204231929.47949.chunkeey@googlemail.com \
    --to=chunkeey@googlemail.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.