From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add new package apr-util
Date: Tue, 24 Apr 2012 12:24:45 +0200 [thread overview]
Message-ID: <20120424122445.0d7b604e@skate> (raw)
In-Reply-To: <1335262302-31058-1-git-send-email-bachmann@tofwerk.com>
Le Tue, 24 Apr 2012 12:11:42 +0200,
Rico Bachmann <bachmann@tofwerk.com> a ?crit :
> +diff -rupN apr-util-1.4.1/configure.in apr-util-1.4.1-fix/configure.in
> +--- apr-util-1.4.1/configure.in 2009-12-17 20:15:19.000000000 +0100
> ++++ apr-util-1.4.1-fix/configure.in 2012-04-24 10:10:32.000000000 +0200
This patch lacks a header explaining what it is doing, why, and a
Signed-off-by line.
I'm also not convinced by this patch, can you detail why it is
necessary? I have the impression that by passing the right environment
variables and/or options to the configure script, you can convince it
to do the right thing, but I haven't looked into too much details about
how APU_FIND_APR is implemented.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-04-24 10:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 10:11 [Buildroot] [PATCH] Add new package apr-util Rico Bachmann
2012-04-24 10:24 ` Thomas Petazzoni [this message]
2012-04-24 10:51 ` Rico Bachmann
-- strict thread matches above, loose matches on Subject: below --
2012-04-24 10:22 Rico Bachmann
2012-04-24 10:28 ` Rico Bachmann
2012-04-24 10:42 ` Yegor Yefremov
2012-04-24 10:46 ` Yegor Yefremov
2012-04-24 10:56 ` Rico Bachmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120424122445.0d7b604e@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.