All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rico Bachmann <bachmann@tofwerk.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add new package apr-util
Date: Tue, 24 Apr 2012 12:51:24 +0200	[thread overview]
Message-ID: <op.wc9m3ydx705kjs@rico> (raw)
In-Reply-To: 20120424122445.0d7b604e@skate

Am 24.04.2012, 12:24 Uhr, schrieb Thomas Petazzoni  
<thomas.petazzoni@free-electrons.com>:

> Le Tue, 24 Apr 2012 12:11:42 +0200,
> Rico Bachmann <bachmann@tofwerk.com> a ?crit :
>
>> +diff -rupN apr-util-1.4.1/configure.in apr-util-1.4.1-fix/configure.in
>> +--- apr-util-1.4.1/configure.in	2009-12-17 20:15:19.000000000 +0100
>> ++++ apr-util-1.4.1-fix/configure.in	2012-04-24 10:10:32.000000000 +0200
>
> This patch lacks a header explaining what it is doing, why, and a
> Signed-off-by line.

I added the Signed-off-by line and added some comments, I will send it  
soon.

>
> I'm also not convinced by this patch, can you detail why it is
> necessary? I have the impression that by passing the right environment
> variables and/or options to the configure script, you can convince it
> to do the right thing, but I haven't looked into too much details about
> how APU_FIND_APR is implemented.

I asked for some help in #apr, they told me that the check of the source  
folder
only works on folders called apr. Because I don't want to rename the source
folder of the apr package (from apr-1.4.6 to apr), I disabled the check  
and the
build works nice for me

I also haven't looked to much in the implementation of APU_FIND_APR, so I  
decided
to do the way of not checking...

>
> Regards,
>
> Thomas

-- 
Erstellt mit Operas revolution?rem E-Mail-Modul: http://www.opera.com/mail/

  reply	other threads:[~2012-04-24 10:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24 10:11 [Buildroot] [PATCH] Add new package apr-util Rico Bachmann
2012-04-24 10:24 ` Thomas Petazzoni
2012-04-24 10:51   ` Rico Bachmann [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-04-24 10:22 Rico Bachmann
2012-04-24 10:28 ` Rico Bachmann
2012-04-24 10:42   ` Yegor Yefremov
2012-04-24 10:46     ` Yegor Yefremov
2012-04-24 10:56       ` Rico Bachmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.wc9m3ydx705kjs@rico \
    --to=bachmann@tofwerk.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.