From: Arnd Bergmann <arnd@arndb.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: "Heiko Stübner" <heiko@sntech.de>,
"Tushar Behera" <tushar.behera@linaro.org>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kgene.kim@samsung.com,
linux@arm.linux.org.uk, patches@linaro.org
Subject: Re: [PATCH 00/33] Use common macro to define resources
Date: Wed, 25 Apr 2012 11:21:47 +0000 [thread overview]
Message-ID: <201204251121.47358.arnd@arndb.de> (raw)
In-Reply-To: <20120425101007.GM9142@game.jcrosoft.org>
On Wednesday 25 April 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:
> >
> > As far as I know legacy SoCs are allowed to keep being non-DT and I don't see
> > the older Samsung SoCs (especially the S3C24XX ones) changing to DT anytime
> > soon, as they don't see any new development but only bug fixes currently.
> >
> >
> > > for my point of view it's cosmetics change
> > it is, but it also makes the code more readable
> we get comment from Linus to do not do cosmetic changes
>
> so if it work well I'll not touch it
I would leave this up for the platform maintainers to decide individually,
as there is no easy answer.
Generally cleanups are welcome and the patch series has the nice effect of
removing a few hundred lines from the platform, which is good. On the other
hand I agree that we should not mess too much with legacy platforms: If
something is in the state where we just want to keep it running and not
get it up to modern coding standards, we shouldn't be doing those changes,
but if a platform is important enough to warrant such cleanups, we should
go the full way and make it use all the right subsystems and use DT instead
of board files.
Note that the point of the DEFINE_RES_*() macros is really to prevent
people from coming up with new silly macros to do the same thing, as
we've had in the past. Converting existing code that is just open-coding
the resources to use these macros is just noise IMHO. If Kukjin Kim wants
to take those patches, I won't complain though.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/33] Use common macro to define resources
Date: Wed, 25 Apr 2012 11:21:47 +0000 [thread overview]
Message-ID: <201204251121.47358.arnd@arndb.de> (raw)
In-Reply-To: <20120425101007.GM9142@game.jcrosoft.org>
On Wednesday 25 April 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:
> >
> > As far as I know legacy SoCs are allowed to keep being non-DT and I don't see
> > the older Samsung SoCs (especially the S3C24XX ones) changing to DT anytime
> > soon, as they don't see any new development but only bug fixes currently.
> >
> >
> > > for my point of view it's cosmetics change
> > it is, but it also makes the code more readable
> we get comment from Linus to do not do cosmetic changes
>
> so if it work well I'll not touch it
I would leave this up for the platform maintainers to decide individually,
as there is no easy answer.
Generally cleanups are welcome and the patch series has the nice effect of
removing a few hundred lines from the platform, which is good. On the other
hand I agree that we should not mess too much with legacy platforms: If
something is in the state where we just want to keep it running and not
get it up to modern coding standards, we shouldn't be doing those changes,
but if a platform is important enough to warrant such cleanups, we should
go the full way and make it use all the right subsystems and use DT instead
of board files.
Note that the point of the DEFINE_RES_*() macros is really to prevent
people from coming up with new silly macros to do the same thing, as
we've had in the past. Converting existing code that is just open-coding
the resources to use these macros is just noise IMHO. If Kukjin Kim wants
to take those patches, I won't complain though.
Arnd
next prev parent reply other threads:[~2012-04-25 11:24 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 4:12 [PATCH 00/33] Use common macro to define resources Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 01/33] ARM: SAMSUNG: devs: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 02/33] ARM: EXYNOS: dev-ahci: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 03/33] ARM: EXYNOS: dev-audio: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 04/33] ARM: EXYNOS: mach-armlex4210: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 05/33] ARM: EXYNOS: mach-smdkv310: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 06/33] ARM: S3C24XX: dev-uart: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 9:13 ` Heiko Stübner
2012-04-25 9:13 ` Heiko Stübner
2012-05-08 18:40 ` [PATCH v2 " Heiko Stübner
2012-05-08 18:40 ` Heiko Stübner
2012-05-09 12:44 ` Kukjin Kim
2012-05-09 12:44 ` Kukjin Kim
2012-04-25 4:12 ` [PATCH 07/33] ARM: S3C24XX: bast-ide: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 08/33] ARM: S3C24XX: mach-amlm5900: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 09/33] ARM: S3C24XX: mach-anubis: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 10/33] ARM: S3C24XX: mach-at2440evb: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 11/33] ARM: S3C24XX: mach-bast: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 12/33] ARM: S3C24XX: mach-gta02: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 13/33] ARM: S3C24XX: mach-h1940: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 14/33] ARM: S3C24XX: mach-mini2440: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 15/33] ARM: S3C24XX: mach-nexcoder: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 16/33] ARM: S3C24XX: mach-osiris: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 16:53 ` Sergei Shtylyov
2012-04-25 16:53 ` Sergei Shtylyov
2012-04-26 3:22 ` Tushar Behera
2012-04-26 3:22 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 17/33] ARM: S3C24XX: mach-otom: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 18/33] ARM: S3C24XX: mach-qt2410: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 16:51 ` Sergei Shtylyov
2012-04-25 16:51 ` Sergei Shtylyov
2012-04-26 3:19 ` Tushar Behera
2012-04-26 3:19 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 19/33] ARM: S3C24XX: mach-rx1950: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 20/33] ARM: S3C24XX: mach-tct_hammer: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 21/33] ARM: S3C24XX: mach-vr1000: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 22/33] ARM: S3C24XX: simtec-nor: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 23/33] ARM: S3C64XX: dev-audio: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 24/33] ARM: S3C64XX: dev-uart: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 25/33] ARM: S3C64XX: mach-anw6410: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 26/33] ARM: S3C64XX: mach-crag6410: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 8:24 ` Mark Brown
2012-04-25 8:24 ` Mark Brown
2012-04-25 4:12 ` [PATCH 27/33] ARM: S3C64XX: mach-mini6410: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 28/33] ARM: S3C64XX: mach-real6410: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 29/33] ARM: S3C64XX: mach-smdk6410: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 30/33] ARM: S5P64X0: dev-audio: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 31/33] ARM: S5PC100: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 32/33] ARM: S5PV210: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 33/33] ARM: S5PV210: mach-smdkv210: " Tushar Behera
2012-04-25 4:12 ` Tushar Behera
2012-04-25 4:19 ` [PATCH 00/33] " Jean-Christophe PLAGNIOL-VILLARD
2012-04-25 4:19 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-25 7:38 ` Heiko Stübner
2012-04-25 7:38 ` Heiko Stübner
2012-04-25 10:10 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-25 10:10 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-25 11:21 ` Arnd Bergmann [this message]
2012-04-25 11:21 ` Arnd Bergmann
2012-04-25 11:35 ` Russell King - ARM Linux
2012-04-25 11:35 ` Russell King - ARM Linux
2012-04-26 3:53 ` Tushar Behera
2012-04-26 3:53 ` Tushar Behera
2012-05-09 12:55 ` Kukjin Kim
2012-05-09 12:55 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204251121.47358.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=patches@linaro.org \
--cc=plagnioj@jcrosoft.com \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.