All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Afzal Mohammed <afzal@ti.com>
Cc: khilman@ti.com, nm@ti.com, linux@arm.linux.org.uk,
	sameo@linux.intel.com, dbaryshkov@gmail.com,
	artem.bityutskiy@linux.intel.com, linux-kernel@vger.kernel.org,
	vimal.newwork@gmail.com, grinberg@compulab.co.il,
	mike@compulab.co.il, linux-mtd@lists.infradead.org,
	linux-omap@vger.kernel.org, dwmw2@infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [TMP] OMAP3EVM: Test gpmc nand & smsc911x
Date: Wed, 25 Apr 2012 09:47:26 -0700	[thread overview]
Message-ID: <20120425164726.GU3739@atomide.com> (raw)
In-Reply-To: <bb95fec60401f7cf6ac77200a12baf3fc83852f5.1333640054.git.afzal@ti.com>

* Afzal Mohammed <afzal@ti.com> [120405 09:08]:
> @@ -114,6 +147,8 @@ static struct omap_smsc911x_platform_data smsc911x_cfg = {
>  
>  static inline void __init omap3evm_init_smsc911x(void)
>  {
> +	struct gpmc_device_pdata *gpmc_smsc911x_info;
> +
>  	/* Configure ethernet controller reset gpio */
>  	if (cpu_is_omap3430()) {
>  		if (get_omap3_evm_rev() == OMAP3EVM_BOARD_GEN_1)
> @@ -122,7 +157,11 @@ static inline void __init omap3evm_init_smsc911x(void)
>  			smsc911x_cfg.gpio_reset = OMAP3EVM_GEN2_ETHR_GPIO_RST;
>  	}
>  
> -	gpmc_smsc911x_init(&smsc911x_cfg);
> +	gpmc_smsc911x_info = gpmc_smsc911x_init(&smsc911x_cfg);
> +	if (gpmc_smsc911x_info)
> +		*gpmc_data_cur++ = gpmc_smsc911x_info;
> +	else
> +		pr_err("error: unable to initilaize gpmc smsc911x\n");
>  }
>  
>  #else

Obviously we can't merge any of this if until all the board-*.c files
are changed and tested.

Can you maybe still keep the old interfaces in addition to the new ones
so we can do the conversion one board-*.c file at a time while keeping
things working?

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Afzal Mohammed <afzal@ti.com>
Cc: khilman@ti.com, linux@arm.linux.org.uk, dwmw2@infradead.org,
	sameo@linux.intel.com, grinberg@compulab.co.il,
	mike@compulab.co.il, nm@ti.com, artem.bityutskiy@linux.intel.com,
	vimal.newwork@gmail.com, dbaryshkov@gmail.com,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [TMP] OMAP3EVM: Test gpmc nand & smsc911x
Date: Wed, 25 Apr 2012 09:47:26 -0700	[thread overview]
Message-ID: <20120425164726.GU3739@atomide.com> (raw)
In-Reply-To: <bb95fec60401f7cf6ac77200a12baf3fc83852f5.1333640054.git.afzal@ti.com>

* Afzal Mohammed <afzal@ti.com> [120405 09:08]:
> @@ -114,6 +147,8 @@ static struct omap_smsc911x_platform_data smsc911x_cfg = {
>  
>  static inline void __init omap3evm_init_smsc911x(void)
>  {
> +	struct gpmc_device_pdata *gpmc_smsc911x_info;
> +
>  	/* Configure ethernet controller reset gpio */
>  	if (cpu_is_omap3430()) {
>  		if (get_omap3_evm_rev() == OMAP3EVM_BOARD_GEN_1)
> @@ -122,7 +157,11 @@ static inline void __init omap3evm_init_smsc911x(void)
>  			smsc911x_cfg.gpio_reset = OMAP3EVM_GEN2_ETHR_GPIO_RST;
>  	}
>  
> -	gpmc_smsc911x_init(&smsc911x_cfg);
> +	gpmc_smsc911x_info = gpmc_smsc911x_init(&smsc911x_cfg);
> +	if (gpmc_smsc911x_info)
> +		*gpmc_data_cur++ = gpmc_smsc911x_info;
> +	else
> +		pr_err("error: unable to initilaize gpmc smsc911x\n");
>  }
>  
>  #else

Obviously we can't merge any of this if until all the board-*.c files
are changed and tested.

Can you maybe still keep the old interfaces in addition to the new ones
so we can do the conversion one board-*.c file at a time while keeping
things working?

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [TMP] OMAP3EVM: Test gpmc nand & smsc911x
Date: Wed, 25 Apr 2012 09:47:26 -0700	[thread overview]
Message-ID: <20120425164726.GU3739@atomide.com> (raw)
In-Reply-To: <bb95fec60401f7cf6ac77200a12baf3fc83852f5.1333640054.git.afzal@ti.com>

* Afzal Mohammed <afzal@ti.com> [120405 09:08]:
> @@ -114,6 +147,8 @@ static struct omap_smsc911x_platform_data smsc911x_cfg = {
>  
>  static inline void __init omap3evm_init_smsc911x(void)
>  {
> +	struct gpmc_device_pdata *gpmc_smsc911x_info;
> +
>  	/* Configure ethernet controller reset gpio */
>  	if (cpu_is_omap3430()) {
>  		if (get_omap3_evm_rev() == OMAP3EVM_BOARD_GEN_1)
> @@ -122,7 +157,11 @@ static inline void __init omap3evm_init_smsc911x(void)
>  			smsc911x_cfg.gpio_reset = OMAP3EVM_GEN2_ETHR_GPIO_RST;
>  	}
>  
> -	gpmc_smsc911x_init(&smsc911x_cfg);
> +	gpmc_smsc911x_info = gpmc_smsc911x_init(&smsc911x_cfg);
> +	if (gpmc_smsc911x_info)
> +		*gpmc_data_cur++ = gpmc_smsc911x_info;
> +	else
> +		pr_err("error: unable to initilaize gpmc smsc911x\n");
>  }
>  
>  #else

Obviously we can't merge any of this if until all the board-*.c files
are changed and tested.

Can you maybe still keep the old interfaces in addition to the new ones
so we can do the conversion one board-*.c file at a time while keeping
things working?

Regards,

Tony

  reply	other threads:[~2012-04-25 16:47 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1333640054.git.afzal@ti.com>
2012-04-05 15:45 ` [PATCH v3 1/9] ARM: OMAP2+: gpmc: driver conversion Afzal Mohammed
2012-04-05 15:45   ` Afzal Mohammed
2012-04-05 15:45   ` Afzal Mohammed
2012-04-05 15:45   ` Afzal Mohammed
2012-04-05 20:21   ` Jon Hunter
2012-04-05 20:21     ` Jon Hunter
2012-04-05 20:21     ` Jon Hunter
2012-04-05 20:21     ` Jon Hunter
2012-04-05 20:34     ` Jon Hunter
2012-04-05 20:34       ` Jon Hunter
2012-04-05 20:34       ` Jon Hunter
2012-04-06  6:52     ` Mohammed, Afzal
2012-04-06  6:52       ` Mohammed, Afzal
2012-04-06  6:52       ` Mohammed, Afzal
2012-04-09 19:50       ` Jon Hunter
2012-04-09 19:50         ` Jon Hunter
2012-04-09 19:50         ` Jon Hunter
2012-04-10 11:00         ` Mohammed, Afzal
2012-04-10 11:00           ` Mohammed, Afzal
2012-04-10 11:00           ` Mohammed, Afzal
2012-04-10 19:23           ` Jon Hunter
2012-04-10 19:23             ` Jon Hunter
2012-04-10 19:23             ` Jon Hunter
2012-04-11  5:11             ` Mohammed, Afzal
2012-04-11  5:11               ` Mohammed, Afzal
2012-04-11  5:11               ` Mohammed, Afzal
2012-04-11 15:47               ` Jon Hunter
2012-04-11 15:47                 ` Jon Hunter
2012-04-11 15:47                 ` Jon Hunter
2012-04-05 15:46 ` [PATCH v3 2/9] ARM: OMAP2+: gpmc: registers for nand driver Afzal Mohammed
2012-04-05 15:46   ` Afzal Mohammed
2012-04-05 15:46   ` Afzal Mohammed
2012-04-05 15:46 ` [PATCH v3 3/9] ARM: OMAP2+: nand: create platform data structure Afzal Mohammed
2012-04-05 15:46   ` Afzal Mohammed
2012-04-05 15:46   ` Afzal Mohammed
2012-04-05 15:46 ` [PATCH v3 4/9] ARM: OMAP2+: gpmc-nand: populate gpmc configs Afzal Mohammed
2012-04-05 15:46   ` Afzal Mohammed
2012-04-05 15:46   ` Afzal Mohammed
2012-04-10 19:24   ` Jon Hunter
2012-04-10 19:24     ` Jon Hunter
2012-04-10 19:24     ` Jon Hunter
2012-04-10 19:24     ` Jon Hunter
2012-04-11  5:15     ` Mohammed, Afzal
2012-04-11  5:15       ` Mohammed, Afzal
2012-04-11  5:15       ` Mohammed, Afzal
2012-04-05 15:46 ` [PATCH v3 5/9] ARM: OMAP2+: gpmc-smsc911x: gpmc driver information Afzal Mohammed
2012-04-05 15:46   ` Afzal Mohammed
2012-04-05 15:46   ` Afzal Mohammed
2012-04-05 15:46 ` [PATCH v3 6/9] mtd: nand: omap2: obtain memory from resource Afzal Mohammed
2012-04-05 15:46   ` Afzal Mohammed
2012-04-05 15:46   ` Afzal Mohammed
2012-04-05 15:47 ` [PATCH v3 7/9] mtd: nand: omap2: use gpmc provided irqs Afzal Mohammed
2012-04-05 15:47   ` Afzal Mohammed
2012-04-05 15:47   ` Afzal Mohammed
2012-04-05 15:47 ` [PATCH v3 8/9] mtd: nand: omap2: handle nand on gpmc Afzal Mohammed
2012-04-05 15:47   ` Afzal Mohammed
2012-04-05 15:47   ` Afzal Mohammed
2012-04-05 15:47 ` [TMP] OMAP3EVM: Test gpmc nand & smsc911x Afzal Mohammed
2012-04-05 16:05   ` Afzal Mohammed
2012-04-05 15:47   ` Afzal Mohammed
2012-04-25 16:47   ` Tony Lindgren [this message]
2012-04-25 16:47     ` Tony Lindgren
2012-04-25 16:47     ` Tony Lindgren
2012-04-26  5:21     ` Mohammed, Afzal
2012-04-26  5:21       ` Mohammed, Afzal
2012-04-26  5:21       ` Mohammed, Afzal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120425164726.GU3739@atomide.com \
    --to=tony@atomide.com \
    --cc=afzal@ti.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=grinberg@compulab.co.il \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mike@compulab.co.il \
    --cc=nm@ti.com \
    --cc=sameo@linux.intel.com \
    --cc=vimal.newwork@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.