All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Saravana Kannan <skannan@codeaurora.org>,
	Mike Turquette <mturquette@linaro.org>,
	Arnd Bergman <arnd.bergmann@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	Andrew Lunn <andrew@lunn.ch>,
	Rob Herring <rob.herring@calxeda.com>,
	Russell King <linux@arm.linux.org.uk>,
	Jeremy Kerr <jeremy.kerr@canonical.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Paul Walmsley <paul@pwsan.com>,
	Shawn Guo <shawn.guo@freescale.com>,
	Jamie Iles <jamie@jamieiles.com>,
	Richard Zhao <richard.zhao@linaro.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Linus Walleij <linus.walleij@stericsson.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Amit Kucheria <amit.kucheria@linaro.org>,
	Deepak Saxena <dsaxena@linaro.org>,
	Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH] clk: Use a separate struct for holding init data.
Date: Thu, 26 Apr 2012 10:49:02 +0100	[thread overview]
Message-ID: <20120426094901.GE3207@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120426083924.GE17184@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

On Thu, Apr 26, 2012 at 10:39:24AM +0200, Sascha Hauer wrote:

> Can we please stop messing with the function prototypes? So you prefer
> passing a struct to clk_register which is fine and yes, it may have
> advantages. But do we really need to change the prototype? Why can't we
> just add a new function?

> I am generally open to do these changes, but we have come to the point
> where people actually want to *use* the clock framework instead of
> rebasing their stuff onto the latest patches.

Or at least wait until we've got somewhere with applying drivers so that
whoever is changing the APIs is responsible for updating at least the
in-tree drivers.  This would minimise the pain for people who've been
sitting waiting to get their stuff in which seems helpful.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: Use a separate struct for holding init data.
Date: Thu, 26 Apr 2012 10:49:02 +0100	[thread overview]
Message-ID: <20120426094901.GE3207@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120426083924.GE17184@pengutronix.de>

On Thu, Apr 26, 2012 at 10:39:24AM +0200, Sascha Hauer wrote:

> Can we please stop messing with the function prototypes? So you prefer
> passing a struct to clk_register which is fine and yes, it may have
> advantages. But do we really need to change the prototype? Why can't we
> just add a new function?

> I am generally open to do these changes, but we have come to the point
> where people actually want to *use* the clock framework instead of
> rebasing their stuff onto the latest patches.

Or at least wait until we've got somewhere with applying drivers so that
whoever is changing the APIs is responsible for updating at least the
in-tree drivers.  This would minimise the pain for people who've been
sitting waiting to get their stuff in which seems helpful.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120426/17d8c96e/attachment.sig>

  parent reply	other threads:[~2012-04-26  9:49 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-26  5:58 [PATCH] clk: Use a separate struct for holding init data Saravana Kannan
2012-04-26  5:58 ` Saravana Kannan
2012-04-26  6:28 ` Saravana Kannan
2012-04-26  6:28   ` Saravana Kannan
2012-04-26  8:42   ` Sascha Hauer
2012-04-26  8:42     ` Sascha Hauer
2012-04-26  9:36     ` Saravana Kannan
2012-04-26  9:36       ` Saravana Kannan
2012-04-26  9:36       ` Saravana Kannan
2012-04-26  9:51       ` Sascha Hauer
2012-04-26  9:51         ` Sascha Hauer
2012-04-30 19:30         ` Saravana Kannan
2012-04-30 19:30           ` Saravana Kannan
2012-04-30 22:19           ` Turquette, Mike
2012-04-30 22:19             ` Turquette, Mike
2012-04-30 22:46             ` Saravana Kannan
2012-04-30 22:46               ` Saravana Kannan
2012-05-01  8:11               ` Shawn Guo
2012-05-01  8:11                 ` Shawn Guo
2012-05-01  9:13                 ` Andrew Lunn
2012-05-01  9:13                   ` Andrew Lunn
2012-05-01  9:13                   ` Andrew Lunn
2012-05-01 17:00                   ` Mark Brown
2012-05-01 17:00                     ` Mark Brown
2012-05-01 17:00                     ` Mark Brown
2012-05-01 18:03                     ` Saravana Kannan
2012-05-01 18:03                       ` Saravana Kannan
2012-05-01 18:19                       ` Mark Brown
2012-05-01 18:19                         ` Mark Brown
2012-05-02  1:56                         ` Mike Turquette
2012-05-02  1:56                           ` Mike Turquette
2012-05-02  2:14                           ` Shawn Guo
2012-05-02  2:14                             ` Shawn Guo
2012-05-02  5:16                           ` Andrew Lunn
2012-05-02  5:16                             ` Andrew Lunn
2012-05-02  5:16                             ` Andrew Lunn
2012-05-02 19:19                             ` Mike Turquette
2012-05-02 19:19                               ` Mike Turquette
2012-05-02 19:19                               ` Mike Turquette
2012-05-02 13:32                           ` Arnd Bergmann
2012-05-02 13:32                             ` Arnd Bergmann
2012-05-02 15:28                           ` Mark Brown
2012-05-02 15:28                             ` Mark Brown
2012-05-01 18:04                     ` Andrew Lunn
2012-05-01 18:04                       ` Andrew Lunn
2012-05-01 18:04                       ` Andrew Lunn
2012-04-26  8:39 ` Sascha Hauer
2012-04-26  8:39   ` Sascha Hauer
2012-04-26  9:15   ` Saravana Kannan
2012-04-26  9:15     ` Saravana Kannan
2012-04-26  9:15     ` Saravana Kannan
2012-04-26  9:49   ` Mark Brown [this message]
2012-04-26  9:49     ` Mark Brown
2012-05-02  2:04 ` Mike Turquette
2012-05-02  2:04   ` Mike Turquette
2012-05-02  4:42   ` Saravana Kannan
2012-05-02  4:42     ` Saravana Kannan
2012-05-02 19:07     ` Mike Turquette
2012-05-02 19:07       ` Mike Turquette
2012-05-02  9:58 ` Sascha Hauer
2012-05-02  9:58   ` Sascha Hauer
2012-05-02 10:02   ` Russell King - ARM Linux
2012-05-02 10:02     ` Russell King - ARM Linux
2012-05-02 10:11     ` Sascha Hauer
2012-05-02 10:11       ` Sascha Hauer
2012-05-03 23:03 ` Domenico Andreoli
2012-05-03 23:03   ` Domenico Andreoli
2012-05-04  1:11   ` Saravana Kannan
2012-05-04  1:11     ` Saravana Kannan
2012-05-04  6:50     ` Domenico Andreoli
2012-05-04  6:50       ` Domenico Andreoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120426094901.GE3207@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=amit.kucheria@linaro.org \
    --cc=andrew@lunn.ch \
    --cc=arnd.bergmann@linaro.org \
    --cc=dsaxena@linaro.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jamie@jamieiles.com \
    --cc=jeremy.kerr@canonical.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=mturquette@linaro.org \
    --cc=paul@pwsan.com \
    --cc=richard.zhao@linaro.org \
    --cc=rob.herring@calxeda.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@codeaurora.org \
    --cc=shawn.guo@freescale.com \
    --cc=skannan@codeaurora.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.