From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 5/7] mmc: tmio: add regulator support
Date: Thu, 26 Apr 2012 13:11:51 +0100 [thread overview]
Message-ID: <20120426121150.GJ3207@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1335285707-22707-6-git-send-email-g.liakhovetski@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
On Tue, Apr 24, 2012 at 06:41:45PM +0200, Guennadi Liakhovetski wrote:
> + host->vdd = regulator_get(mmc_dev(mmc), "SD Vdd");
> + if (IS_ERR(host->vdd)) {
> + host->vdd = NULL;
> + } else {
This silently ignoring errors really isn't good practice :(
> @@ -1052,6 +1079,7 @@ void tmio_mmc_host_remove(struct tmio_mmc_host *host)
>
> pm_runtime_put_sync(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> + regulator_put(host->vdd);
devm_regulator_get() is there now.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 5/7] mmc: tmio: add regulator support
Date: Thu, 26 Apr 2012 12:11:51 +0000 [thread overview]
Message-ID: <20120426121150.GJ3207@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1335285707-22707-6-git-send-email-g.liakhovetski@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
On Tue, Apr 24, 2012 at 06:41:45PM +0200, Guennadi Liakhovetski wrote:
> + host->vdd = regulator_get(mmc_dev(mmc), "SD Vdd");
> + if (IS_ERR(host->vdd)) {
> + host->vdd = NULL;
> + } else {
This silently ignoring errors really isn't good practice :(
> @@ -1052,6 +1079,7 @@ void tmio_mmc_host_remove(struct tmio_mmc_host *host)
>
> pm_runtime_put_sync(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> + regulator_put(host->vdd);
devm_regulator_get() is there now.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-26 12:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 16:41 [PATCH/RFC 0/7] mmc: tmio: regulator support, clock management, convert ecovec Guennadi Liakhovetski
2012-04-24 16:41 ` Guennadi Liakhovetski
2012-04-24 16:41 ` [PATCH 1/7] mmc: tmio: stop interface clock before runtime PM suspending Guennadi Liakhovetski
2012-04-24 16:41 ` Guennadi Liakhovetski
2012-04-24 16:41 ` [PATCH 2/7] mmc: tmio: don't needlessly enable interrupts during probing Guennadi Liakhovetski
2012-04-24 16:41 ` Guennadi Liakhovetski
2012-04-24 16:41 ` [PATCH 3/7] mmc: tmio: add callbacks to enable-update and disable the interface clock Guennadi Liakhovetski
2012-04-24 16:41 ` Guennadi Liakhovetski
2012-04-24 16:41 ` [PATCH 4/7] mmc: sdhi: implement tmio-mmc clock enable-update and disable callbacks Guennadi Liakhovetski
2012-04-24 16:41 ` Guennadi Liakhovetski
2012-04-24 16:41 ` [PATCH 5/7] mmc: tmio: add regulator support Guennadi Liakhovetski
2012-04-24 16:41 ` Guennadi Liakhovetski
2012-04-26 12:11 ` Mark Brown [this message]
2012-04-26 12:11 ` Mark Brown
2012-04-24 16:41 ` [PATCH 6/7] mmc: sdhi: do not install dummy callbacks Guennadi Liakhovetski
2012-04-24 16:41 ` Guennadi Liakhovetski
2012-04-24 16:41 ` [PATCH 7/7] sh: ecovec: switch MMC power control to regulators Guennadi Liakhovetski
2012-04-24 16:41 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120426121150.GJ3207@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lrg@ti.com \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.