From: Gerard Snitselaar <dev@snitselaar.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: sameo@linux.intel.com, ldewangan@nvidia.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd/tps65910: fix section mismatch in linux-next
Date: Thu, 26 Apr 2012 19:40:12 -0700 [thread overview]
Message-ID: <20120427024012.GA9480@cantor.Home> (raw)
In-Reply-To: <20120426213449.GB9415@sirena.org.uk>
On Thu Apr 26 12, Mark Brown wrote:
> On Tue, Apr 24, 2012 at 08:13:55AM -0700, Gerard Snitselaar wrote:
>
> > -static int tps65910_i2c_probe(struct i2c_client *i2c,
> > +static int __init tps65910_i2c_probe(struct i2c_client *i2c,
> > const struct i2c_device_id *id)
>
> I sent a separate fix for this earlier on - __init is the wrong
> annotation here, a device init function should be marked __devinit.
I missed your patch when I did a search initially. Does it also change the annotation of tps65910_sleepinit() to __devinit ? If all devices are supposed to have their init functions annotated __devinit is the comment in correct in init.h which says the __dev* annotations are used for HOTPLUG? Is this power management chip hotpluggable?
prev parent reply other threads:[~2012-04-27 2:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 15:13 [PATCH] mfd/tps65910: fix section mismatch in linux-next Gerard Snitselaar
2012-04-24 16:16 ` Stephen Warren
2012-04-25 7:13 ` Laxman Dewangan
2012-04-26 21:34 ` Mark Brown
2012-04-27 2:40 ` Gerard Snitselaar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120427024012.GA9480@cantor.Home \
--to=dev@snitselaar.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.