All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Gerard Snitselaar <dev@snitselaar.org>
Cc: sameo@linux.intel.com, ldewangan@nvidia.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd/tps65910: fix section mismatch in linux-next
Date: Tue, 24 Apr 2012 10:16:01 -0600	[thread overview]
Message-ID: <4F96D1C1.7060701@wwwdotorg.org> (raw)
In-Reply-To: <1335280435-2457-1-git-send-email-dev@snitselaar.org>

On 04/24/2012 09:13 AM, Gerard Snitselaar wrote:
> tps65910_i2c_probe() calls tps65910_sleepinit() which is annnotated __init.

> -static int tps65910_i2c_probe(struct i2c_client *i2c,
> +static int __init tps65910_i2c_probe(struct i2c_client *i2c,

Shouldn't this be __devinit not __init?

  reply	other threads:[~2012-04-24 16:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24 15:13 [PATCH] mfd/tps65910: fix section mismatch in linux-next Gerard Snitselaar
2012-04-24 16:16 ` Stephen Warren [this message]
2012-04-25  7:13 ` Laxman Dewangan
2012-04-26 21:34 ` Mark Brown
2012-04-27  2:40   ` Gerard Snitselaar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F96D1C1.7060701@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=dev@snitselaar.org \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.