From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Olof Johansson <olof@lixom.net>,
balbi@ti.com, Herbert Xu <herbert@gondor.hengli.com.au>,
Matt Mackall <mpm@selenic.com>,
linux-kernel@vger.kernel.org
Subject: Re: Default Kconfig state for hw_random drivers
Date: Fri, 27 Apr 2012 18:35:06 +0100 [thread overview]
Message-ID: <20120427173504.GK18260@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <201204271255.36789.arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 750 bytes --]
On Fri, Apr 27, 2012 at 12:55:36PM +0000, Arnd Bergmann wrote:
> On Friday 27 April 2012, Mark Brown wrote:
> > There is one, that's the problem - the driver is defaulting to the same
> > state as the main hw_random option (as is idiomatic for this subsystem).
> > This means that if you've enabled any hw_random device this driver will
> > be enabled by default. I would argue that this default directive only
> > makes sense if there's an explicit dependency limiting the platforms it
> > can build on. If it can build on any platform then omitting the default
> > and just defaulting to N as is normal for drivers would be better.
> How about making it default to (HW_RANDOM && ARCH_AT91) then?
Yes, something like that would do the job too.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-27 17:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 11:42 Default Kconfig state for hw_random drivers Mark Brown
2012-04-26 14:17 ` Olof Johansson
2012-04-26 14:41 ` Mark Brown
2012-04-27 12:31 ` Nicolas Ferre
2012-04-27 12:36 ` Mark Brown
2012-04-27 12:55 ` Arnd Bergmann
2012-04-27 17:35 ` Mark Brown [this message]
2012-04-30 9:49 ` [PATCH] hwrng: Kconfig: modify default state for atmel-rng driver Nicolas Ferre
2012-04-30 9:49 ` Nicolas Ferre
2012-04-30 9:55 ` Mark Brown
2012-04-30 9:55 ` Mark Brown
2012-04-30 10:02 ` Herbert Xu
2012-04-30 10:02 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120427173504.GK18260@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=nicolas.ferre@atmel.com \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.