From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Olof Johansson <olof@lixom.net>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Arnd Bergmann <arnd@arndb.de>, <balbi@ti.com>
Cc: Herbert Xu <herbert@gondor.hengli.com.au>,
Matt Mackall <mpm@selenic.com>, <linux-kernel@vger.kernel.org>
Subject: Re: Default Kconfig state for hw_random drivers
Date: Fri, 27 Apr 2012 14:31:36 +0200 [thread overview]
Message-ID: <4F9A91A8.4050608@atmel.com> (raw)
In-Reply-To: <CAOesGMj2eZvWek86D2MKQMPY9qAsC0D2MsYyN-+RPUr5gDFn4A@mail.gmail.com>
On 04/26/2012 04:17 PM, Olof Johansson :
> On Thu, Apr 26, 2012 at 4:42 AM, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
>> An Atmel hw_random driver just appeared in -next. Since it's just a
>> regular platform device it has no dependencies on any particular
>> platform so following the behaviour of other hw_random drivers it's set
>> to default enabled if hw_random is enabled, even on non-Atmel platforms.
>>
>> This doesn't feel like the right thing to do - it'd mean that most of
>> the embedded RNGs would end up getting enabled by default which probably
>> isn't what we want.
>
> Indeed, thanks for catching this. The driver isn't new but it had a
> previous dependency on just one AT91 chip family.
>
> Looking at other options in the same Kconfig, it would be appropriate
> to make it depend on ARCH_AT91 instead.
>
> Nicolas?
Hi,
I had the same kind of discussion with Felipe and Arnd in this thread:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/122248/focus=122304
The conclusion came out after Arnd's strong arguments:
http://article.gmane.org/gmane.linux.ports.arm.kernel/122962
Maybe adding a "default" directive can be an valid option?
Best regards,
--
Nicolas Ferre
next prev parent reply other threads:[~2012-04-27 12:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 11:42 Default Kconfig state for hw_random drivers Mark Brown
2012-04-26 14:17 ` Olof Johansson
2012-04-26 14:41 ` Mark Brown
2012-04-27 12:31 ` Nicolas Ferre [this message]
2012-04-27 12:36 ` Mark Brown
2012-04-27 12:55 ` Arnd Bergmann
2012-04-27 17:35 ` Mark Brown
2012-04-30 9:49 ` [PATCH] hwrng: Kconfig: modify default state for atmel-rng driver Nicolas Ferre
2012-04-30 9:49 ` Nicolas Ferre
2012-04-30 9:55 ` Mark Brown
2012-04-30 9:55 ` Mark Brown
2012-04-30 10:02 ` Herbert Xu
2012-04-30 10:02 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9A91A8.4050608@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.