From: eric@eukrea.com (Eric Bénard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] pwm-core: fix compilation when OF is not selected
Date: Sun, 29 Apr 2012 19:32:24 +0200 [thread overview]
Message-ID: <20120429193224.2cdc75e7@eb-e6520> (raw)
In-Reply-To: <20120429170431.GA29827@avionic-0098.adnet.avionic-design.de>
Le Sun, 29 Apr 2012 19:04:31 +0200,
Thierry Reding <thierry.reding@avionic-design.de> a ?crit :
> * Eric B?nard wrote:
> > else we get the following error :
> > drivers/pwm/core.c: In function 'pwm_get':
> > drivers/pwm/core.c:538:3: error: implicit declaration of function 'of_pwm_request' [-Werror=implicit-function-declaration]
> >
> > Signed-off-by: Eric B?nard <eric@eukrea.com>
>
> This is solved a little differently in the latest patches. That no longer has
> the of_pwm_request() function protected by #ifdef CONFIG_OF, but rather calls
> it in a IS_ENABLED(CONFIG_OF)-protected block so that it will still receive
> compile coverage in !OF configurations but at the same time will be removed
> by the compiler's dead code elimination.
>
OK, this was based on de8eba0b1e53ee0d2e3270c12d6482971e2beb4b in your
tree dated the 27th march. I now see you updated it on friday.
Eric
next prev parent reply other threads:[~2012-04-29 17:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 15:28 [PATCH 1/3] pwm-core: fix compilation when OF is not selected Eric Bénard
2012-04-29 15:28 ` [PATCH 2/3] pwm-imx: set chip.dev to prevent probe failure Eric Bénard
2012-04-29 17:07 ` Thierry Reding
2012-04-29 15:28 ` [PATCH 3/3] pwm-core: fix registration of several pwm Eric Bénard
2012-04-29 17:14 ` Thierry Reding
2012-04-29 17:04 ` [PATCH 1/3] pwm-core: fix compilation when OF is not selected Thierry Reding
2012-04-29 17:32 ` Eric Bénard [this message]
2012-04-29 18:59 ` Eric Bénard
2012-04-29 19:04 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120429193224.2cdc75e7@eb-e6520 \
--to=eric@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.