All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Kevin Hilman <khilman@ti.com>, Paul Walmsley <paul@pwsan.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/6] ARM: OMAP: hwmod: remove runtime cpu_is checking
Date: Mon, 30 Apr 2012 09:05:29 -0700	[thread overview]
Message-ID: <20120430160527.GC3739@atomide.com> (raw)
In-Reply-To: <4F9E8CA7.8050700@ti.com>

* Santosh Shilimkar <santosh.shilimkar@ti.com> [120430 06:03]:
> On Saturday 28 April 2012 01:35 AM, Kevin Hilman wrote:
> > This series attempts to remove all the runtime cpu_is* checking in
> > omap_hwmod.c in favor of using function pointers initialized at init
> > time.
> > 
> > This series was motivated by the addition of support for the AM335x
> > series which was done by adding several more cpu_is* checks, and
> > provided the proverbial straw that broke the camel's back.  
> > 
> > In addition to the cleanup, this provides a much cleaner way of adding
> > additional SoC support since it no longer requires adding additional
> > runtime cpu_is* checks.
> > 
> > Boot tested on OMAP3530/Overo and OMAP4430/Panda.
> > 
> I was looking at some of these while trying to OMAP5
> support. Indeed the cpu_is_* is becoming increasingly
> no maintanable and ugly. Thanks for the series.

Also we need to start considering what happens if non-omap code
calls cpu_is_omapxxx for common zImage kernels.. So it's best to
make sure they only happen in omap specific calls during init time.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/6] ARM: OMAP: hwmod: remove runtime cpu_is checking
Date: Mon, 30 Apr 2012 09:05:29 -0700	[thread overview]
Message-ID: <20120430160527.GC3739@atomide.com> (raw)
In-Reply-To: <4F9E8CA7.8050700@ti.com>

* Santosh Shilimkar <santosh.shilimkar@ti.com> [120430 06:03]:
> On Saturday 28 April 2012 01:35 AM, Kevin Hilman wrote:
> > This series attempts to remove all the runtime cpu_is* checking in
> > omap_hwmod.c in favor of using function pointers initialized at init
> > time.
> > 
> > This series was motivated by the addition of support for the AM335x
> > series which was done by adding several more cpu_is* checks, and
> > provided the proverbial straw that broke the camel's back.  
> > 
> > In addition to the cleanup, this provides a much cleaner way of adding
> > additional SoC support since it no longer requires adding additional
> > runtime cpu_is* checks.
> > 
> > Boot tested on OMAP3530/Overo and OMAP4430/Panda.
> > 
> I was looking at some of these while trying to OMAP5
> support. Indeed the cpu_is_* is becoming increasingly
> no maintanable and ugly. Thanks for the series.

Also we need to start considering what happens if non-omap code
calls cpu_is_omapxxx for common zImage kernels.. So it's best to
make sure they only happen in omap specific calls during init time.

Regards,

Tony

  reply	other threads:[~2012-04-30 16:05 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-27 20:05 [PATCH 0/6] ARM: OMAP: hwmod: remove runtime cpu_is checking Kevin Hilman
2012-04-27 20:05 ` Kevin Hilman
2012-04-27 20:05 ` [PATCH 1/6] ARM: OMAP4: hwmod: rename _enable_module to _omap4_enable_module() Kevin Hilman
2012-04-27 20:05   ` Kevin Hilman
2012-04-29 10:11   ` Hiremath, Vaibhav
2012-04-29 10:11     ` Hiremath, Vaibhav
2012-04-30 14:22   ` Paul Walmsley
2012-04-30 14:22     ` Paul Walmsley
2012-04-30 17:15     ` Kevin Hilman
2012-04-30 17:15       ` Kevin Hilman
2012-04-27 20:05 ` [PATCH 2/6] ARM: OMAP2+: hwmod: use init-time function ptrs for enable/disable module Kevin Hilman
2012-04-27 20:05   ` Kevin Hilman
2012-04-30 14:28   ` Paul Walmsley
2012-04-30 14:28     ` Paul Walmsley
2012-04-27 20:05 ` [PATCH 3/6] ARM: OMAP4: hwmod: drop extra cpu_is check from _wait_target_disable() Kevin Hilman
2012-04-27 20:05   ` Kevin Hilman
2012-04-30 14:29   ` Paul Walmsley
2012-04-30 14:29     ` Paul Walmsley
2012-04-27 20:05 ` [PATCH 4/6] ARM: OMAP2+: hwmod: use init-time function pointer for wait_target_ready Kevin Hilman
2012-04-27 20:05   ` Kevin Hilman
2012-04-30 14:33   ` Paul Walmsley
2012-04-30 14:33     ` Paul Walmsley
2012-04-27 20:05 ` [PATCH 5/6] ARM: OMAP2+: hwmod: use init-time function pointer for hardreset Kevin Hilman
2012-04-27 20:05   ` Kevin Hilman
2012-04-30 14:34   ` Paul Walmsley
2012-04-30 14:34     ` Paul Walmsley
2012-04-27 20:05 ` [PATCH 6/6] ARM: OMAP2+: hwmod: use init-time function pointer for _init_clkdm Kevin Hilman
2012-04-27 20:05   ` Kevin Hilman
2012-04-30 14:35   ` Paul Walmsley
2012-04-30 14:35     ` Paul Walmsley
2012-04-29 10:29 ` [PATCH 0/6] ARM: OMAP: hwmod: remove runtime cpu_is checking Hiremath, Vaibhav
2012-04-29 10:29   ` Hiremath, Vaibhav
2012-04-30 12:59 ` Santosh Shilimkar
2012-04-30 12:59   ` Santosh Shilimkar
2012-04-30 16:05   ` Tony Lindgren [this message]
2012-04-30 16:05     ` Tony Lindgren
2012-04-30 14:41 ` Paul Walmsley
2012-04-30 14:41   ` Paul Walmsley
2012-06-14 10:01   ` a0393909
2012-06-14 10:01     ` a0393909

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120430160527.GC3739@atomide.com \
    --to=tony@atomide.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.