From: "J. Bruce Fields" <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
To: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
Cc: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>,
linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [PATCH resend] nfsd: fix nfs4recover.c printk format warning
Date: Mon, 30 Apr 2012 17:41:37 -0400 [thread overview]
Message-ID: <20120430214137.GC22323@fieldses.org> (raw)
In-Reply-To: <4F9EE72B.1020401-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
On Mon, Apr 30, 2012 at 12:25:31PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
>
> Fix printk format warnings -- both items are size_t,
> so use %zu to print them.
>
> fs/nfsd/nfs4recover.c:580:3: warning: format '%lu' expects type 'long unsigned int', but argument 3 has type 'size_t'
> fs/nfsd/nfs4recover.c:580:3: warning: format '%lu' expects type 'long unsigned int', but argument 4 has type 'unsigned int'
>
> Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
> Cc: "J. Bruce Fields" <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
> Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Looks like Linus just took this. (Thanks!)
--b.
> ---
> fs/nfsd/nfs4recover.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This patch was originally sent on Apr.19/2012 for linux-next.
> It is still needed in linux-next and in mainline.
>
>
> --- linux-next-20120419.orig/fs/nfsd/nfs4recover.c
> +++ linux-next-20120419/fs/nfsd/nfs4recover.c
> @@ -577,7 +577,7 @@ cld_pipe_downcall(struct file *filp, con
> struct cld_net *cn = nn->cld_net;
>
> if (mlen != sizeof(*cmsg)) {
> - dprintk("%s: got %lu bytes, expected %lu\n", __func__, mlen,
> + dprintk("%s: got %zu bytes, expected %zu\n", __func__, mlen,
> sizeof(*cmsg));
> return -EINVAL;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-nfs@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH resend] nfsd: fix nfs4recover.c printk format warning
Date: Mon, 30 Apr 2012 17:41:37 -0400 [thread overview]
Message-ID: <20120430214137.GC22323@fieldses.org> (raw)
In-Reply-To: <4F9EE72B.1020401@xenotime.net>
On Mon, Apr 30, 2012 at 12:25:31PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix printk format warnings -- both items are size_t,
> so use %zu to print them.
>
> fs/nfsd/nfs4recover.c:580:3: warning: format '%lu' expects type 'long unsigned int', but argument 3 has type 'size_t'
> fs/nfsd/nfs4recover.c:580:3: warning: format '%lu' expects type 'long unsigned int', but argument 4 has type 'unsigned int'
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc: "J. Bruce Fields" <bfields@fieldses.org>
> Cc: linux-nfs@vger.kernel.org
Looks like Linus just took this. (Thanks!)
--b.
> ---
> fs/nfsd/nfs4recover.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This patch was originally sent on Apr.19/2012 for linux-next.
> It is still needed in linux-next and in mainline.
>
>
> --- linux-next-20120419.orig/fs/nfsd/nfs4recover.c
> +++ linux-next-20120419/fs/nfsd/nfs4recover.c
> @@ -577,7 +577,7 @@ cld_pipe_downcall(struct file *filp, con
> struct cld_net *cn = nn->cld_net;
>
> if (mlen != sizeof(*cmsg)) {
> - dprintk("%s: got %lu bytes, expected %lu\n", __func__, mlen,
> + dprintk("%s: got %zu bytes, expected %zu\n", __func__, mlen,
> sizeof(*cmsg));
> return -EINVAL;
> }
next prev parent reply other threads:[~2012-04-30 21:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 6:46 linux-next: Tree for Apr 19 Stephen Rothwell
2012-04-19 22:26 ` linux-next: Tree for Apr 19 (media/video/mt9m032.c) Randy Dunlap
2012-04-19 23:20 ` Mauro Carvalho Chehab
2012-04-19 22:30 ` linux-next: Tree for Apr 19 (zcache) Randy Dunlap
2012-04-19 22:36 ` Dan Magenheimer
2012-04-19 23:49 ` Seth Jennings
2012-04-20 4:36 ` Seth Jennings
2012-04-20 16:37 ` Konrad Rzeszutek Wilk
2012-04-20 19:06 ` Seth Jennings
2012-04-24 1:06 ` Konrad Rzeszutek Wilk
2012-04-19 23:15 ` [PATCH -next] nfsd: fix nfs4recover.f printk format warning Randy Dunlap
[not found] ` <4F909C78.7000008-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
2012-04-30 19:25 ` [PATCH resend] nfsd: fix nfs4recover.c " Randy Dunlap
2012-04-30 19:25 ` Randy Dunlap
[not found] ` <4F9EE72B.1020401-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
2012-04-30 21:41 ` J. Bruce Fields [this message]
2012-04-30 21:41 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120430214137.GC22323@fieldses.org \
--to=bfields-uc3wqj2krung9huczpvpmw@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.