* [PATCH] s3c2412-i2s: Fix dai registration
@ 2012-04-30 11:17 Heiko Stübner
2012-04-30 22:46 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stübner @ 2012-04-30 11:17 UTC (permalink / raw)
To: sbkim73, lrg, broonie, alsa-devel
As s3c2412-i2s is using the s3c_i2sv2 it should call the more specialised
s3c_i2sv2_register_dai instead of simply calling snd_soc_register_dai.
Without this call the snd_soc_dai_ops structure isn't initialised correctly.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
sound/soc/samsung/s3c2412-i2s.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/samsung/s3c2412-i2s.c b/sound/soc/samsung/s3c2412-i2s.c
index 7218507..79fbeea 100644
--- a/sound/soc/samsung/s3c2412-i2s.c
+++ b/sound/soc/samsung/s3c2412-i2s.c
@@ -166,7 +166,7 @@ static struct snd_soc_dai_driver s3c2412_i2s_dai = {
static __devinit int s3c2412_iis_dev_probe(struct platform_device *pdev)
{
- return snd_soc_register_dai(&pdev->dev, &s3c2412_i2s_dai);
+ return s3c_i2sv2_register_dai(&pdev->dev, -1, &s3c2412_i2s_dai);
}
static __devexit int s3c2412_iis_dev_remove(struct platform_device *pdev)
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] s3c2412-i2s: Fix dai registration
2012-04-30 11:17 [PATCH] s3c2412-i2s: Fix dai registration Heiko Stübner
@ 2012-04-30 22:46 ` Mark Brown
2012-05-01 11:35 ` Heiko Stübner
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2012-04-30 22:46 UTC (permalink / raw)
To: Heiko Stübner; +Cc: sbkim73, alsa-devel, lrg
[-- Attachment #1.1: Type: text/plain, Size: 300 bytes --]
On Mon, Apr 30, 2012 at 01:17:21PM +0200, Heiko Stübner wrote:
> As s3c2412-i2s is using the s3c_i2sv2 it should call the more specialised
> s3c_i2sv2_register_dai instead of simply calling snd_soc_register_dai.
Applied, thanks. Please always use subject lines appropraite for the
subsystem.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] s3c2412-i2s: Fix dai registration
2012-04-30 22:46 ` Mark Brown
@ 2012-05-01 11:35 ` Heiko Stübner
0 siblings, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2012-05-01 11:35 UTC (permalink / raw)
To: Mark Brown; +Cc: sbkim73, alsa-devel, lrg
Am Dienstag 01 Mai 2012, 00:46:11 schrieb Mark Brown:
> On Mon, Apr 30, 2012 at 01:17:21PM +0200, Heiko Stübner wrote:
> > As s3c2412-i2s is using the s3c_i2sv2 it should call the more specialised
> > s3c_i2sv2_register_dai instead of simply calling snd_soc_register_dai.
>
> Applied, thanks. Please always use subject lines appropraite for the
> subsystem.
which should've been "ASoC:" in this case, sorry for getting it wrong
Heiko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-01 11:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-30 11:17 [PATCH] s3c2412-i2s: Fix dai registration Heiko Stübner
2012-04-30 22:46 ` Mark Brown
2012-05-01 11:35 ` Heiko Stübner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.