From: Guenter Roeck <guenter.roeck@ericsson.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
Andi Kleen <ak@linux.intel.com>,
Jean Delvare <khali@linux-fr.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] [PATCH] hwmon: coretemp: fix oops on cpu unplug
Date: Tue, 01 May 2012 15:20:14 +0000 [thread overview]
Message-ID: <20120501152014.GA2629@ericsson.com> (raw)
In-Reply-To: <1335791881-1560-1-git-send-email-kirill.shutemov@linux.intel.com>
On Mon, Apr 30, 2012 at 09:18:01AM -0400, Kirill A. Shutemov wrote:
> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
>
> coretemp tries to access core_data array beyond bounds on cpu unplug if
> core id of the cpu if more than NUM_REAL_CORES-1.
>
[ ... ]
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Looking at it again, you were right. Adding the check to get_core_online()
doesn't really help as the platform device is per CPU, not per core.
Applied. I'll submit a separate patch to increase NUM_REAL_CORES.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
Andi Kleen <ak@linux.intel.com>,
Jean Delvare <khali@linux-fr.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwmon: coretemp: fix oops on cpu unplug
Date: Tue, 1 May 2012 08:20:14 -0700 [thread overview]
Message-ID: <20120501152014.GA2629@ericsson.com> (raw)
In-Reply-To: <1335791881-1560-1-git-send-email-kirill.shutemov@linux.intel.com>
On Mon, Apr 30, 2012 at 09:18:01AM -0400, Kirill A. Shutemov wrote:
> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
>
> coretemp tries to access core_data array beyond bounds on cpu unplug if
> core id of the cpu if more than NUM_REAL_CORES-1.
>
[ ... ]
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Looking at it again, you were right. Adding the check to get_core_online()
doesn't really help as the platform device is per CPU, not per core.
Applied. I'll submit a separate patch to increase NUM_REAL_CORES.
Guenter
next prev parent reply other threads:[~2012-05-01 15:20 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 13:18 [lm-sensors] [PATCH] hwmon: coretemp: fix oops on cpu unplug Kirill A. Shutemov
2012-04-30 13:18 ` Kirill A. Shutemov
2012-04-30 15:28 ` [lm-sensors] " Guenter Roeck
2012-04-30 15:28 ` Guenter Roeck
2012-04-30 16:19 ` [lm-sensors] " Kirill A. Shutemov
2012-04-30 16:19 ` Kirill A. Shutemov
2012-04-30 16:59 ` [lm-sensors] " Guenter Roeck
2012-04-30 16:59 ` Guenter Roeck
2012-05-01 15:20 ` Guenter Roeck [this message]
2012-05-01 15:20 ` Guenter Roeck
2012-05-01 21:00 ` [lm-sensors] " Kirill A. Shutemov
2012-05-01 21:00 ` Kirill A. Shutemov
2012-05-01 21:25 ` [lm-sensors] " Guenter Roeck
2012-05-01 21:25 ` Guenter Roeck
2012-05-02 15:10 ` [lm-sensors] [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data Kirill A. Shutemov
2012-05-02 15:10 ` Kirill A. Shutemov
2012-05-03 5:29 ` [lm-sensors] " R, Durgadoss
2012-05-03 5:29 ` R, Durgadoss
2012-05-03 10:04 ` Kirill A. Shutemov
2012-05-03 10:04 ` Kirill A. Shutemov
2012-05-03 11:18 ` [lm-sensors] [PATCH, v2] hwmon: coretemp: use list instead of fixed size array for temp Kirill A. Shutemov
2012-05-03 11:18 ` [PATCH, v2] hwmon: coretemp: use list instead of fixed size array for temp data Kirill A. Shutemov
2012-05-04 5:41 ` [lm-sensors] [PATCH, v2] hwmon: coretemp: use list instead of fixed size array for temp Guenter Roeck
2012-05-04 5:41 ` [PATCH, v2] hwmon: coretemp: use list instead of fixed size array for temp data Guenter Roeck
2012-05-04 6:46 ` [lm-sensors] [PATCH, v2] hwmon: coretemp: use list instead of fixed size array for temp Kirill A. Shutemov
2012-05-04 6:46 ` [PATCH, v2] hwmon: coretemp: use list instead of fixed size array for temp data Kirill A. Shutemov
2012-05-04 13:34 ` [lm-sensors] [PATCH, v2] hwmon: coretemp: use list instead of fixed size array for temp Guenter Roeck
2012-05-04 13:34 ` [PATCH, v2] hwmon: coretemp: use list instead of fixed size array for temp data Guenter Roeck
2012-05-04 13:42 ` [lm-sensors] [PATCH, v2] hwmon: coretemp: use list instead of fixed size array for temp Kirill A. Shutemov
2012-05-04 13:42 ` [PATCH, v2] hwmon: coretemp: use list instead of fixed size array for temp data Kirill A. Shutemov
2015-07-15 16:04 ` [lm-sensors] [PATCH] " Lukasz Odzioba
2015-07-15 16:04 ` Lukasz Odzioba
2015-07-15 21:07 ` [lm-sensors] " Jean Delvare
2015-07-15 21:07 ` Jean Delvare
2015-07-16 13:17 ` [lm-sensors] " Odzioba, Lukasz
2015-07-16 13:17 ` Odzioba, Lukasz
2015-07-17 16:55 ` [lm-sensors] " Guenter Roeck
2015-07-17 16:55 ` Guenter Roeck
2015-07-17 17:28 ` [lm-sensors] " Odzioba, Lukasz
2015-07-17 17:28 ` Odzioba, Lukasz
2015-07-17 18:01 ` [lm-sensors] " Guenter Roeck
2015-07-17 18:01 ` Guenter Roeck
2015-07-17 19:23 ` [lm-sensors] " Odzioba, Lukasz
2015-07-17 19:23 ` Odzioba, Lukasz
2015-07-17 21:33 ` [lm-sensors] " Jean Delvare
2015-07-17 21:33 ` Jean Delvare
2015-07-17 19:11 ` [lm-sensors] " Jean Delvare
2015-07-17 19:11 ` Jean Delvare
2015-07-17 19:36 ` [lm-sensors] " Guenter Roeck
2015-07-17 19:36 ` Guenter Roeck
2015-07-17 21:25 ` [lm-sensors] " Jean Delvare
2015-07-17 21:25 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120501152014.GA2629@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=ak@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=khali@linux-fr.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.