From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Wolfgang Denk <wd-ynQEQJNshbs@public.gmane.org>,
Detlev Zundel <dzu-ynQEQJNshbs@public.gmane.org>,
Stefano Babic <sbabic-ynQEQJNshbs@public.gmane.org>,
Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/2] I2C: Implement DMA support into mxs-i2c
Date: Tue, 1 May 2012 16:02:56 +0200 [thread overview]
Message-ID: <201205011602.56563.marex@denx.de> (raw)
In-Reply-To: <20120501135800.GL2194-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
Dear Shawn Guo,
> On Mon, Apr 30, 2012 at 11:01:08PM +0200, Wolfram Sang wrote:
> > > > > It complains that data might be undefined, do you want it in a
> > > > > separate patch then ?
> > > >
> > > > Yes, but only if you can prove that the compiler is right.
> > >
> > > It's not right, because that variable is always initialized, but this
> > > at least squashes the compile warning.
> >
> > The compiler needs to be fixed, not the kernel.
I second this.
> Heh, this is coming up again. I'm not convincing you to take the
> change, but just curious what if this is not a compile warning but
> an error for the same cause that compiler is not right.
Can you elaborate?
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] I2C: Implement DMA support into mxs-i2c
Date: Tue, 1 May 2012 16:02:56 +0200 [thread overview]
Message-ID: <201205011602.56563.marex@denx.de> (raw)
In-Reply-To: <20120501135800.GL2194@S2101-09.ap.freescale.net>
Dear Shawn Guo,
> On Mon, Apr 30, 2012 at 11:01:08PM +0200, Wolfram Sang wrote:
> > > > > It complains that data might be undefined, do you want it in a
> > > > > separate patch then ?
> > > >
> > > > Yes, but only if you can prove that the compiler is right.
> > >
> > > It's not right, because that variable is always initialized, but this
> > > at least squashes the compile warning.
> >
> > The compiler needs to be fixed, not the kernel.
I second this.
> Heh, this is coming up again. I'm not convincing you to take the
> change, but just curious what if this is not a compile warning but
> an error for the same cause that compiler is not right.
Can you elaborate?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-05-01 14:02 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 22:36 [PATCH 1/2] I2C: Set I2C timing registers for mxs-i2c Marek Vasut
2012-04-29 22:36 ` Marek Vasut
[not found] ` <1335738969-27445-1-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2012-04-29 22:36 ` [PATCH 2/2] I2C: Implement DMA support into mxs-i2c Marek Vasut
2012-04-29 22:36 ` Marek Vasut
[not found] ` <1335738969-27445-2-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2012-04-30 6:05 ` Wolfram Sang
2012-04-30 6:05 ` Wolfram Sang
[not found] ` <20120430060554.GB7926-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-30 12:10 ` Marek Vasut
2012-04-30 12:10 ` Marek Vasut
[not found] ` <201204301410.14393.marex-ynQEQJNshbs@public.gmane.org>
2012-04-30 19:52 ` Wolfram Sang
2012-04-30 19:52 ` Wolfram Sang
[not found] ` <20120430195221.GB28226-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-30 20:07 ` Marek Vasut
2012-04-30 20:07 ` Marek Vasut
[not found] ` <201204302207.39112.marex-ynQEQJNshbs@public.gmane.org>
2012-04-30 20:30 ` Wolfram Sang
2012-04-30 20:30 ` Wolfram Sang
[not found] ` <20120430203016.GD28226-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-30 20:45 ` Marek Vasut
2012-04-30 20:45 ` Marek Vasut
[not found] ` <201204302245.57958.marex-ynQEQJNshbs@public.gmane.org>
2012-04-30 21:01 ` Wolfram Sang
2012-04-30 21:01 ` Wolfram Sang
[not found] ` <20120430210108.GE28226-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-30 21:19 ` Marek Vasut
2012-04-30 21:19 ` Marek Vasut
2012-05-01 13:58 ` Shawn Guo
2012-05-01 13:58 ` Shawn Guo
[not found] ` <20120501135800.GL2194-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-05-01 14:02 ` Marek Vasut [this message]
2012-05-01 14:02 ` Marek Vasut
[not found] ` <201205011602.56563.marex-ynQEQJNshbs@public.gmane.org>
2012-05-01 14:09 ` Shawn Guo
2012-05-01 14:09 ` Shawn Guo
[not found] ` <20120501140910.GM2194-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-05-01 14:14 ` Marek Vasut
2012-05-01 14:14 ` Marek Vasut
2012-05-01 14:37 ` Russell King - ARM Linux
2012-05-01 14:37 ` Russell King - ARM Linux
2012-04-30 5:58 ` [PATCH 1/2] I2C: Set I2C timing registers for mxs-i2c Wolfram Sang
2012-04-30 5:58 ` Wolfram Sang
[not found] ` <20120430055825.GA7926-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-30 12:05 ` Marek Vasut
2012-04-30 12:05 ` Marek Vasut
[not found] ` <201204301405.42621.marex-ynQEQJNshbs@public.gmane.org>
2012-04-30 19:43 ` Wolfram Sang
2012-04-30 19:43 ` Wolfram Sang
[not found] ` <20120430194313.GA28226-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-30 20:09 ` Marek Vasut
2012-04-30 20:09 ` Marek Vasut
[not found] ` <201204302209.12482.marex-ynQEQJNshbs@public.gmane.org>
2012-04-30 20:27 ` Wolfram Sang
2012-04-30 20:27 ` Wolfram Sang
[not found] ` <20120430202742.GC28226-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-30 20:47 ` Marek Vasut
2012-04-30 20:47 ` Marek Vasut
[not found] ` <201204302247.17242.marex-ynQEQJNshbs@public.gmane.org>
2012-04-30 21:02 ` Wolfram Sang
2012-04-30 21:02 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205011602.56563.marex@denx.de \
--to=marex-ynqeqjnshbs@public.gmane.org \
--cc=dzu-ynQEQJNshbs@public.gmane.org \
--cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sbabic-ynQEQJNshbs@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=wd-ynQEQJNshbs@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.