From: Tejun Heo <htejun@gmail.com>
To: Mark Lord <kernel@teksavvy.com>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: ata_eh_link_autopsy: Bug?
Date: Tue, 1 May 2012 14:58:54 -0700 [thread overview]
Message-ID: <20120501215854.GA21677@google.com> (raw)
In-Reply-To: <4FA04714.7050602@teksavvy.com>
On Tue, May 01, 2012 at 04:27:00PM -0400, Mark Lord wrote:
> MMmm.. even that isn't good enough, because the first ATA_QCFLAG_IO test
> bypasses the rest of that logic and triggers unconditional retries. Ugh.
Hmmm... the unconditional retry on ATA_QCFLAG_IO is intenttional so
that known good requests from FS are guaranteed to be retried no
matter how whacky the underlying device is. I'm not sure whether that
was a good decision tho. Maybe we should trust the hardware a bit
more. So, I'm not necessarily against changing it.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-05-01 21:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 20:12 ata_eh_link_autopsy: Bug? Mark Lord
2012-05-01 20:27 ` Mark Lord
2012-05-01 21:58 ` Tejun Heo [this message]
2012-05-01 23:48 ` Mark Lord
2012-05-01 23:52 ` Mark Lord
2012-05-02 0:00 ` [PATCH] libata-eh don't waste time retrying media errors Mark Lord
2012-05-02 3:03 ` [PATCH] libata-eh don't waste time retrying media errors (v2) Mark Lord
2012-05-02 15:54 ` Tejun Heo
2012-05-02 19:10 ` Mark Lord
2012-05-02 19:22 ` [PATCH] libata-eh don't waste time retrying media errors (v3) Mark Lord
2012-05-02 19:33 ` Tejun Heo
2012-05-02 19:43 ` Mark Lord
2012-05-02 19:46 ` Tejun Heo
2012-05-04 2:25 ` Jeff Garzik
2012-05-04 3:04 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120501215854.GA21677@google.com \
--to=htejun@gmail.com \
--cc=kernel@teksavvy.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.