From: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"H. Peter Anvin" <hpa@zytor.com>, Avi Kivity <avi@redhat.com>,
X86 <x86@kernel.org>, Gleb Natapov <gleb@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Cc: Xen Devel <xen-devel@lists.xensource.com>,
KVM <kvm@vger.kernel.org>,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
Virtualization <virtualization@lists.linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
Stephan Diestelhorst <stephan.diestelhorst@amd.com>,
Attilio Rao <attilio.rao@citrix.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH RFC V8 3/17] x86/ticketlock: Collapse a layer of functions
Date: Wed, 02 May 2012 15:36:51 +0530 [thread overview]
Message-ID: <20120502100651.13206.1226.sendpatchset@codeblue.in.ibm.com> (raw)
In-Reply-To: <20120502100610.13206.40.sendpatchset@codeblue.in.ibm.com>
From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Now that the paravirtualization layer doesn't exist at the spinlock
level any more, we can collapse the __ticket_ functions into the arch_
functions.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Tested-by: Attilio Rao <attilio.rao@citrix.com>
Signed-off-by: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
---
arch/x86/include/asm/spinlock.h | 35 +++++------------------------------
1 files changed, 5 insertions(+), 30 deletions(-)
diff --git a/arch/x86/include/asm/spinlock.h b/arch/x86/include/asm/spinlock.h
index 3e47608..ee4bbd4 100644
--- a/arch/x86/include/asm/spinlock.h
+++ b/arch/x86/include/asm/spinlock.h
@@ -79,7 +79,7 @@ static __always_inline void __ticket_unlock_kick(struct arch_spinlock *lock,
* in the high part, because a wide xadd increment of the low part would carry
* up and contaminate the high part.
*/
-static __always_inline void __ticket_spin_lock(struct arch_spinlock *lock)
+static __always_inline void arch_spin_lock(struct arch_spinlock *lock)
{
register struct __raw_tickets inc = { .tail = 1 };
@@ -99,7 +99,7 @@ static __always_inline void __ticket_spin_lock(struct arch_spinlock *lock)
out: barrier(); /* make sure nothing creeps before the lock is taken */
}
-static __always_inline int __ticket_spin_trylock(arch_spinlock_t *lock)
+static __always_inline int arch_spin_trylock(arch_spinlock_t *lock)
{
arch_spinlock_t old, new;
@@ -113,7 +113,7 @@ static __always_inline int __ticket_spin_trylock(arch_spinlock_t *lock)
return cmpxchg(&lock->head_tail, old.head_tail, new.head_tail) == old.head_tail;
}
-static __always_inline void __ticket_spin_unlock(arch_spinlock_t *lock)
+static __always_inline void arch_spin_unlock(arch_spinlock_t *lock)
{
__ticket_t next = lock->tickets.head + 1;
@@ -121,46 +121,21 @@ static __always_inline void __ticket_spin_unlock(arch_spinlock_t *lock)
__ticket_unlock_kick(lock, next);
}
-static inline int __ticket_spin_is_locked(arch_spinlock_t *lock)
+static inline int arch_spin_is_locked(arch_spinlock_t *lock)
{
struct __raw_tickets tmp = ACCESS_ONCE(lock->tickets);
return tmp.tail != tmp.head;
}
-static inline int __ticket_spin_is_contended(arch_spinlock_t *lock)
+static inline int arch_spin_is_contended(arch_spinlock_t *lock)
{
struct __raw_tickets tmp = ACCESS_ONCE(lock->tickets);
return (__ticket_t)(tmp.tail - tmp.head) > 1;
}
-
-static inline int arch_spin_is_locked(arch_spinlock_t *lock)
-{
- return __ticket_spin_is_locked(lock);
-}
-
-static inline int arch_spin_is_contended(arch_spinlock_t *lock)
-{
- return __ticket_spin_is_contended(lock);
-}
#define arch_spin_is_contended arch_spin_is_contended
-static __always_inline void arch_spin_lock(arch_spinlock_t *lock)
-{
- __ticket_spin_lock(lock);
-}
-
-static __always_inline int arch_spin_trylock(arch_spinlock_t *lock)
-{
- return __ticket_spin_trylock(lock);
-}
-
-static __always_inline void arch_spin_unlock(arch_spinlock_t *lock)
-{
- __ticket_spin_unlock(lock);
-}
-
static __always_inline void arch_spin_lock_flags(arch_spinlock_t *lock,
unsigned long flags)
{
WARNING: multiple messages have this Message-ID (diff)
From: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"H. Peter Anvin" <hpa@zytor.com>, Avi Kivity <avi@redhat.com>,
X86 <x86@kernel.org>, Gleb Natapov <gleb@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Cc: Attilio Rao <attilio.rao@citrix.com>,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
linux-doc@vger.kernel.org,
Virtualization <virtualization@lists.linux-foundation.org>,
Xen Devel <xen-devel@lists.xensource.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
KVM <kvm@vger.kernel.org>, Andi Kleen <andi@firstfloor.org>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Stephan Diestelhorst <stephan.diestelhorst@amd.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH RFC V8 3/17] x86/ticketlock: Collapse a layer of functions
Date: Wed, 02 May 2012 15:36:51 +0530 [thread overview]
Message-ID: <20120502100651.13206.1226.sendpatchset@codeblue.in.ibm.com> (raw)
In-Reply-To: <20120502100610.13206.40.sendpatchset@codeblue.in.ibm.com>
From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Now that the paravirtualization layer doesn't exist at the spinlock
level any more, we can collapse the __ticket_ functions into the arch_
functions.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Tested-by: Attilio Rao <attilio.rao@citrix.com>
Signed-off-by: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
---
arch/x86/include/asm/spinlock.h | 35 +++++------------------------------
1 files changed, 5 insertions(+), 30 deletions(-)
diff --git a/arch/x86/include/asm/spinlock.h b/arch/x86/include/asm/spinlock.h
index 3e47608..ee4bbd4 100644
--- a/arch/x86/include/asm/spinlock.h
+++ b/arch/x86/include/asm/spinlock.h
@@ -79,7 +79,7 @@ static __always_inline void __ticket_unlock_kick(struct arch_spinlock *lock,
* in the high part, because a wide xadd increment of the low part would carry
* up and contaminate the high part.
*/
-static __always_inline void __ticket_spin_lock(struct arch_spinlock *lock)
+static __always_inline void arch_spin_lock(struct arch_spinlock *lock)
{
register struct __raw_tickets inc = { .tail = 1 };
@@ -99,7 +99,7 @@ static __always_inline void __ticket_spin_lock(struct arch_spinlock *lock)
out: barrier(); /* make sure nothing creeps before the lock is taken */
}
-static __always_inline int __ticket_spin_trylock(arch_spinlock_t *lock)
+static __always_inline int arch_spin_trylock(arch_spinlock_t *lock)
{
arch_spinlock_t old, new;
@@ -113,7 +113,7 @@ static __always_inline int __ticket_spin_trylock(arch_spinlock_t *lock)
return cmpxchg(&lock->head_tail, old.head_tail, new.head_tail) == old.head_tail;
}
-static __always_inline void __ticket_spin_unlock(arch_spinlock_t *lock)
+static __always_inline void arch_spin_unlock(arch_spinlock_t *lock)
{
__ticket_t next = lock->tickets.head + 1;
@@ -121,46 +121,21 @@ static __always_inline void __ticket_spin_unlock(arch_spinlock_t *lock)
__ticket_unlock_kick(lock, next);
}
-static inline int __ticket_spin_is_locked(arch_spinlock_t *lock)
+static inline int arch_spin_is_locked(arch_spinlock_t *lock)
{
struct __raw_tickets tmp = ACCESS_ONCE(lock->tickets);
return tmp.tail != tmp.head;
}
-static inline int __ticket_spin_is_contended(arch_spinlock_t *lock)
+static inline int arch_spin_is_contended(arch_spinlock_t *lock)
{
struct __raw_tickets tmp = ACCESS_ONCE(lock->tickets);
return (__ticket_t)(tmp.tail - tmp.head) > 1;
}
-
-static inline int arch_spin_is_locked(arch_spinlock_t *lock)
-{
- return __ticket_spin_is_locked(lock);
-}
-
-static inline int arch_spin_is_contended(arch_spinlock_t *lock)
-{
- return __ticket_spin_is_contended(lock);
-}
#define arch_spin_is_contended arch_spin_is_contended
-static __always_inline void arch_spin_lock(arch_spinlock_t *lock)
-{
- __ticket_spin_lock(lock);
-}
-
-static __always_inline int arch_spin_trylock(arch_spinlock_t *lock)
-{
- return __ticket_spin_trylock(lock);
-}
-
-static __always_inline void arch_spin_unlock(arch_spinlock_t *lock)
-{
- __ticket_spin_unlock(lock);
-}
-
static __always_inline void arch_spin_lock_flags(arch_spinlock_t *lock,
unsigned long flags)
{
next prev parent reply other threads:[~2012-05-02 10:06 UTC|newest]
Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 10:06 [PATCH RFC V8 0/17] Paravirtualized ticket spinlocks Raghavendra K T
2012-05-02 10:06 ` Raghavendra K T
2012-05-02 10:06 ` [PATCH RFC V8 1/17] x86/spinlock: Replace pv spinlocks with pv ticketlocks Raghavendra K T
2012-05-02 10:06 ` Raghavendra K T
2012-05-02 10:06 ` [PATCH RFC V8 2/17] x86/ticketlock: Don't inline _spin_unlock when using paravirt spinlocks Raghavendra K T
2012-05-02 10:06 ` Raghavendra K T
2012-05-02 10:06 ` Raghavendra K T [this message]
2012-05-02 10:06 ` [PATCH RFC V8 3/17] x86/ticketlock: Collapse a layer of functions Raghavendra K T
2012-05-02 10:07 ` [PATCH RFC V8 4/17] xen: Defer spinlock setup until boot CPU setup Raghavendra K T
2012-05-02 10:07 ` Raghavendra K T
2012-05-02 10:07 ` [PATCH RFC V8 5/17] xen/pvticketlock: Xen implementation for PV ticket locks Raghavendra K T
2012-05-02 10:07 ` Raghavendra K T
2012-05-02 10:07 ` [PATCH RFC V8 6/17] xen/pvticketlocks: Add xen_nopvspin parameter to disable xen pv ticketlocks Raghavendra K T
2012-05-02 10:07 ` Raghavendra K T
2012-05-02 10:07 ` [PATCH RFC V8 7/17] x86/pvticketlock: Use callee-save for lock_spinning Raghavendra K T
2012-05-02 10:07 ` Raghavendra K T
2012-05-02 10:07 ` [PATCH RFC V8 8/17] x86/pvticketlock: When paravirtualizing ticket locks, increment by 2 Raghavendra K T
2012-05-02 10:07 ` Raghavendra K T
2012-05-02 10:08 ` [PATCH RFC V8 9/17] Split out rate limiting from jump_label.h Raghavendra K T
2012-05-02 10:08 ` Raghavendra K T
2012-05-02 10:08 ` [PATCH RFC V8 10/17] x86/ticketlock: Add slowpath logic Raghavendra K T
2012-05-02 10:08 ` Raghavendra K T
2012-05-02 10:08 ` [PATCH RFC V8 11/17] xen/pvticketlock: Allow interrupts to be enabled while blocking Raghavendra K T
2012-05-02 10:08 ` Raghavendra K T
2012-05-02 10:08 ` [PATCH RFC V8 12/17] xen: Enable PV ticketlocks on HVM Xen Raghavendra K T
2012-05-02 10:08 ` Raghavendra K T
2012-05-02 10:08 ` [PATCH RFC V8 13/17] kvm hypervisor : Add a hypercall to KVM hypervisor to support pv-ticketlocks Raghavendra K T
2012-05-02 10:08 ` Raghavendra K T
2012-05-02 10:09 ` [PATCH RFC V8 14/17] kvm : Fold pv_unhalt flag into GET_MP_STATE ioctl to aid migration Raghavendra K T
2012-05-02 10:09 ` Raghavendra K T
2012-05-02 10:09 ` [PATCH RFC V8 15/17] kvm guest : Add configuration support to enable debug information for KVM Guests Raghavendra K T
2012-05-02 10:09 ` Raghavendra K T
2012-05-02 10:09 ` [PATCH RFC V8 16/17] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor Raghavendra K T
2012-05-02 10:09 ` Raghavendra K T
2012-05-02 10:09 ` [PATCH RFC V8 17/17] Documentation/kvm : Add documentation on Hypercalls and features used for PV spinlock Raghavendra K T
2012-05-02 10:09 ` Raghavendra K T
2012-05-30 11:54 ` Jan Kiszka
2012-05-30 11:54 ` Jan Kiszka
2012-05-30 13:44 ` Raghavendra K T
2012-05-30 13:44 ` Raghavendra K T
2012-05-07 8:29 ` [PATCH RFC V8 0/17] Paravirtualized ticket spinlocks Ingo Molnar
2012-05-07 8:29 ` Ingo Molnar
2012-05-07 8:32 ` Avi Kivity
2012-05-07 8:32 ` Avi Kivity
2012-05-07 10:58 ` Raghavendra K T
2012-05-07 10:58 ` Raghavendra K T
2012-05-07 12:06 ` Avi Kivity
2012-05-07 12:06 ` Avi Kivity
2012-05-07 13:20 ` Raghavendra K T
2012-05-07 13:20 ` Raghavendra K T
2012-05-07 13:20 ` Raghavendra K T
2012-05-07 13:22 ` Avi Kivity
2012-05-07 13:22 ` Avi Kivity
2012-05-07 13:38 ` Raghavendra K T
2012-05-07 13:38 ` Raghavendra K T
2012-05-07 13:38 ` Raghavendra K T
2012-05-07 13:38 ` Raghavendra K T
2012-05-07 13:46 ` Srivatsa Vaddagiri
2012-05-07 13:46 ` Srivatsa Vaddagiri
2012-05-07 13:46 ` Srivatsa Vaddagiri
2012-05-07 13:49 ` Avi Kivity
2012-05-07 13:49 ` Avi Kivity
2012-05-07 13:53 ` Raghavendra K T
2012-05-07 13:53 ` Raghavendra K T
2012-05-07 13:53 ` Raghavendra K T
2012-05-07 13:53 ` Raghavendra K T
2012-05-07 13:58 ` Avi Kivity
2012-05-07 13:58 ` Avi Kivity
2012-05-07 14:47 ` Raghavendra K T
2012-05-07 14:47 ` Raghavendra K T
2012-05-07 14:52 ` Avi Kivity
2012-05-07 14:52 ` Avi Kivity
2012-05-07 14:54 ` Avi Kivity
2012-05-07 14:54 ` Avi Kivity
2012-05-07 17:25 ` Ingo Molnar
2012-05-07 17:25 ` Ingo Molnar
2012-05-07 17:25 ` Ingo Molnar
2012-05-07 17:25 ` Ingo Molnar
2012-05-07 20:42 ` Thomas Gleixner
2012-05-07 20:42 ` Thomas Gleixner
2012-05-07 20:42 ` Thomas Gleixner
2012-05-07 20:42 ` Thomas Gleixner
2012-05-08 6:46 ` Nikunj A Dadhania
2012-05-08 6:46 ` Nikunj A Dadhania
2012-05-08 6:46 ` Nikunj A Dadhania
2012-05-08 6:46 ` Nikunj A Dadhania
2012-05-15 11:26 ` [Xen-devel] " Jan Beulich
2012-05-15 11:26 ` Jan Beulich
2012-05-15 11:26 ` Jan Beulich
2012-05-08 5:25 ` Raghavendra K T
2012-05-08 5:25 ` Raghavendra K T
2012-05-08 5:25 ` Raghavendra K T
2012-05-08 5:25 ` Raghavendra K T
2012-05-13 18:45 ` Raghavendra K T
2012-05-13 18:45 ` Raghavendra K T
2012-05-13 18:45 ` Raghavendra K T
2012-05-14 4:57 ` Nikunj A Dadhania
2012-05-14 4:57 ` Nikunj A Dadhania
2012-05-14 4:57 ` Nikunj A Dadhania
2012-05-14 9:01 ` Raghavendra K T
2012-05-14 9:01 ` Raghavendra K T
2012-05-14 9:01 ` Raghavendra K T
2012-05-14 9:01 ` Raghavendra K T
2012-05-14 4:57 ` Nikunj A Dadhania
2012-05-14 7:38 ` Jeremy Fitzhardinge
2012-05-14 7:38 ` Jeremy Fitzhardinge
2012-05-14 8:11 ` Raghavendra K T
2012-05-14 8:11 ` Raghavendra K T
2012-05-16 3:19 ` Raghavendra K T
2012-05-16 3:19 ` Raghavendra K T
2012-05-16 3:19 ` Raghavendra K T
2012-05-30 11:26 ` Raghavendra K T
2012-05-30 11:26 ` Raghavendra K T
2012-05-30 11:26 ` Raghavendra K T
2012-05-30 11:26 ` Raghavendra K T
2012-06-14 12:21 ` Raghavendra K T
2012-06-14 12:21 ` Raghavendra K T
2012-06-14 12:21 ` Raghavendra K T
2012-06-14 12:21 ` Raghavendra K T
2012-05-07 13:55 ` Srivatsa Vaddagiri
2012-05-07 13:55 ` Srivatsa Vaddagiri
2012-05-07 13:55 ` Srivatsa Vaddagiri
2012-05-07 23:15 ` Jeremy Fitzhardinge
2012-05-07 23:15 ` Jeremy Fitzhardinge
2012-05-08 1:13 ` Raghavendra K T
2012-05-08 1:13 ` Raghavendra K T
2012-05-08 9:08 ` Avi Kivity
2012-05-08 9:08 ` Avi Kivity
2012-05-07 13:56 ` Raghavendra K T
2012-05-07 13:56 ` Raghavendra K T
2012-05-07 13:56 ` Raghavendra K T
2012-05-07 13:56 ` Raghavendra K T
2012-05-07 13:46 ` Srivatsa Vaddagiri
2012-05-07 13:20 ` Raghavendra K T
2012-05-13 17:59 ` Raghavendra K T
2012-05-13 17:59 ` Raghavendra K T
2012-05-13 17:59 ` Raghavendra K T
2012-05-13 17:59 ` Raghavendra K T
2012-05-07 8:29 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502100651.13206.1226.sendpatchset@codeblue.in.ibm.com \
--to=raghavendra.kt@linux.vnet.ibm.com \
--cc=andi@firstfloor.org \
--cc=attilio.rao@citrix.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=stephan.diestelhorst@amd.com \
--cc=torvalds@linux-foundation.org \
--cc=vatsa@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.