All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: alsa-devel@alsa-project.org, ben-linux@fluff.org,
	w.sang@pengutronix.de, Richard Zhao <richard.zhao@linaro.org>,
	Richard Zhao <richard.zhao@freescale.com>,
	linux-i2c@vger.kernel.org, kernel@pengutronix.de,
	dan.j.williams@intel.com, lrg@ti.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 03/11] ASoC: fsl: add sgtl5000 clock support for imx-sgtl5000
Date: Wed, 2 May 2012 13:22:29 +0100	[thread overview]
Message-ID: <20120502122228.GC5722@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120502121222.GZ2194@S2101-09.ap.freescale.net>


[-- Attachment #1.1: Type: text/plain, Size: 845 bytes --]

On Wed, May 02, 2012 at 08:12:24PM +0800, Shawn Guo wrote:
> On Wed, May 02, 2012 at 12:41:22PM +0100, Mark Brown wrote:

> > The major problem here is that we can't rely on having the clock API
> > present at all on most platforms so as soon as we start adding clock
> > support into things we have to do a performance with HAVE_CLK which is
> > at best annoying.

> Is this something that the series below tries to solve?

> http://thread.gmane.org/gmane.linux.ports.arm.kernel/163652

Well, it helps building but that's only part of the issue - we've still
got registration problems and if we were using the API in anger we would
need things like clk_set_rate() to actually work.  It's not just a case
of simply enabling and disabling clocks (which can be stubbed out pretty
effectively), audio generally needs to manage the clock rates too.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/11] ASoC: fsl: add sgtl5000 clock support for imx-sgtl5000
Date: Wed, 2 May 2012 13:22:29 +0100	[thread overview]
Message-ID: <20120502122228.GC5722@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120502121222.GZ2194@S2101-09.ap.freescale.net>

On Wed, May 02, 2012 at 08:12:24PM +0800, Shawn Guo wrote:
> On Wed, May 02, 2012 at 12:41:22PM +0100, Mark Brown wrote:

> > The major problem here is that we can't rely on having the clock API
> > present at all on most platforms so as soon as we start adding clock
> > support into things we have to do a performance with HAVE_CLK which is
> > at best annoying.

> Is this something that the series below tries to solve?

> http://thread.gmane.org/gmane.linux.ports.arm.kernel/163652

Well, it helps building but that's only part of the issue - we've still
got registration problems and if we were using the API in anger we would
need things like clk_set_rate() to actually work.  It's not just a case
of simply enabling and disabling clocks (which can be stubbed out pretty
effectively), audio generally needs to manage the clock rates too.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120502/2be059fb/attachment.sig>

  reply	other threads:[~2012-05-02 12:22 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-27  7:02 [PATCH 00/11] enable imx6q_sabrelite sgtl5000 audio support Richard Zhao
2012-04-27  7:02 ` Richard Zhao
     [not found] ` <1335510185-7906-1-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-04-27  7:02   ` [PATCH 01/11] dma: imx-sdma: make channel0 operations atomic Richard Zhao
2012-04-27  7:02     ` Richard Zhao
     [not found]     ` <1335510185-7906-2-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-04-27  7:55       ` Sascha Hauer
2012-04-27  7:55         ` Sascha Hauer
     [not found]         ` <20120427075544.GV17184-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-27  9:17           ` Richard Zhao
2012-04-27  9:17             ` Richard Zhao
2012-04-27  8:21       ` Vinod Koul
2012-04-27  8:21         ` Vinod Koul
2012-04-27  8:41         ` Richard Zhao
2012-04-27  8:41           ` Richard Zhao
     [not found]           ` <20120427084109.GO28063-iWYTGMXpHj9ITqJhDdzsOjpauB2SiJktrE5yTffgRl4@public.gmane.org>
2012-04-27 10:22             ` Vinod Koul
2012-04-27 10:22               ` Vinod Koul
2012-04-27 11:20               ` Mark Brown
2012-04-27 11:20                 ` Mark Brown
2012-04-27 11:26               ` Richard Zhao
2012-04-27 11:26                 ` Richard Zhao
2012-04-27 11:33                 ` Russell King - ARM Linux
2012-04-27 11:33                   ` Russell King - ARM Linux
     [not found]                   ` <20120427113335.GM24211-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-04-27 13:01                     ` Laxman Dewangan
2012-04-27 13:01                       ` Laxman Dewangan
2012-04-27 13:10                       ` Russell King - ARM Linux
2012-04-27 13:10                         ` Russell King - ARM Linux
     [not found]                         ` <20120427131010.GN24211-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-04-27 13:17                           ` Laxman Dewangan
2012-04-27 13:17                             ` Laxman Dewangan
2012-04-27 13:19                           ` Richard Zhao
2012-04-27 13:19                             ` Richard Zhao
2012-04-27  9:18       ` Lothar Waßmann
2012-04-27  9:18         ` Lothar Waßmann
     [not found]         ` <20378.25703.527491.719116-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>
2012-04-27 13:25           ` Richard Zhao
2012-04-27 13:25             ` Richard Zhao
     [not found]             ` <20120427132538.GU28063-iWYTGMXpHj9ITqJhDdzsOjpauB2SiJktrE5yTffgRl4@public.gmane.org>
2012-04-27 15:13               ` Lothar Waßmann
2012-04-27 15:13                 ` Lothar Waßmann
     [not found]                 ` <20378.47000.131486.237752-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>
2012-04-27 15:27                   ` Huang Shijie
2012-04-27 15:27                     ` Huang Shijie
2012-04-27  7:02   ` [PATCH 02/11] ASoC: imx-sgtl5000: add of_node_put when probe fail Richard Zhao
2012-04-27  7:02     ` Richard Zhao
     [not found]     ` <1335510185-7906-3-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-04-27 17:44       ` Mark Brown
2012-04-27 17:44         ` Mark Brown
2012-04-27  7:02   ` [PATCH 03/11] ASoC: fsl: add sgtl5000 clock support for imx-sgtl5000 Richard Zhao
2012-04-27  7:02     ` Richard Zhao
2012-04-27 17:44     ` Mark Brown
2012-04-27 17:44       ` Mark Brown
     [not found]     ` <1335510185-7906-4-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-05-01 13:44       ` Shawn Guo
2012-05-01 13:44         ` Shawn Guo
     [not found]         ` <20120501134446.GK2194-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-05-02 10:50           ` Richard Zhao
2012-05-02 10:50             ` Richard Zhao
2012-05-02 11:41             ` Mark Brown
2012-05-02 11:41               ` Mark Brown
     [not found]               ` <20120502114121.GB5722-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-05-02 12:12                 ` Shawn Guo
2012-05-02 12:12                   ` Shawn Guo
2012-05-02 12:22                   ` Mark Brown [this message]
2012-05-02 12:22                     ` Mark Brown
2012-04-27  7:02   ` [PATCH 04/11] i2c: imx: add pinctrl support Richard Zhao
2012-04-27  7:02     ` Richard Zhao
     [not found]     ` <1335510185-7906-5-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-04-27  8:40       ` Dong Aisheng
2012-04-27  8:40         ` Dong Aisheng
     [not found]         ` <20120427084056.GD826-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-04-27  9:15           ` Richard Zhao
2012-04-27  9:15             ` Richard Zhao
2012-04-27  7:02   ` [PATCH 05/11] ARM: imx6q: move imx6q_sabrelite specific code to a dedicated function Richard Zhao
2012-04-27  7:02     ` Richard Zhao
     [not found]     ` <1335510185-7906-6-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-05-01 13:18       ` Shawn Guo
2012-05-01 13:18         ` Shawn Guo
2012-04-27  7:03   ` [PATCH 06/11] ARM: dts: imx6q-sabrelite: add ssi device Richard Zhao
2012-04-27  7:03     ` Richard Zhao
     [not found]     ` <1335510185-7906-7-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-05-01 13:26       ` Shawn Guo
2012-05-01 13:26         ` Shawn Guo
     [not found]         ` <20120501132651.GJ2194-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-05-02  2:38           ` Shawn Guo
2012-05-02  2:38             ` Shawn Guo
2012-04-27  7:03   ` [PATCH 07/11] ARM: dts: imx6q-sabrelite: add audmux device Richard Zhao
2012-04-27  7:03     ` Richard Zhao
2012-04-27  7:03   ` [PATCH 08/11] ASoC: imx-audmux: add pinctrl support Richard Zhao
2012-04-27  7:03     ` Richard Zhao
2012-04-27  7:03   ` [PATCH 09/11] ARM: imx6q: add ssi1 clk_lookup Richard Zhao
2012-04-27  7:03     ` Richard Zhao
     [not found]     ` <1335510185-7906-10-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-04-27  8:04       ` Sascha Hauer
2012-04-27  8:04         ` Sascha Hauer
     [not found]         ` <20120427080412.GW17184-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-27  9:10           ` Richard Zhao
2012-04-27  9:10             ` Richard Zhao
     [not found]             ` <20120427091055.GP28063-iWYTGMXpHj9ITqJhDdzsOjpauB2SiJktrE5yTffgRl4@public.gmane.org>
2012-04-27  9:25               ` Sascha Hauer
2012-04-27  9:25                 ` Sascha Hauer
     [not found]                 ` <20120427092529.GA20478-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-30  2:01                   ` Richard Zhao
2012-04-30  2:01                     ` Richard Zhao
2012-04-30 12:18                     ` Sascha Hauer
2012-04-30 12:18                       ` Sascha Hauer
     [not found]                       ` <20120430121857.GL4141-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-05-02 10:34                         ` Richard Zhao
2012-05-02 10:34                           ` Richard Zhao
     [not found]                           ` <20120502103440.GA2982-iWYTGMXpHj9ITqJhDdzsOjpauB2SiJktrE5yTffgRl4@public.gmane.org>
2012-05-02 14:34                             ` Shawn Guo
2012-05-02 14:34                               ` Shawn Guo
     [not found]                               ` <20120502143413.GE2194-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-05-02 16:33                                 ` Sascha Hauer
2012-05-02 16:33                                   ` Sascha Hauer
2012-04-27  7:03   ` [PATCH 10/11] ARM: imx6q_sabrelite: clkdev_add cko1 for sgtl5000 Richard Zhao
2012-04-27  7:03     ` Richard Zhao
2012-05-01 12:47     ` Shawn Guo
2012-05-01 12:47       ` Shawn Guo
2012-05-01 23:39       ` Shawn Guo
2012-05-01 23:39         ` Shawn Guo
     [not found]         ` <20120501233939.GO2194-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-05-02  2:47           ` [alsa-devel] " Fabio Estevam
2012-05-02  2:47             ` Fabio Estevam
     [not found]             ` <CAOMZO5Ab5pYuOY4oLbkOc+SeeT6itKOMJu+zzodFOJaW5h+RuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-02  3:37               ` Shawn Guo
2012-05-02  3:37                 ` Shawn Guo
     [not found]       ` <20120501124706.GF2194-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-05-02 11:00         ` Richard Zhao
2012-05-02 11:00           ` Richard Zhao
2012-04-27  7:03   ` [PATCH 11/11] ARM: dts: imx6q-sabrelite: add sound device imx6q-sabrelite-sgtl5000 Richard Zhao
2012-04-27  7:03     ` Richard Zhao
     [not found]     ` <1335510185-7906-12-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-05-01 12:55       ` Shawn Guo
2012-05-01 12:55         ` Shawn Guo
     [not found]         ` <20120501125512.GG2194-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-05-02 10:37           ` Richard Zhao
2012-05-02 10:37             ` Richard Zhao
  -- strict thread matches above, loose matches on Subject: below --
2012-04-27  6:55 [PATCH 00/11] enable imx6q_sabrelite sgtl5000 audio support Richard Zhao
     [not found] ` <1335509762-7777-1-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-04-27  6:55   ` [PATCH 03/11] ASoC: fsl: add sgtl5000 clock support for imx-sgtl5000 Richard Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120502122228.GC5722@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=ben-linux@fluff.org \
    --cc=dan.j.williams@intel.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=richard.zhao@freescale.com \
    --cc=richard.zhao@linaro.org \
    --cc=shawn.guo@linaro.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.