From: Tony Lindgren <tony@atomide.com>
To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/7] ARM: OMAP2+: Clean up wrapping multiple objects in Makefile
Date: Wed, 2 May 2012 08:49:49 -0700 [thread overview]
Message-ID: <20120502154949.GF3739@atomide.com> (raw)
In-Reply-To: <CAMQu2gx3_tZnQg=+8xm4Bnnv31BTOgJki_y=aNDOAUG-xNNrvg@mail.gmail.com>
* Shilimkar, Santosh <santosh.shilimkar@ti.com> [120502 03:18]:
> On Wed, May 2, 2012 at 3:26 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Wed, May 02, 2012 at 03:18:08PM +0530, Santosh Shilimkar wrote:
> >> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> >> ---
> >> arch/arm/mach-omap2/Makefile | 160 ++++++++++++++++++++---------------------
> >> 1 files changed, 78 insertions(+), 82 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> >> index 56ed62e..669e2b1 100644
> >> --- a/arch/arm/mach-omap2/Makefile
> >> +++ b/arch/arm/mach-omap2/Makefile
> >> @@ -24,10 +24,11 @@ endif
> >> obj-$(CONFIG_TWL4030_CORE) += omap_twl.o
> >>
> >> # SMP support ONLY available for OMAP4
> >> +
> >> obj-$(CONFIG_SMP) += omap-smp.o omap-headsmp.o
> >> obj-$(CONFIG_HOTPLUG_CPU) += omap-hotplug.o
> >> -obj-$(CONFIG_ARCH_OMAP4) += omap4-common.o omap-wakeupgen.o \
> >> - sleep44xx.o
> >> +obj-$(CONFIG_ARCH_OMAP4) += omap4-common.o omap-wakeupgen.o
> >> +obj-$(CONFIG_ARCH_OMAP4) += sleep44xx.o
> >
> > Using \ in makefiles really isn't a problem. I don't think this is something
> > which we need to do, and it just creates additional changes where none is
> > required.
>
> Tony might give better reasoning for this change since he suggested it.
Mostly for making it cleaner to build shared objects between omap4 and omap5
without adding things like:
+obj-$(CONFIG_ARCH_OMAP5) += omap4-common.o omap-wakeupgen.o \
+ sleep44xx.o
But of course more localized changes will do there too to prepare adding
omap5.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] ARM: OMAP2+: Clean up wrapping multiple objects in Makefile
Date: Wed, 2 May 2012 08:49:49 -0700 [thread overview]
Message-ID: <20120502154949.GF3739@atomide.com> (raw)
In-Reply-To: <CAMQu2gx3_tZnQg=+8xm4Bnnv31BTOgJki_y=aNDOAUG-xNNrvg@mail.gmail.com>
* Shilimkar, Santosh <santosh.shilimkar@ti.com> [120502 03:18]:
> On Wed, May 2, 2012 at 3:26 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Wed, May 02, 2012 at 03:18:08PM +0530, Santosh Shilimkar wrote:
> >> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> >> ---
> >> ?arch/arm/mach-omap2/Makefile | ?160 ++++++++++++++++++++---------------------
> >> ?1 files changed, 78 insertions(+), 82 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> >> index 56ed62e..669e2b1 100644
> >> --- a/arch/arm/mach-omap2/Makefile
> >> +++ b/arch/arm/mach-omap2/Makefile
> >> @@ -24,10 +24,11 @@ endif
> >> ?obj-$(CONFIG_TWL4030_CORE) += omap_twl.o
> >>
> >> ?# SMP support ONLY available for OMAP4
> >> +
> >> ?obj-$(CONFIG_SMP) ? ? ? ? ? ? ? ? ? ?+= omap-smp.o omap-headsmp.o
> >> ?obj-$(CONFIG_HOTPLUG_CPU) ? ? ? ? ? ?+= omap-hotplug.o
> >> -obj-$(CONFIG_ARCH_OMAP4) ? ? ? ? ? ? += omap4-common.o omap-wakeupgen.o \
> >> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?sleep44xx.o
> >> +obj-$(CONFIG_ARCH_OMAP4) ? ? ? ? ? ? += omap4-common.o omap-wakeupgen.o
> >> +obj-$(CONFIG_ARCH_OMAP4) ? ? ? ? ? ? += sleep44xx.o
> >
> > Using \ in makefiles really isn't a problem. ?I don't think this is something
> > which we need to do, and it just creates additional changes where none is
> > required.
>
> Tony might give better reasoning for this change since he suggested it.
Mostly for making it cleaner to build shared objects between omap4 and omap5
without adding things like:
+obj-$(CONFIG_ARCH_OMAP5) += omap4-common.o omap-wakeupgen.o \
+ sleep44xx.o
But of course more localized changes will do there too to prepare adding
omap5.
Regards,
Tony
next prev parent reply other threads:[~2012-05-02 15:49 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 9:48 [PATCH 0/7] ARM: OMAP2+: Misc cleanup Santosh Shilimkar
2012-05-02 9:48 ` Santosh Shilimkar
2012-05-02 9:48 ` [PATCH 1/7] ARM: OMAP4: Don't compile cm2xxx_3xxx.c for OMAP4 only builds Santosh Shilimkar
2012-05-02 9:48 ` Santosh Shilimkar
2012-05-08 5:09 ` Paul Walmsley
2012-05-08 5:09 ` Paul Walmsley
2012-05-08 6:09 ` Shilimkar, Santosh
2012-05-08 6:09 ` Shilimkar, Santosh
2012-05-02 9:48 ` [PATCH 2/7] ARM: OMAP2+: Clean up wrapping multiple objects in Makefile Santosh Shilimkar
2012-05-02 9:48 ` Santosh Shilimkar
2012-05-02 9:56 ` Russell King - ARM Linux
2012-05-02 9:56 ` Russell King - ARM Linux
2012-05-02 10:14 ` Shilimkar, Santosh
2012-05-02 10:14 ` Shilimkar, Santosh
2012-05-02 15:49 ` Tony Lindgren [this message]
2012-05-02 15:49 ` Tony Lindgren
2012-05-02 9:48 ` [PATCH 3/7] ARM: OMAP4: Remove un-used WakeupGen register defines Santosh Shilimkar
2012-05-02 9:48 ` Santosh Shilimkar
2012-05-02 9:48 ` [PATCH 4/7] ARM: OMAP: dma: Make use of cpu_class_is_omap2() to avoid future patching Santosh Shilimkar
2012-05-02 9:48 ` Santosh Shilimkar
2012-05-03 21:47 ` Kevin Hilman
2012-05-03 21:47 ` Kevin Hilman
2012-05-04 7:04 ` Shilimkar, Santosh
2012-05-04 7:04 ` Shilimkar, Santosh
2012-05-04 16:46 ` Kevin Hilman
2012-05-04 16:46 ` Kevin Hilman
2012-05-02 9:48 ` [PATCH 5/7] ARM: All OMAP2PLUS machines use omap2 directory so just add one entry Santosh Shilimkar
2012-05-02 9:48 ` Santosh Shilimkar
2012-05-02 9:48 ` [PATCH 6/7] ARM: OMAP4: Reduce the static IO mapping Santosh Shilimkar
2012-05-02 9:48 ` Santosh Shilimkar
2012-05-02 9:48 ` [PATCH 7/7] ARM: OMAP4+: Add prm and cm base init function Santosh Shilimkar
2012-05-02 9:48 ` Santosh Shilimkar
2012-05-08 5:15 ` Paul Walmsley
2012-05-08 5:15 ` Paul Walmsley
2012-05-08 6:13 ` Shilimkar, Santosh
2012-05-08 6:13 ` Shilimkar, Santosh
2012-05-07 23:03 ` [PATCH 0/7] ARM: OMAP2+: Misc cleanup Tony Lindgren
2012-05-07 23:03 ` Tony Lindgren
2012-05-08 7:17 ` Santosh Shilimkar
2012-05-08 7:17 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502154949.GF3739@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.