From: H Hartley Sweeten <hartleys@visionengravers.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: linux-fbdev@vger.kernel.org, jayalk@intworks.biz,
FlorianSchandinat@gmx.de
Subject: [PATCH] video: fb_defio.c: local functions should not be exposed globally
Date: Thu, 03 May 2012 00:23:40 +0000 [thread overview]
Message-ID: <201205021723.40801.hartleys@visionengravers.com> (raw)
Functions not referenced outside of a source file should be marked
static to prevent them from being exposed globally.
Quiets the sparse warning:
warning: symbol 'fb_deferred_io_page' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Jaya Kumar <jayalk@intworks.biz>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
---
diff --git a/drivers/video/fb_defio.c b/drivers/video/fb_defio.c
index 070f26f..1ddeb11 100644
--- a/drivers/video/fb_defio.c
+++ b/drivers/video/fb_defio.c
@@ -23,7 +23,7 @@
#include <linux/rmap.h>
#include <linux/pagemap.h>
-struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
+static struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
{
void *screen_base = (void __force *) info->screen_base;
struct page *page;
WARNING: multiple messages have this Message-ID (diff)
From: H Hartley Sweeten <hartleys@visionengravers.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: <linux-fbdev@vger.kernel.org>, <jayalk@intworks.biz>,
<FlorianSchandinat@gmx.de>
Subject: [PATCH] video: fb_defio.c: local functions should not be exposed globally
Date: Wed, 2 May 2012 17:23:40 -0700 [thread overview]
Message-ID: <201205021723.40801.hartleys@visionengravers.com> (raw)
Functions not referenced outside of a source file should be marked
static to prevent them from being exposed globally.
Quiets the sparse warning:
warning: symbol 'fb_deferred_io_page' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Jaya Kumar <jayalk@intworks.biz>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
---
diff --git a/drivers/video/fb_defio.c b/drivers/video/fb_defio.c
index 070f26f..1ddeb11 100644
--- a/drivers/video/fb_defio.c
+++ b/drivers/video/fb_defio.c
@@ -23,7 +23,7 @@
#include <linux/rmap.h>
#include <linux/pagemap.h>
-struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
+static struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
{
void *screen_base = (void __force *) info->screen_base;
struct page *page;
next reply other threads:[~2012-05-03 0:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 0:23 H Hartley Sweeten [this message]
2012-05-03 0:23 ` [PATCH] video: fb_defio.c: local functions should not be exposed globally H Hartley Sweeten
2012-05-10 0:11 ` Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205021723.40801.hartleys@visionengravers.com \
--to=hartleys@visionengravers.com \
--cc=FlorianSchandinat@gmx.de \
--cc=jayalk@intworks.biz \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.