From: Arnd Bergmann <arnd@arndb.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-serial@vger.kernel.org, horms@verge.net.au,
linux-sh@vger.kernel.org, swarren@wwwdotorg.org,
linux-kernel@vger.kernel.org, rjw@sisk.pl, lethal@linux-sh.org,
olof@lixom.net, dan.j.williams@intel.com, alan@linux.intel.com
Subject: Re: [PATCH 06/06] serial8250-em: Add Emma Mobile UART driver
Date: Thu, 03 May 2012 08:46:54 +0000 [thread overview]
Message-ID: <201205030846.55250.arnd@arndb.de> (raw)
In-Reply-To: <20120502212205.GA12212@kroah.com>
On Wednesday 02 May 2012, Greg KH wrote:
> > > +
> > > +config SERIAL_8250_EM
> > > + tristate "Support for Emma Mobile intergrated serial port"
> > > + depends on SERIAL_8250
> >
> > Should we depend on arch=ARM or something similar? Even if the
> > driver is written to be arch independent, if the Emma itself is
> > physically tied to ARM platforms, we probably don't need to be
> > building it for sparc allyesconfig etc.
>
> Yeah, it doesn't build on x86-64, I get the following build problems:
> ERROR: "clk_get_rate" [drivers/tty/serial/8250/8250_em.ko] undefined!
> ERROR: "clk_enable" [drivers/tty/serial/8250/8250_em.ko] undefined!
> ERROR: "clk_get" [drivers/tty/serial/8250/8250_em.ko] undefined!
> ERROR: "clk_put" [drivers/tty/serial/8250/8250_em.ko] undefined!
> ERROR: "clk_disable" [drivers/tty/serial/8250/8250_em.ko] undefined!
>
> So it should depend on some arch that has clk at the least.
>
> Magnus, care to redo just this one patch that fixes this up? I've
> applied the first 5 already.
I think it's best to make it depend on HAVE_CLK, but depending on
ARM && HAVE_CLK is also fine with me. I would not like to have it depend
on EMMA specifically though because I want to increase built coverage.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-serial@vger.kernel.org, horms@verge.net.au,
linux-sh@vger.kernel.org, swarren@wwwdotorg.org,
linux-kernel@vger.kernel.org, rjw@sisk.pl, lethal@linux-sh.org,
olof@lixom.net, dan.j.williams@intel.com, alan@linux.intel.com
Subject: Re: [PATCH 06/06] serial8250-em: Add Emma Mobile UART driver
Date: Thu, 3 May 2012 08:46:54 +0000 [thread overview]
Message-ID: <201205030846.55250.arnd@arndb.de> (raw)
In-Reply-To: <20120502212205.GA12212@kroah.com>
On Wednesday 02 May 2012, Greg KH wrote:
> > > +
> > > +config SERIAL_8250_EM
> > > + tristate "Support for Emma Mobile intergrated serial port"
> > > + depends on SERIAL_8250
> >
> > Should we depend on arch=ARM or something similar? Even if the
> > driver is written to be arch independent, if the Emma itself is
> > physically tied to ARM platforms, we probably don't need to be
> > building it for sparc allyesconfig etc.
>
> Yeah, it doesn't build on x86-64, I get the following build problems:
> ERROR: "clk_get_rate" [drivers/tty/serial/8250/8250_em.ko] undefined!
> ERROR: "clk_enable" [drivers/tty/serial/8250/8250_em.ko] undefined!
> ERROR: "clk_get" [drivers/tty/serial/8250/8250_em.ko] undefined!
> ERROR: "clk_put" [drivers/tty/serial/8250/8250_em.ko] undefined!
> ERROR: "clk_disable" [drivers/tty/serial/8250/8250_em.ko] undefined!
>
> So it should depend on some arch that has clk at the least.
>
> Magnus, care to redo just this one patch that fixes this up? I've
> applied the first 5 already.
I think it's best to make it depend on HAVE_CLK, but depending on
ARM && HAVE_CLK is also fine with me. I would not like to have it depend
on EMMA specifically though because I want to increase built coverage.
Arnd
next prev parent reply other threads:[~2012-05-03 8:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 12:46 [PATCH 00/06] serial8250: DLL/DLM rework, Emma Mobile UART driver Magnus Damm
2012-05-02 12:46 ` Magnus Damm
2012-05-02 12:46 ` [PATCH 01/06] serial8250: Add dl_read()/dl_write() callbacks Magnus Damm
2012-05-02 12:46 ` Magnus Damm
2012-05-02 12:47 ` [PATCH 02/06] serial8250: Use dl_read()/dl_write() on Alchemy Magnus Damm
2012-05-02 12:47 ` Magnus Damm
2012-05-02 12:47 ` [PATCH 03/06] serial8250: Use dl_read()/dl_write() on RM9K Magnus Damm
2012-05-02 12:47 ` Magnus Damm
2012-05-02 12:47 ` [PATCH 04/06] serial8250: Clean up default map and dl code Magnus Damm
2012-05-02 12:47 ` Magnus Damm
2012-05-02 12:47 ` [PATCH 05/06] serial8250: Introduce serial8250_register_8250_port() Magnus Damm
2012-05-02 12:47 ` Magnus Damm
2012-05-02 12:47 ` [PATCH 06/06] serial8250-em: Add Emma Mobile UART driver Magnus Damm
2012-05-02 12:47 ` Magnus Damm
2012-05-02 14:41 ` Paul Gortmaker
2012-05-02 14:41 ` Paul Gortmaker
2012-05-02 14:41 ` Paul Gortmaker
2012-05-02 21:22 ` Greg KH
2012-05-02 21:22 ` Greg KH
2012-05-03 8:46 ` Arnd Bergmann [this message]
2012-05-03 8:46 ` Arnd Bergmann
2012-05-03 12:19 ` Magnus Damm
2012-05-03 12:19 ` Magnus Damm
2012-05-02 13:03 ` [PATCH 00/06] serial8250: DLL/DLM rework, " Alan Cox
2012-05-02 13:03 ` Alan Cox
2012-05-02 13:12 ` Arnd Bergmann
2012-05-02 13:12 ` Arnd Bergmann
2012-05-04 16:28 ` Arnd Bergmann
2012-05-04 16:28 ` Arnd Bergmann
2012-05-08 16:34 ` Magnus Damm
2012-05-08 16:34 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205030846.55250.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alan@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=olof@lixom.net \
--cc=paul.gortmaker@windriver.com \
--cc=rjw@sisk.pl \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.