From: Seth Forshee <seth.forshee@canonical.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: platform-driver-x86@vger.kernel.org, Akio Idehara <zbe64533@gmail.com>
Subject: Re: [PATCH] toshiba_acpi: Only register backlight device when interface is read/write
Date: Thu, 3 May 2012 16:02:18 -0500 [thread overview]
Message-ID: <20120503210218.GD23573@thinkpad-t410> (raw)
In-Reply-To: <20120503203257.GE29437@srcf.ucam.org>
On Thu, May 03, 2012 at 09:32:57PM +0100, Matthew Garrett wrote:
> Merged for -next, thanks. I fixed up the conflicts with the the
> transflective display patch, but someone should probably verify them.
At a glance I see a couple of obvious mistakes, one of which will fail
to build.
> static int __get_lcd_brightness(struct toshiba_acpi_dev *dev)
> {
> u32 hci_result;
> u32 value;
> + int brightness;
brightness needs to be initialized to 0. As-is it should generate a
warning about using an uninitialized variable.
> static const struct backlight_ops toshiba_backlight_data = {
> + .iotns = BL_CORE_SUSPENDRESUME,
Should be options.
next prev parent reply other threads:[~2012-05-03 21:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 16:23 [PATCH] toshiba_acpi: Only register backlight device when interface is read/write Seth Forshee
2012-04-20 15:40 ` Akio Idehara
2012-05-03 20:32 ` Matthew Garrett
2012-05-03 21:02 ` Seth Forshee [this message]
2012-05-03 21:10 ` Seth Forshee
2012-05-03 21:16 ` Matthew Garrett
2012-05-04 13:07 ` Akio Idehara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120503210218.GD23573@thinkpad-t410 \
--to=seth.forshee@canonical.com \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=zbe64533@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.