From: Akio Idehara <zbe64533@gmail.com>
To: seth.forshee@canonical.com
Cc: mjg59@srcf.ucam.org, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] toshiba_acpi: Only register backlight device when interface is read/write
Date: Sat, 21 Apr 2012 00:40:42 +0900 [thread overview]
Message-ID: <4F91837A.4070509@gmail.com> (raw)
In-Reply-To: <1334852630-8829-1-git-send-email-seth.forshee@canonical.com>
Seth Forshee wrote:
> Currently the backlight device is registered unconditionally, but many
> (probably most) Toshibas either don't support HCI_LCD_BRIGHTNESS or only
> support reading from it. This patch adds a test of HCI_LCD_BRIGHTNESS
> during initialization and only registers the backlight device if this
> interface supports both reads and writes.
>
> Cc: Akio Idehara <zbe64533@gmail.com>
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> ---
> Matthew,
>
> Please consider applying this as a fix for 3.4.
>
> This is certainly going to conflict with Akio's tr_backlight patch, but
> I made no attempt at merging the two since the tr_backlight patch is not
> applied yet and is probably 3.5 material anyway. I'm more than happy to
> work with Akio to fix up the conflicts.
This is working fine for me. Thank you!
I'll try to merge my tr_backlight patch after this patch is applied.
Tested-by: Akio Idehara <zbe64533@gmail.com>
next prev parent reply other threads:[~2012-04-20 15:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 16:23 [PATCH] toshiba_acpi: Only register backlight device when interface is read/write Seth Forshee
2012-04-20 15:40 ` Akio Idehara [this message]
2012-05-03 20:32 ` Matthew Garrett
2012-05-03 21:02 ` Seth Forshee
2012-05-03 21:10 ` Seth Forshee
2012-05-03 21:16 ` Matthew Garrett
2012-05-04 13:07 ` Akio Idehara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F91837A.4070509@gmail.com \
--to=zbe64533@gmail.com \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.