All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: linux-kernel@vger.kernel.org, tj@kernel.org, hpa@linux.intel.com,
	paul.gortmaker@windriver.com, akpm@linux-foundation.org,
	linux-mm@kvack.org
Subject: Re: [RFC PATCH] Expand memblock=debug to provide a bit more details (v1).
Date: Fri, 4 May 2012 15:24:59 -0400	[thread overview]
Message-ID: <20120504192459.GA5684@phenom.dumpdata.com> (raw)
In-Reply-To: <CAE9FiQWOps3Hmw=p6mWObRnu2KHVNshpoY+uWcAAQd1Yxi54yQ@mail.gmail.com>

On Fri, May 04, 2012 at 12:22:58PM -0700, Yinghai Lu wrote:
> On Fri, May 4, 2012 at 11:49 AM, Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
> > While trying to track down some memory allocation issues, I realized that
> > memblock=debug was giving some information, but for guests with 256GB or
> > so the majority of it was just:
> >
> >  memblock_reserve: [0x00003efeeea000-0x00003efeeeb000] __alloc_memory_core_early+0x5c/0x64
> >
> > which really didn't tell me that much. With these patches I know it is:
> >
> >  memblock_reserve: [0x00003ffe724000-0x00003ffe725000] (4kB) vmemmap_pmd_populate+0x4b/0xa2
> >
> > .. which isn't really that useful for the problem I was tracking down, but
> > it does help in figuring out which routines are using memblock.
> >
> 
> that RET_IP is not very helpful for debugging.

Is there a better way of doing it that is automatic?
> 
> Actually I have local debug patch for memblock. please check if that
> is going to help debugging.
> 
> Thanks
> 
> Yinghai



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: linux-kernel@vger.kernel.org, tj@kernel.org, hpa@linux.intel.com,
	paul.gortmaker@windriver.com, akpm@linux-foundation.org,
	linux-mm@kvack.org
Subject: Re: [RFC PATCH] Expand memblock=debug to provide a bit more details (v1).
Date: Fri, 4 May 2012 15:24:59 -0400	[thread overview]
Message-ID: <20120504192459.GA5684@phenom.dumpdata.com> (raw)
In-Reply-To: <CAE9FiQWOps3Hmw=p6mWObRnu2KHVNshpoY+uWcAAQd1Yxi54yQ@mail.gmail.com>

On Fri, May 04, 2012 at 12:22:58PM -0700, Yinghai Lu wrote:
> On Fri, May 4, 2012 at 11:49 AM, Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
> > While trying to track down some memory allocation issues, I realized that
> > memblock=debug was giving some information, but for guests with 256GB or
> > so the majority of it was just:
> >
> >  memblock_reserve: [0x00003efeeea000-0x00003efeeeb000] __alloc_memory_core_early+0x5c/0x64
> >
> > which really didn't tell me that much. With these patches I know it is:
> >
> >  memblock_reserve: [0x00003ffe724000-0x00003ffe725000] (4kB) vmemmap_pmd_populate+0x4b/0xa2
> >
> > .. which isn't really that useful for the problem I was tracking down, but
> > it does help in figuring out which routines are using memblock.
> >
> 
> that RET_IP is not very helpful for debugging.

Is there a better way of doing it that is automatic?
> 
> Actually I have local debug patch for memblock. please check if that
> is going to help debugging.
> 
> Thanks
> 
> Yinghai




  reply	other threads:[~2012-05-04 19:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-04 18:49 [RFC PATCH] Expand memblock=debug to provide a bit more details (v1) Konrad Rzeszutek Wilk
2012-05-04 18:49 ` Konrad Rzeszutek Wilk
2012-05-04 18:49 ` [PATCH 1/2] memblock: Add _THIS_IP off the caller to memblock debug statements and size in kB Konrad Rzeszutek Wilk
2012-05-04 18:49   ` Konrad Rzeszutek Wilk
2012-05-04 18:49 ` [PATCH 2/2] bootmem/sparsemem: Have a new __alloc_bootmem_node_high Konrad Rzeszutek Wilk
2012-05-04 18:49   ` Konrad Rzeszutek Wilk
2012-05-04 19:22 ` [RFC PATCH] Expand memblock=debug to provide a bit more details (v1) Yinghai Lu
2012-05-04 19:24   ` Konrad Rzeszutek Wilk [this message]
2012-05-04 19:24     ` Konrad Rzeszutek Wilk
2012-05-08 17:35     ` H. Peter Anvin
2012-05-08 17:35       ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120504192459.GA5684@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=tj@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.