* [patch] isp1704_charger: use after free on probe error
@ 2012-03-27 20:22 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2012-03-27 20:22 UTC (permalink / raw)
To: Anton Vorontsov, Felipe Contreras
Cc: Heikki Krogerus, Felipe Balbi, Marek Vasut, linux-kernel,
kernel-janitors
We can't use "isp" after freeing it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/power/isp1704_charger.c b/drivers/power/isp1704_charger.c
index 39eb50f..e5ccd29 100644
--- a/drivers/power/isp1704_charger.c
+++ b/drivers/power/isp1704_charger.c
@@ -474,13 +474,13 @@ static int __devinit isp1704_charger_probe(struct platform_device *pdev)
fail2:
power_supply_unregister(&isp->psy);
fail1:
+ isp1704_charger_set_power(isp, 0);
usb_put_transceiver(isp->phy);
fail0:
kfree(isp);
dev_err(&pdev->dev, "failed to register isp1704 with error %d\n", ret);
- isp1704_charger_set_power(isp, 0);
return ret;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [patch] isp1704_charger: use after free on probe error
@ 2012-03-27 20:22 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2012-03-27 20:22 UTC (permalink / raw)
To: Anton Vorontsov, Felipe Contreras
Cc: Heikki Krogerus, Felipe Balbi, Marek Vasut, linux-kernel,
kernel-janitors
We can't use "isp" after freeing it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/power/isp1704_charger.c b/drivers/power/isp1704_charger.c
index 39eb50f..e5ccd29 100644
--- a/drivers/power/isp1704_charger.c
+++ b/drivers/power/isp1704_charger.c
@@ -474,13 +474,13 @@ static int __devinit isp1704_charger_probe(struct platform_device *pdev)
fail2:
power_supply_unregister(&isp->psy);
fail1:
+ isp1704_charger_set_power(isp, 0);
usb_put_transceiver(isp->phy);
fail0:
kfree(isp);
dev_err(&pdev->dev, "failed to register isp1704 with error %d\n", ret);
- isp1704_charger_set_power(isp, 0);
return ret;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch] isp1704_charger: use after free on probe error
2012-03-27 20:22 ` Dan Carpenter
@ 2012-04-14 21:19 ` Felipe Contreras
-1 siblings, 0 replies; 6+ messages in thread
From: Felipe Contreras @ 2012-04-14 21:19 UTC (permalink / raw)
To: Dan Carpenter
Cc: Anton Vorontsov, Heikki Krogerus, Felipe Balbi, Marek Vasut,
linux-kernel, kernel-janitors
On Tue, Mar 27, 2012 at 11:22 PM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> We can't use "isp" after freeing it.
Oops!
Reviewed-by: Felipe Contreras <felipe.contreras@gmail.com>
--
Felipe Contreras
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] isp1704_charger: use after free on probe error
@ 2012-04-14 21:19 ` Felipe Contreras
0 siblings, 0 replies; 6+ messages in thread
From: Felipe Contreras @ 2012-04-14 21:19 UTC (permalink / raw)
To: Dan Carpenter
Cc: Anton Vorontsov, Heikki Krogerus, Felipe Balbi, Marek Vasut,
linux-kernel, kernel-janitors
On Tue, Mar 27, 2012 at 11:22 PM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> We can't use "isp" after freeing it.
Oops!
Reviewed-by: Felipe Contreras <felipe.contreras@gmail.com>
--
Felipe Contreras
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] isp1704_charger: use after free on probe error
2012-04-14 21:19 ` Felipe Contreras
@ 2012-05-06 3:03 ` Anton Vorontsov
-1 siblings, 0 replies; 6+ messages in thread
From: Anton Vorontsov @ 2012-05-06 3:03 UTC (permalink / raw)
To: Felipe Contreras
Cc: Dan Carpenter, Heikki Krogerus, Felipe Balbi, Marek Vasut,
linux-kernel, kernel-janitors
On Sun, Apr 15, 2012 at 12:19:16AM +0300, Felipe Contreras wrote:
> On Tue, Mar 27, 2012 at 11:22 PM, Dan Carpenter
> <dan.carpenter@oracle.com> wrote:
> > We can't use "isp" after freeing it.
>
> Oops!
>
> Reviewed-by: Felipe Contreras <felipe.contreras@gmail.com>
Applied, thanks!
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] isp1704_charger: use after free on probe error
@ 2012-05-06 3:03 ` Anton Vorontsov
0 siblings, 0 replies; 6+ messages in thread
From: Anton Vorontsov @ 2012-05-06 3:03 UTC (permalink / raw)
To: Felipe Contreras
Cc: Dan Carpenter, Heikki Krogerus, Felipe Balbi, Marek Vasut,
linux-kernel, kernel-janitors
On Sun, Apr 15, 2012 at 12:19:16AM +0300, Felipe Contreras wrote:
> On Tue, Mar 27, 2012 at 11:22 PM, Dan Carpenter
> <dan.carpenter@oracle.com> wrote:
> > We can't use "isp" after freeing it.
>
> Oops!
>
> Reviewed-by: Felipe Contreras <felipe.contreras@gmail.com>
Applied, thanks!
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-05-06 3:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-27 20:22 [patch] isp1704_charger: use after free on probe error Dan Carpenter
2012-03-27 20:22 ` Dan Carpenter
2012-04-14 21:19 ` Felipe Contreras
2012-04-14 21:19 ` Felipe Contreras
2012-05-06 3:03 ` Anton Vorontsov
2012-05-06 3:03 ` Anton Vorontsov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.