From: Joerg Roedel <joerg.roedel@amd.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, <kvm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: X86: Remove stale values from ctxt->memop before emulation
Date: Mon, 7 May 2012 12:43:01 +0200 [thread overview]
Message-ID: <20120507104300.GJ4687@amd.com> (raw)
In-Reply-To: <4FA7A159.8050109@redhat.com>
On Mon, May 07, 2012 at 01:18:01PM +0300, Avi Kivity wrote:
> On 05/07/2012 01:12 PM, Joerg Roedel wrote:
> >
> > The instruction emulation for bsrw is broken in KVM because
> > the code always uses bsr with 32 or 64 bit operand size for
> > emulation. Fix that by using emulate_2op_SrcV_nobyte() macro
> > to use guest operand size for emulation.
> >
>
> It looks fine. Do you know what triggered this regression? (for
> figuring out if it's 3.4 material)
Looks like it is 3.4 (and -stable) material. I tested a few older
kernels and the test passes on 3.0 but fails on 3.2 an later kernels
(I have not tested 3.1).
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2012-05-07 10:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 16:14 [PATCH] KVM: X86: Remove stale values from ctxt->memop before emulation Joerg Roedel
2012-05-06 8:21 ` Avi Kivity
2012-05-07 10:12 ` Joerg Roedel
2012-05-07 10:18 ` Avi Kivity
2012-05-07 10:43 ` Joerg Roedel [this message]
2012-05-14 8:32 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120507104300.GJ4687@amd.com \
--to=joerg.roedel@amd.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.