All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Russ Anderson <rja@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Yinghai Lu <yinghai@kernel.org>,
	David Miller <davem@davemloft.net>
Subject: Re: [patch] mm: nobootmem: fix sign extend problem in __free_pages_memory()
Date: Mon, 7 May 2012 14:32:18 -0700	[thread overview]
Message-ID: <20120507143218.e8cc5584.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120507193202.GA11518@sgi.com>

On Mon, 7 May 2012 14:32:03 -0500
Russ Anderson <rja@sgi.com> wrote:

> Systems with 8 TBytes of memory or greater can hit a problem 
> where only the the first 8 TB of memory shows up.

erk.

>  This is
> due to "int i" being smaller than "unsigned long start_aligned",
> causing the high bits to be dropped.
> 
> The fix is to change i to unsigned long to match start_aligned
> and end_aligned.
> 
> Thanks to Jack Steiner (steiner@sgi.com) for assistance tracking
> this down.
> 

I added the Cc: <stable@vger.kernel.org> to this.  The fix is small and
safe and someone might want to run older kernels on such a machine.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Russ Anderson <rja@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Yinghai Lu <yinghai@kernel.org>,
	David Miller <davem@davemloft.net>
Subject: Re: [patch] mm: nobootmem: fix sign extend problem in __free_pages_memory()
Date: Mon, 7 May 2012 14:32:18 -0700	[thread overview]
Message-ID: <20120507143218.e8cc5584.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120507193202.GA11518@sgi.com>

On Mon, 7 May 2012 14:32:03 -0500
Russ Anderson <rja@sgi.com> wrote:

> Systems with 8 TBytes of memory or greater can hit a problem 
> where only the the first 8 TB of memory shows up.

erk.

>  This is
> due to "int i" being smaller than "unsigned long start_aligned",
> causing the high bits to be dropped.
> 
> The fix is to change i to unsigned long to match start_aligned
> and end_aligned.
> 
> Thanks to Jack Steiner (steiner@sgi.com) for assistance tracking
> this down.
> 

I added the Cc: <stable@vger.kernel.org> to this.  The fix is small and
safe and someone might want to run older kernels on such a machine.


  reply	other threads:[~2012-05-07 21:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-07 19:32 [patch] mm: nobootmem: fix sign extend problem in __free_pages_memory() Russ Anderson
2012-05-07 19:32 ` Russ Anderson
2012-05-07 21:32 ` Andrew Morton [this message]
2012-05-07 21:32   ` Andrew Morton
2012-05-08 20:16 ` Yinghai Lu
2012-05-08 20:16   ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120507143218.e8cc5584.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rja@sgi.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.